From: Peng Fan <peng.fan@nxp.com> To: Sudeep Holla <sudeep.holla@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH 3/4] firmware: arm_scmi: Check shmem property for channel availablity Date: Wed, 1 Apr 2020 01:15:08 +0000 [thread overview] Message-ID: <AM0PR04MB44819AF3A77BF5362EE95D6388C90@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200327163654.13389-4-sudeep.holla@arm.com> > Subject: [PATCH 3/4] firmware: arm_scmi: Check shmem property for channel > availablity > > Instead of declaring the channel availabilty unconditionally, let us check for > the presence of "shmem" property and return the channel availablity > accordingly. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/arm_scmi/smc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/smc.c > b/drivers/firmware/arm_scmi/smc.c index dd4b54c29679..5929c668dc1d > 100644 > --- a/drivers/firmware/arm_scmi/smc.c > +++ b/drivers/firmware/arm_scmi/smc.c > @@ -33,6 +33,11 @@ struct scmi_smc { > > static bool smc_chan_available(struct device *dev, int idx) { > + struct device_node *np = of_parse_phandle(dev->of_node, "shmem", 0); > + if (!np) > + return false; > + > + of_node_put(np); > return true; > } This is global shared mem:) Reviewed-by: Peng Fan <peng.fan@nxp.com> > > -- > 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Sudeep Holla <sudeep.holla@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH 3/4] firmware: arm_scmi: Check shmem property for channel availablity Date: Wed, 1 Apr 2020 01:15:08 +0000 [thread overview] Message-ID: <AM0PR04MB44819AF3A77BF5362EE95D6388C90@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200327163654.13389-4-sudeep.holla@arm.com> > Subject: [PATCH 3/4] firmware: arm_scmi: Check shmem property for channel > availablity > > Instead of declaring the channel availabilty unconditionally, let us check for > the presence of "shmem" property and return the channel availablity > accordingly. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/arm_scmi/smc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/smc.c > b/drivers/firmware/arm_scmi/smc.c index dd4b54c29679..5929c668dc1d > 100644 > --- a/drivers/firmware/arm_scmi/smc.c > +++ b/drivers/firmware/arm_scmi/smc.c > @@ -33,6 +33,11 @@ struct scmi_smc { > > static bool smc_chan_available(struct device *dev, int idx) { > + struct device_node *np = of_parse_phandle(dev->of_node, "shmem", 0); > + if (!np) > + return false; > + > + of_node_put(np); > return true; > } This is global shared mem:) Reviewed-by: Peng Fan <peng.fan@nxp.com> > > -- > 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-01 1:15 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 16:36 [PATCH 0/4] firmware: arm_scmi: Extend SMC/HVC to support multiple channels Sudeep Holla 2020-03-27 16:36 ` Sudeep Holla 2020-03-27 16:36 ` [PATCH 1/4] firmware: arm_scmi: Make mutex channel specific Sudeep Holla 2020-03-27 16:36 ` Sudeep Holla 2020-04-01 1:12 ` Peng Fan 2020-04-01 1:12 ` Peng Fan 2020-04-01 9:12 ` Sudeep Holla 2020-04-01 9:12 ` Sudeep Holla 2020-04-01 9:14 ` Peng Fan 2020-04-01 9:14 ` Peng Fan 2020-04-01 9:28 ` Sudeep Holla 2020-04-01 9:28 ` Sudeep Holla 2020-04-01 9:14 ` Peng Fan 2020-04-01 9:14 ` Peng Fan 2020-03-27 16:36 ` [PATCH 2/4] firmware: arm_scmi: Drop empty stub for smc_mark_txdone Sudeep Holla 2020-03-27 16:36 ` Sudeep Holla 2020-04-01 1:15 ` Peng Fan 2020-04-01 1:15 ` Peng Fan 2020-03-27 16:36 ` [PATCH 3/4] firmware: arm_scmi: Check shmem property for channel availablity Sudeep Holla 2020-03-27 16:36 ` Sudeep Holla 2020-04-01 1:15 ` Peng Fan [this message] 2020-04-01 1:15 ` Peng Fan 2020-04-01 9:05 ` Sudeep Holla 2020-04-01 9:05 ` Sudeep Holla 2020-03-27 16:36 ` [PATCH 4/4] firmware: arm_scmi: Drop checking for shmem property in parent node Sudeep Holla 2020-03-27 16:36 ` Sudeep Holla 2020-04-01 1:19 ` Peng Fan 2020-04-01 1:19 ` Peng Fan 2020-03-31 13:53 ` [PATCH 0/4] firmware: arm_scmi: Extend SMC/HVC to support multiple channels Peng Fan 2020-03-31 13:53 ` Peng Fan 2020-03-31 14:21 ` Sudeep Holla 2020-03-31 14:21 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB44819AF3A77BF5362EE95D6388C90@AM0PR04MB4481.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.