From: Peter Chen <peter.chen@nxp.com>
To: Philipp Puschmann <pp@emlix.com>,
Philipp Puschmann <philipp.puschmann@emlix.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
Date: Tue, 22 Jan 2019 07:50:09 +0000 [thread overview]
Message-ID: <AM0PR04MB5314CEFFC0FEB91184FD872D8B980@AM0PR04MB5314.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <7d0da12b-0173-aca1-b0eb-78a00681d35d@emlix.com>
> Am 17.01.19 um 08:01 schrieb Peter Chen:
> >
> >>
> >> The i.MX6q/dl USB controller may drive the usb power line directly,
> >> but the polarity depends on the board. Reset state of the polarity is
> >> low-active so add this property to allow it to be high-active.
> >>
> >
> > As far as I know, most of i.mx USB controllers (except imx28/23, but
> > they don't have non-core registers) work like this, and most of them
> > are low active for PP default. Would you just use "i.mx" at both your code and
> your comment?
>
> Am i right that i have to add my code block to (nearly) all other version specific init
> functions then?
Besides your current patch, only usbmisc_imx7d_init is needed to add the same content.
Peter
> Will do so in next days and then send a v4 of this patch.
> >
> > Peter
> >
> >> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
> >> ---
> >> Changes in v3: add description
> >> ---
> >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> index adae82385dd6..8696e3eff6e7 100644
> >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> @@ -93,6 +93,7 @@ i.mx specific properties
> >> - over-current-active-low: over current signal polarity is active low.
> >> - over-current-active-high: over current signal polarity is active high.
> >> It's recommended to specify the over current polarity.
> >> +- power-active-high: power signal polarity is high active (only for
> >> +imx6q/dl)
> >> - external-vbus-divider: enables off-chip resistor divider for Vbus
> >>
> >> Example:
> >> --
> >> 2.20.1
> >
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@nxp.com>
To: Philipp Puschmann <pp@emlix.com>,
Philipp Puschmann <philipp.puschmann@emlix.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
Date: Tue, 22 Jan 2019 07:50:09 +0000 [thread overview]
Message-ID: <AM0PR04MB5314CEFFC0FEB91184FD872D8B980@AM0PR04MB5314.eurprd04.prod.outlook.com> (raw)
> Am 17.01.19 um 08:01 schrieb Peter Chen:
> >
> >>
> >> The i.MX6q/dl USB controller may drive the usb power line directly,
> >> but the polarity depends on the board. Reset state of the polarity is
> >> low-active so add this property to allow it to be high-active.
> >>
> >
> > As far as I know, most of i.mx USB controllers (except imx28/23, but
> > they don't have non-core registers) work like this, and most of them
> > are low active for PP default. Would you just use "i.mx" at both your code and
> your comment?
>
> Am i right that i have to add my code block to (nearly) all other version specific init
> functions then?
Besides your current patch, only usbmisc_imx7d_init is needed to add the same content.
Peter
> Will do so in next days and then send a v4 of this patch.
> >
> > Peter
> >
> >> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
> >> ---
> >> Changes in v3: add description
> >> ---
> >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> index adae82385dd6..8696e3eff6e7 100644
> >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> @@ -93,6 +93,7 @@ i.mx specific properties
> >> - over-current-active-low: over current signal polarity is active low.
> >> - over-current-active-high: over current signal polarity is active high.
> >> It's recommended to specify the over current polarity.
> >> +- power-active-high: power signal polarity is high active (only for
> >> +imx6q/dl)
> >> - external-vbus-divider: enables off-chip resistor divider for Vbus
> >>
> >> Example:
> >> --
> >> 2.20.1
> >
next prev parent reply other threads:[~2019-01-22 7:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 12:31 [PATCH 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Philipp Puschmann
2019-01-15 12:31 ` [1/2] " Philipp Puschmann
2019-01-15 12:31 ` [PATCH 2/2] usb: chipidea: imx: set power polarity Philipp Puschmann
2019-01-15 12:31 ` [2/2] " Philipp Puschmann
2019-01-16 10:51 ` [PATCH v2,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Philipp Puschmann
2019-01-16 10:51 ` [v2,1/2] " Philipp Puschmann
2019-01-16 10:51 ` [PATCH v2,2/2] usb: chipidea: imx: set power polarity Philipp Puschmann
2019-01-16 10:51 ` [v2,2/2] " Philipp Puschmann
2019-01-16 11:11 ` [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Philipp Puschmann
2019-01-16 11:11 ` [v3,1/2] " Philipp Puschmann
2019-01-16 11:11 ` [PATCH v3 2/2] usb: chipidea: imx: set power polarity Philipp Puschmann
2019-01-16 11:11 ` [v3,2/2] " Philipp Puschmann
2019-01-16 19:51 ` [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Rob Herring
2019-01-16 19:51 ` [v3,1/2] " Rob Herring
2019-01-16 19:51 ` [PATCH v3 1/2] " Rob Herring
2019-01-17 7:01 ` Peter Chen
2019-01-17 7:01 ` [v3,1/2] " Peter Chen
2019-01-21 18:00 ` [PATCH v3 1/2] " Philipp Puschmann
2019-01-21 18:00 ` [v3,1/2] " Philipp Puschmann
2019-01-22 7:50 ` Peter Chen [this message]
2019-01-22 7:50 ` Peter Chen
2019-01-16 16:32 ` [PATCH v2,2/2] usb: chipidea: imx: set power polarity Sergei Shtylyov
2019-01-16 16:32 ` [v2,2/2] " Sergei Shtylyov
2019-01-21 17:57 ` [PATCH v2,2/2] " Philipp Puschmann
2019-01-21 17:57 ` [v2,2/2] " Philipp Puschmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB5314CEFFC0FEB91184FD872D8B980@AM0PR04MB5314.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=philipp.puschmann@emlix.com \
--cc=pp@emlix.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.