All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
@ 2016-01-06  5:00 Prabhakar Kushwaha
  2016-01-14 18:06 ` york sun
  2016-02-01 22:02 ` york sun
  0 siblings, 2 replies; 7+ messages in thread
From: Prabhakar Kushwaha @ 2016-01-06  5:00 UTC (permalink / raw)
  To: u-boot

kernel_size env variable is defined as 0x28000000, it is beyond NOR
flash.

Update kernel_size with 40MB kernel size.

Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 include/configs/ls2080aqds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h
index ba84248..a402c06 100644
--- a/include/configs/ls2080aqds.h
+++ b/include/configs/ls2080aqds.h
@@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
 	"initrd_high=0xffffffffffffffff\0"	\
 	"kernel_start=0x581100000\0"		\
 	"kernel_load=0xa0000000\0"		\
-	"kernel_size=0x28000000\0"
+	"kernel_size=0x2800000\0"
 
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-06  5:00 [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable Prabhakar Kushwaha
@ 2016-01-14 18:06 ` york sun
  2016-01-15  4:53   ` Prabhakar Kushwaha
  2016-01-21 22:48   ` Scott Wood
  2016-02-01 22:02 ` york sun
  1 sibling, 2 replies; 7+ messages in thread
From: york sun @ 2016-01-14 18:06 UTC (permalink / raw)
  To: u-boot

On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
> kernel_size env variable is defined as 0x28000000, it is beyond NOR
> flash.
> 
> Update kernel_size with 40MB kernel size.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
>  include/configs/ls2080aqds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h
> index ba84248..a402c06 100644
> --- a/include/configs/ls2080aqds.h
> +++ b/include/configs/ls2080aqds.h
> @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
>  	"initrd_high=0xffffffffffffffff\0"	\
>  	"kernel_start=0x581100000\0"		\
>  	"kernel_load=0xa0000000\0"		\
> -	"kernel_size=0x28000000\0"
> +	"kernel_size=0x2800000\0"
>  
>  #ifdef CONFIG_FSL_MC_ENET
>  #define CONFIG_FSL_MEMAC
> 
Prabhakar,

I am tired of these changes. Can you go over all the default settings and verify
they all make sense? A short while ago Scott found fdt_high was not correct.

York

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-14 18:06 ` york sun
@ 2016-01-15  4:53   ` Prabhakar Kushwaha
  2016-01-27 17:39     ` york sun
  2016-01-21 22:48   ` Scott Wood
  1 sibling, 1 reply; 7+ messages in thread
From: Prabhakar Kushwaha @ 2016-01-15  4:53 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: york sun [mailto:york.sun at nxp.com]
> Sent: Thursday, January 14, 2016 11:37 PM
> To: Prabhakar Kushwaha <prabhakar@freescale.com>; u-boot at lists.denx.de
> Cc: Scott Wood <oss@buserror.net>
> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable
> 
> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
> > kernel_size env variable is defined as 0x28000000, it is beyond NOR
> > flash.
> >
> > Update kernel_size with 40MB kernel size.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> >  include/configs/ls2080aqds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/ls2080aqds.h
> > b/include/configs/ls2080aqds.h index ba84248..a402c06 100644
> > --- a/include/configs/ls2080aqds.h
> > +++ b/include/configs/ls2080aqds.h
> > @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
> >  	"initrd_high=0xffffffffffffffff\0"	\
> >  	"kernel_start=0x581100000\0"		\
> >  	"kernel_load=0xa0000000\0"		\
> > -	"kernel_size=0x28000000\0"
> > +	"kernel_size=0x2800000\0"
> >
> >  #ifdef CONFIG_FSL_MC_ENET
> >  #define CONFIG_FSL_MEMAC
> >
> Prabhakar,
> 
> I am tired of these changes. Can you go over all the default settings and
> verify they all make sense? 

I agree.

Let me review all settings and provide one patch to fix all of them at once.
Do you want to hold this patch till I check and provide patch (if required)

>A short while ago Scott found fdt_high was not  correct.

Is this change part of code or not?

--prabhakar

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-14 18:06 ` york sun
  2016-01-15  4:53   ` Prabhakar Kushwaha
@ 2016-01-21 22:48   ` Scott Wood
  1 sibling, 0 replies; 7+ messages in thread
From: Scott Wood @ 2016-01-21 22:48 UTC (permalink / raw)
  To: u-boot

On Thu, 2016-01-14 at 18:06 +0000, york sun wrote:
> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
> > kernel_size env variable is defined as 0x28000000, it is beyond NOR
> > flash.
> > 
> > Update kernel_size with 40MB kernel size.
> > 
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> >  include/configs/ls2080aqds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h
> > index ba84248..a402c06 100644
> > --- a/include/configs/ls2080aqds.h
> > +++ b/include/configs/ls2080aqds.h
> > @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
> >  	"initrd_high=0xffffffffffffffff\0"	\
> >  	"kernel_start=0x581100000\0"		\
> >  	"kernel_load=0xa0000000\0"		\
> > -	"kernel_size=0x28000000\0"
> > +	"kernel_size=0x2800000\0"
> >  
> >  #ifdef CONFIG_FSL_MC_ENET
> >  #define CONFIG_FSL_MEMAC
> > 
> Prabhakar,
> 
> I am tired of these changes. Can you go over all the default settings and
> verify
> they all make sense? A short while ago Scott found fdt_high was not correct.

That was ls1021a.

-Scott

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-15  4:53   ` Prabhakar Kushwaha
@ 2016-01-27 17:39     ` york sun
  2016-01-28  6:36       ` Prabhakar Kushwaha
  0 siblings, 1 reply; 7+ messages in thread
From: york sun @ 2016-01-27 17:39 UTC (permalink / raw)
  To: u-boot

On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote:
> 
>> -----Original Message-----
>> From: york sun [mailto:york.sun at nxp.com]
>> Sent: Thursday, January 14, 2016 11:37 PM
>> To: Prabhakar Kushwaha <prabhakar@freescale.com>; u-boot at lists.denx.de
>> Cc: Scott Wood <oss@buserror.net>
>> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable
>>
>> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
>>> kernel_size env variable is defined as 0x28000000, it is beyond NOR
>>> flash.
>>>
>>> Update kernel_size with 40MB kernel size.
>>>
>>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>>> ---
>>>  include/configs/ls2080aqds.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/configs/ls2080aqds.h
>>> b/include/configs/ls2080aqds.h index ba84248..a402c06 100644
>>> --- a/include/configs/ls2080aqds.h
>>> +++ b/include/configs/ls2080aqds.h
>>> @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
>>>  	"initrd_high=0xffffffffffffffff\0"	\
>>>  	"kernel_start=0x581100000\0"		\
>>>  	"kernel_load=0xa0000000\0"		\
>>> -	"kernel_size=0x28000000\0"
>>> +	"kernel_size=0x2800000\0"
>>>
>>>  #ifdef CONFIG_FSL_MC_ENET
>>>  #define CONFIG_FSL_MEMAC
>>>
>> Prabhakar,
>>
>> I am tired of these changes. Can you go over all the default settings and
>> verify they all make sense? 
> 
> I agree.
> 
> Let me review all settings and provide one patch to fix all of them at once.
> Do you want to hold this patch till I check and provide patch (if required)
> 
>> A short while ago Scott found fdt_high was not  correct.
> 
> Is this change part of code or not?
> 

Prabhakar,

Do you have update on this patch?

York

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-27 17:39     ` york sun
@ 2016-01-28  6:36       ` Prabhakar Kushwaha
  0 siblings, 0 replies; 7+ messages in thread
From: Prabhakar Kushwaha @ 2016-01-28  6:36 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: york sun
> Sent: Wednesday, January 27, 2016 11:09 PM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; u-
> boot at lists.denx.de
> Cc: Scott Wood <oss@buserror.net>
> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable
> 
> On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote:
> >
> >> -----Original Message-----
> >> From: york sun [mailto:york.sun at nxp.com]
> >> Sent: Thursday, January 14, 2016 11:37 PM
> >> To: Prabhakar Kushwaha <prabhakar@freescale.com>;
> >> u-boot at lists.denx.de
> >> Cc: Scott Wood <oss@buserror.net>
> >> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env
> >> variable
> >>
> >> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
> >>> kernel_size env variable is defined as 0x28000000, it is beyond NOR
> >>> flash.
> >>>
> >>> Update kernel_size with 40MB kernel size.
> >>>
> >>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> >>> ---
> >>>  include/configs/ls2080aqds.h | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/configs/ls2080aqds.h
> >>> b/include/configs/ls2080aqds.h index ba84248..a402c06 100644
> >>> --- a/include/configs/ls2080aqds.h
> >>> +++ b/include/configs/ls2080aqds.h
> >>> @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void);
> >>>  	"initrd_high=0xffffffffffffffff\0"	\
> >>>  	"kernel_start=0x581100000\0"		\
> >>>  	"kernel_load=0xa0000000\0"		\
> >>> -	"kernel_size=0x28000000\0"
> >>> +	"kernel_size=0x2800000\0"
> >>>
> >>>  #ifdef CONFIG_FSL_MC_ENET
> >>>  #define CONFIG_FSL_MEMAC
> >>>
> >> Prabhakar,
> >>
> >> I am tired of these changes. Can you go over all the default settings
> >> and verify they all make sense?
> >
> > I agree.
> >
> > Let me review all settings and provide one patch to fix all of them at once.
> > Do you want to hold this patch till I check and provide patch (if
> > required)
> >
> >> A short while ago Scott found fdt_high was not  correct.
> >
> > Is this change part of code or not?
> >
> 
> Prabhakar,
> 
> Do you have update on this patch?
> 

I compared both QDS and RDB configuration files. They will be equal after merger of this patch. 

No patch update is required. 

--prabhakar

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable
  2016-01-06  5:00 [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable Prabhakar Kushwaha
  2016-01-14 18:06 ` york sun
@ 2016-02-01 22:02 ` york sun
  1 sibling, 0 replies; 7+ messages in thread
From: york sun @ 2016-02-01 22:02 UTC (permalink / raw)
  To: u-boot

On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote:
> kernel_size env variable is defined as 0x28000000, it is beyond NOR
> flash.
> 
> Update kernel_size with 40MB kernel size.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---

Applied to u-boot-fsl-qoriq master branch. Awaiting upstream.

Thanks.

York

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-02-01 22:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-06  5:00 [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable Prabhakar Kushwaha
2016-01-14 18:06 ` york sun
2016-01-15  4:53   ` Prabhakar Kushwaha
2016-01-27 17:39     ` york sun
2016-01-28  6:36       ` Prabhakar Kushwaha
2016-01-21 22:48   ` Scott Wood
2016-02-01 22:02 ` york sun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.