All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacky Bai <ping.bai@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"maxime.ripard@free-electrons.com"
	<maxime.ripard@free-electrons.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/3] devicetree: bindings: nvmem: Add compatible string for imx6ul
Date: Tue, 15 Nov 2016 07:25:01 +0000	[thread overview]
Message-ID: <AM3PR04MB53067E1D93D062C8357920587BF0@AM3PR04MB530.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop>

> > Add new compatible string for i.MX6UL SOC.
> >
> > Signed-off-by: Bai Ping <ping.bai@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > index 383d588..a7ff65d 100644
> > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > @@ -1,13 +1,14 @@
> >  Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings
> >
> >  This binding represents the on-chip eFuse OTP controller found on
> > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs.
> > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs.
> >
> >  Required properties:
> >  - compatible: should be one of
> >  	"fsl,imx6q-ocotp" (i.MX6Q/D/DL/S),
> > -	"fsl,imx6sl-ocotp" (i.MX6SL), or
> > -	"fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon".
> > +	"fsl,imx6sl-ocotp" (i.MX6SL),
> > +	"fsl,imx6sx-ocotp" (i.MX6SX), or
> > +	"fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon".
> 
> This should be reformatted such that it's not a 5 line change to add a
> compatible. "one of" defines this is an OR relationship, so drop that.
> Move 'followed by "syscon"' to below the list of compatibles.
> 

Thanks for review, I will adopt in V2.

Jacky Bai
> >  - reg: Should contain the register base and length.
> >  - clocks: Should contain a phandle pointing to the gated peripheral clock.
> >
> > --
> > 2.8.2
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: ping.bai@nxp.com (Jacky Bai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] devicetree: bindings: nvmem: Add compatible string for imx6ul
Date: Tue, 15 Nov 2016 07:25:01 +0000	[thread overview]
Message-ID: <AM3PR04MB53067E1D93D062C8357920587BF0@AM3PR04MB530.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop>

> > Add new compatible string for i.MX6UL SOC.
> >
> > Signed-off-by: Bai Ping <ping.bai@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > index 383d588..a7ff65d 100644
> > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> > @@ -1,13 +1,14 @@
> >  Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings
> >
> >  This binding represents the on-chip eFuse OTP controller found on
> > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs.
> > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs.
> >
> >  Required properties:
> >  - compatible: should be one of
> >  	"fsl,imx6q-ocotp" (i.MX6Q/D/DL/S),
> > -	"fsl,imx6sl-ocotp" (i.MX6SL), or
> > -	"fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon".
> > +	"fsl,imx6sl-ocotp" (i.MX6SL),
> > +	"fsl,imx6sx-ocotp" (i.MX6SX), or
> > +	"fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon".
> 
> This should be reformatted such that it's not a 5 line change to add a
> compatible. "one of" defines this is an OR relationship, so drop that.
> Move 'followed by "syscon"' to below the list of compatibles.
> 

Thanks for review, I will adopt in V2.

Jacky Bai
> >  - reg: Should contain the register base and length.
> >  - clocks: Should contain a phandle pointing to the gated peripheral clock.
> >
> > --
> > 2.8.2
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-11-15  7:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  5:41 [PATCH 1/3] driver: nvmem: Add ocotp driver support for imx6ul Bai Ping
2016-11-07  5:41 ` Bai Ping
2016-11-07  5:41 ` [PATCH 2/3] devicetree: bindings: nvmem: Add compatible string " Bai Ping
2016-11-07  5:41   ` Bai Ping
     [not found]   ` <1478497281-5477-2-git-send-email-ping.bai-3arQi8VN3Tc@public.gmane.org>
2016-11-14 16:14     ` Rob Herring
2016-11-14 16:14       ` Rob Herring
2016-11-15  7:25       ` Jacky Bai [this message]
2016-11-15  7:25         ` Jacky Bai
2016-11-07  5:41 ` [PATCH 3/3] ARM: dts: imx: Add ocotp node " Bai Ping
2016-11-07  5:41   ` Bai Ping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR04MB53067E1D93D062C8357920587BF0@AM3PR04MB530.eurprd04.prod.outlook.com \
    --to=ping.bai@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.