* [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-23 12:45 vadimp
2016-10-23 14:51 ` Darren Hart
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: vadimp @ 2016-10-23 12:45 UTC (permalink / raw)
To: dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko, Vadim Pasternak
From: Vadim Pasternak <vadimp@mellanox.com>
Add select HWMON for mlxcpld-hotplug driver config, since it requires
hwmon APIs.
Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 65d9b04..1853769 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
tristate "Mellanox platform hotplug driver support"
default n
depends on MLX_PLATFORM
+ select HWMON
select I2C
---help---
This driver handles hot-plug events for the power suppliers, power
--
2.1.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
@ 2016-10-23 14:51 ` Darren Hart
2016-10-24 5:33 ` Vadim Pasternak
2016-10-23 16:57 ` Randy Dunlap
2016-10-24 8:58 ` Andy Shevchenko
2 siblings, 1 reply; 14+ messages in thread
From: Darren Hart @ 2016-10-23 14:51 UTC (permalink / raw)
To: vadimp
Cc: fengguang.wu, davem, geert, akpm, kvalo, gregkh, mchehab, linux,
linux-kernel, platform-driver-x86, jiri, andriy.shevchenko
On Sun, Oct 23, 2016 at 12:45:27PM +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
>
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
Is this in response to the 0-day Error report?
>
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> tristate "Mellanox platform hotplug driver support"
> default n
> depends on MLX_PLATFORM
> + select HWMON
> select I2C
> ---help---
> This driver handles hot-plug events for the power suppliers, power
> --
> 2.1.4
>
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
2016-10-23 14:51 ` Darren Hart
@ 2016-10-23 16:57 ` Randy Dunlap
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 8:58 ` Andy Shevchenko
2 siblings, 2 replies; 14+ messages in thread
From: Randy Dunlap @ 2016-10-23 16:57 UTC (permalink / raw)
To: vadimp, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
On 10/23/16 05:45, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
>
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
>
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> tristate "Mellanox platform hotplug driver support"
> default n
> depends on MLX_PLATFORM
> + select HWMON
> select I2C
> ---help---
> This driver handles hot-plug events for the power suppliers, power
>
Hi,
did you test this? I would expect it to cause a kconfig warning,
something about HWMON having a dependency on HAS_IOMEM.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 14:51 ` Darren Hart
@ 2016-10-24 5:33 ` Vadim Pasternak
0 siblings, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 5:33 UTC (permalink / raw)
To: Darren Hart
Cc: fengguang.wu, davem, geert, akpm, kvalo, gregkh, mchehab, linux,
linux-kernel, platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Sunday, October 23, 2016 5:52 PM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: fengguang.wu@intel.com; davem@davemloft.net; geert@linux-m68k.org;
> akpm@linux-foundation.org; kvalo@codeaurora.org;
> gregkh@linuxfoundation.org; mchehab@kernel.org; linux@roeck-us.net; linux-
> kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On Sun, Oct 23, 2016 at 12:45:27PM +0000, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
>
> Is this in response to the 0-day Error report?
Yes.
>
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> > --
> > 2.1.4
> >
> >
>
> --
> Darren Hart
> Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-24 5:33 ` Vadim Pasternak
0 siblings, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 5:33 UTC (permalink / raw)
To: Darren Hart
Cc: fengguang.wu, davem, geert, akpm, kvalo, gregkh, mchehab, linux,
linux-kernel, platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Sunday, October 23, 2016 5:52 PM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: fengguang.wu@intel.com; davem@davemloft.net; geert@linux-m68k.org;
> akpm@linux-foundation.org; kvalo@codeaurora.org;
> gregkh@linuxfoundation.org; mchehab@kernel.org; linux@roeck-us.net; linux-
> kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On Sun, Oct 23, 2016 at 12:45:27PM +0000, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
>
> Is this in response to the 0-day Error report?
Yes.
>
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> > --
> > 2.1.4
> >
> >
>
> --
> Darren Hart
> Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 16:57 ` Randy Dunlap
@ 2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 6:01 ` Vadim Pasternak
1 sibling, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 5:41 UTC (permalink / raw)
To: Randy Dunlap, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> >
>
> Hi,
> did you test this? I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.
Hi Randy,
Yes,
I built tree with this fix with the attached .config file.
Didn't see kconfig warnings.
I can have a look again.
Thanks,
Vadim.
>
> thanks.
> --
> ~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-24 5:41 ` Vadim Pasternak
0 siblings, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 5:41 UTC (permalink / raw)
To: Randy Dunlap, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> >
>
> Hi,
> did you test this? I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.
Hi Randy,
Yes,
I built tree with this fix with the attached .config file.
Didn't see kconfig warnings.
I can have a look again.
Thanks,
Vadim.
>
> thanks.
> --
> ~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 16:57 ` Randy Dunlap
@ 2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 6:01 ` Vadim Pasternak
1 sibling, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 6:01 UTC (permalink / raw)
To: Randy Dunlap, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> >
>
> Hi,
> did you test this? I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.
I re-tested it again.
I don't see any warning from kconfig. It just set " CONFIG_HWMON=m" with no warnings.
Could I miss something?
Thanks,
Vadim.
>
> thanks.
> --
> ~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-24 6:01 ` Vadim Pasternak
0 siblings, 0 replies; 14+ messages in thread
From: Vadim Pasternak @ 2016-10-24 6:01 UTC (permalink / raw)
To: Randy Dunlap, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> >
>
> Hi,
> did you test this? I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.
I re-tested it again.
I don't see any warning from kconfig. It just set " CONFIG_HWMON=m" with no warnings.
Could I miss something?
Thanks,
Vadim.
>
> thanks.
> --
> ~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
2016-10-23 14:51 ` Darren Hart
2016-10-23 16:57 ` Randy Dunlap
@ 2016-10-24 8:58 ` Andy Shevchenko
2 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2016-10-24 8:58 UTC (permalink / raw)
To: vadimp, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri
On Sun, 2016-10-23 at 12:45 +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
>
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
>
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> tristate "Mellanox platform hotplug driver support"
> default n
Btw, I thought the _default_ is 'n' and thus this line is not needed.
> depends on MLX_PLATFORM
> + select HWMON
> select I2C
> ---help---
> This driver handles hot-plug events for the power
> suppliers, power
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-24 5:41 ` Vadim Pasternak
@ 2016-10-24 17:11 ` Randy Dunlap
-1 siblings, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2016-10-24 17:11 UTC (permalink / raw)
To: Vadim Pasternak, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
On 10/23/16 22:41, Vadim Pasternak wrote:
>
>
>> -----Original Message-----
>> From: Randy Dunlap [mailto:rdunlap@infradead.org]
>> Sent: Sunday, October 23, 2016 7:57 PM
>> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
>> fengguang.wu@intel.com
>> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
>> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
>> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
>> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
>> andriy.shevchenko@linux.intel.com
>> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
>> hotplug driver in Kconfig
>>
>> On 10/23/16 05:45, vadimp@mellanox.com wrote:
>>> From: Vadim Pasternak <vadimp@mellanox.com>
>>>
>>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
>>> hwmon APIs.
>>>
>>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
>>> ---
>>> drivers/platform/x86/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig
>>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>>> tristate "Mellanox platform hotplug driver support"
>>> default n
>>> depends on MLX_PLATFORM
>>> + select HWMON
>>> select I2C
>>> ---help---
>>> This driver handles hot-plug events for the power suppliers, power
>>>
>>
>> Hi,
>> did you test this? I would expect it to cause a kconfig warning, something about
>> HWMON having a dependency on HAS_IOMEM.
>
> Hi Randy,
>
> Yes,
> I built tree with this fix with the attached .config file.
> Didn't see kconfig warnings.
> I can have a look again.
No need. lib/Kconfig handles it:
config HAS_IOMEM
bool
depends on !NO_IOMEM
select GENERIC_IO
default y
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-24 17:11 ` Randy Dunlap
0 siblings, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2016-10-24 17:11 UTC (permalink / raw)
To: Vadim Pasternak, dvhart, fengguang.wu
Cc: davem, geert, akpm, kvalo, gregkh, mchehab, linux, linux-kernel,
platform-driver-x86, jiri, andriy.shevchenko
On 10/23/16 22:41, Vadim Pasternak wrote:
>
>
>> -----Original Message-----
>> From: Randy Dunlap [mailto:rdunlap@infradead.org]
>> Sent: Sunday, October 23, 2016 7:57 PM
>> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
>> fengguang.wu@intel.com
>> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
>> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
>> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
>> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
>> andriy.shevchenko@linux.intel.com
>> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
>> hotplug driver in Kconfig
>>
>> On 10/23/16 05:45, vadimp@mellanox.com wrote:
>>> From: Vadim Pasternak <vadimp@mellanox.com>
>>>
>>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
>>> hwmon APIs.
>>>
>>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
>>> ---
>>> drivers/platform/x86/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig
>>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>>> tristate "Mellanox platform hotplug driver support"
>>> default n
>>> depends on MLX_PLATFORM
>>> + select HWMON
>>> select I2C
>>> ---help---
>>> This driver handles hot-plug events for the power suppliers, power
>>>
>>
>> Hi,
>> did you test this? I would expect it to cause a kconfig warning, something about
>> HWMON having a dependency on HAS_IOMEM.
>
> Hi Randy,
>
> Yes,
> I built tree with this fix with the attached .config file.
> Didn't see kconfig warnings.
> I can have a look again.
No need. lib/Kconfig handles it:
config HAS_IOMEM
bool
depends on !NO_IOMEM
select GENERIC_IO
default y
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
2016-10-24 17:11 ` Randy Dunlap
@ 2016-10-24 18:10 ` Darren Hart
-1 siblings, 0 replies; 14+ messages in thread
From: Darren Hart @ 2016-10-24 18:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: Vadim Pasternak, fengguang.wu, davem, geert, akpm, kvalo, gregkh,
mchehab, linux, linux-kernel, platform-driver-x86, jiri,
andriy.shevchenko
On Mon, Oct 24, 2016 at 10:11:27AM -0700, Randy Dunlap wrote:
> On 10/23/16 22:41, Vadim Pasternak wrote:
> >
> >
> >> -----Original Message-----
> >> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> >> Sent: Sunday, October 23, 2016 7:57 PM
> >> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> >> fengguang.wu@intel.com
> >> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> >> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> >> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> >> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> >> andriy.shevchenko@linux.intel.com
> >> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> >> hotplug driver in Kconfig
> >>
> >> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> >>> From: Vadim Pasternak <vadimp@mellanox.com>
> >>>
> >>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> >>> hwmon APIs.
> >>>
> >>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> >>> ---
> >>> drivers/platform/x86/Kconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/platform/x86/Kconfig
> >>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> >>> --- a/drivers/platform/x86/Kconfig
> >>> +++ b/drivers/platform/x86/Kconfig
> >>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >>> tristate "Mellanox platform hotplug driver support"
> >>> default n
> >>> depends on MLX_PLATFORM
> >>> + select HWMON
> >>> select I2C
> >>> ---help---
> >>> This driver handles hot-plug events for the power suppliers, power
> >>>
> >>
> >> Hi,
> >> did you test this? I would expect it to cause a kconfig warning, something about
> >> HWMON having a dependency on HAS_IOMEM.
> >
> > Hi Randy,
> >
> > Yes,
> > I built tree with this fix with the attached .config file.
> > Didn't see kconfig warnings.
> > I can have a look again.
>
> No need. lib/Kconfig handles it:
>
> config HAS_IOMEM
> bool
> depends on !NO_IOMEM
> select GENERIC_IO
> default y
>
>
> thanks.
> --
> ~Randy
>
Thanks for the review all. I've merged this with the original commit, now in
next.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
@ 2016-10-24 18:10 ` Darren Hart
0 siblings, 0 replies; 14+ messages in thread
From: Darren Hart @ 2016-10-24 18:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: Vadim Pasternak, fengguang.wu, davem, geert, akpm, kvalo, gregkh,
mchehab, linux, linux-kernel, platform-driver-x86, jiri,
andriy.shevchenko
On Mon, Oct 24, 2016 at 10:11:27AM -0700, Randy Dunlap wrote:
> On 10/23/16 22:41, Vadim Pasternak wrote:
> >
> >
> >> -----Original Message-----
> >> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> >> Sent: Sunday, October 23, 2016 7:57 PM
> >> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> >> fengguang.wu@intel.com
> >> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> >> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> >> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> >> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> >> andriy.shevchenko@linux.intel.com
> >> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> >> hotplug driver in Kconfig
> >>
> >> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> >>> From: Vadim Pasternak <vadimp@mellanox.com>
> >>>
> >>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> >>> hwmon APIs.
> >>>
> >>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> >>> ---
> >>> drivers/platform/x86/Kconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/platform/x86/Kconfig
> >>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> >>> --- a/drivers/platform/x86/Kconfig
> >>> +++ b/drivers/platform/x86/Kconfig
> >>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >>> tristate "Mellanox platform hotplug driver support"
> >>> default n
> >>> depends on MLX_PLATFORM
> >>> + select HWMON
> >>> select I2C
> >>> ---help---
> >>> This driver handles hot-plug events for the power suppliers, power
> >>>
> >>
> >> Hi,
> >> did you test this? I would expect it to cause a kconfig warning, something about
> >> HWMON having a dependency on HAS_IOMEM.
> >
> > Hi Randy,
> >
> > Yes,
> > I built tree with this fix with the attached .config file.
> > Didn't see kconfig warnings.
> > I can have a look again.
>
> No need. lib/Kconfig handles it:
>
> config HAS_IOMEM
> bool
> depends on !NO_IOMEM
> select GENERIC_IO
> default y
>
>
> thanks.
> --
> ~Randy
>
Thanks for the review all. I've merged this with the original commit, now in
next.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-10-24 18:10 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
2016-10-23 14:51 ` Darren Hart
2016-10-24 5:33 ` Vadim Pasternak
2016-10-24 5:33 ` Vadim Pasternak
2016-10-23 16:57 ` Randy Dunlap
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 17:11 ` Randy Dunlap
2016-10-24 17:11 ` Randy Dunlap
2016-10-24 18:10 ` Darren Hart
2016-10-24 18:10 ` Darren Hart
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 8:58 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.