From: Aisheng Dong <aisheng.dong@nxp.com> To: Peng Fan <peng.fan@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, "sboyd@kernel.org" <sboyd@kernel.org>, Abel Vesa <abel.vesa@nxp.com> Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Anson Huang <anson.huang@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>, "aford173@gmail.com" <aford173@gmail.com>, Jacky Bai <ping.bai@nxp.com>, Jun Li <jun.li@nxp.com>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, "agx@sigxcpu.org" <agx@sigxcpu.org>, "angus@akkea.ca" <angus@akkea.ca>, "heiko@sntech.de" <heiko@sntech.de>, Andy Duan <fugang.duan@nxp.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org> Subject: RE: [PATCH V2 02/10] clk: imx8m: drop clk_hw_set_parent for A53 Date: Sun, 26 Apr 2020 03:54:32 +0000 [thread overview] Message-ID: <AM6PR04MB49667AF484D4609B5B5436B080AE0@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1584008384-11578-3-git-send-email-peng.fan@nxp.com> > From: Peng Fan <peng.fan@nxp.com> > Sent: Thursday, March 12, 2020 6:20 PM > > The parent settings have been moved to dtsi, we no need to set parent here. And > clk_hw_set_parent will trigger lockdep warning, because this api not have > prepare_lock. > > Reported-by: Leonard Crestez <leonard.crestez@nxp.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> For the patch: Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> BTW, What kind of lockdep warning? Do you mean it's generic issue that we can't use clk_hw_set_parent in clock driver? Regards Aisheng > --- > drivers/clk/imx/clk-imx8mm.c | 3 --- > drivers/clk/imx/clk-imx8mn.c | 3 --- > drivers/clk/imx/clk-imx8mp.c | 3 --- > drivers/clk/imx/clk-imx8mq.c | 3 --- > 4 files changed, 12 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c index > 925670438f23..5435042a06e3 100644 > --- a/drivers/clk/imx/clk-imx8mm.c > +++ b/drivers/clk/imx/clk-imx8mm.c > @@ -614,9 +614,6 @@ static int imx8mm_clocks_probe(struct > platform_device *pdev) > hws[IMX8MM_ARM_PLL_OUT]->clk, > hws[IMX8MM_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MM_CLK_A53_SRC], > hws[IMX8MM_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MM_CLK_A53_CORE], > hws[IMX8MM_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MM_CLK_END); > > ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index > 0bc7070235bd..6cac6ca03e12 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -565,9 +565,6 @@ static int imx8mn_clocks_probe(struct platform_device > *pdev) > hws[IMX8MN_ARM_PLL_OUT]->clk, > hws[IMX8MN_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MN_CLK_A53_SRC], > hws[IMX8MN_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MN_CLK_A53_CORE], > hws[IMX8MN_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MN_CLK_END); > > ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index > 41469e2cc3de..e05ec56df285 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -735,9 +735,6 @@ static int imx8mp_clocks_probe(struct platform_device > *pdev) > hws[IMX8MP_ARM_PLL_OUT]->clk, > hws[IMX8MP_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MP_CLK_A53_SRC], > hws[IMX8MP_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MP_CLK_A53_CORE], > hws[IMX8MP_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MP_CLK_END); > > of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); diff > --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c index > fdc68db68de5..201c7bbb201f 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -599,9 +599,6 @@ static int imx8mq_clocks_probe(struct platform_device > *pdev) > hws[IMX8MQ_ARM_PLL_OUT]->clk, > hws[IMX8MQ_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MQ_CLK_A53_SRC], > hws[IMX8MQ_SYS1_PLL_800M]); > - clk_hw_set_parent(hws[IMX8MQ_CLK_A53_CORE], > hws[IMX8MQ_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MQ_CLK_END); > > err = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > -- > 2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com> To: Peng Fan <peng.fan@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, "sboyd@kernel.org" <sboyd@kernel.org>, Abel Vesa <abel.vesa@nxp.com> Cc: Andy Duan <fugang.duan@nxp.com>, Jacky Bai <ping.bai@nxp.com>, Anson Huang <anson.huang@nxp.com>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, Daniel Baluta <daniel.baluta@nxp.com>, "agx@sigxcpu.org" <agx@sigxcpu.org>, "angus@akkea.ca" <angus@akkea.ca>, "heiko@sntech.de" <heiko@sntech.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "aford173@gmail.com" <aford173@gmail.com>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com> Subject: RE: [PATCH V2 02/10] clk: imx8m: drop clk_hw_set_parent for A53 Date: Sun, 26 Apr 2020 03:54:32 +0000 [thread overview] Message-ID: <AM6PR04MB49667AF484D4609B5B5436B080AE0@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1584008384-11578-3-git-send-email-peng.fan@nxp.com> > From: Peng Fan <peng.fan@nxp.com> > Sent: Thursday, March 12, 2020 6:20 PM > > The parent settings have been moved to dtsi, we no need to set parent here. And > clk_hw_set_parent will trigger lockdep warning, because this api not have > prepare_lock. > > Reported-by: Leonard Crestez <leonard.crestez@nxp.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> For the patch: Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> BTW, What kind of lockdep warning? Do you mean it's generic issue that we can't use clk_hw_set_parent in clock driver? Regards Aisheng > --- > drivers/clk/imx/clk-imx8mm.c | 3 --- > drivers/clk/imx/clk-imx8mn.c | 3 --- > drivers/clk/imx/clk-imx8mp.c | 3 --- > drivers/clk/imx/clk-imx8mq.c | 3 --- > 4 files changed, 12 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c index > 925670438f23..5435042a06e3 100644 > --- a/drivers/clk/imx/clk-imx8mm.c > +++ b/drivers/clk/imx/clk-imx8mm.c > @@ -614,9 +614,6 @@ static int imx8mm_clocks_probe(struct > platform_device *pdev) > hws[IMX8MM_ARM_PLL_OUT]->clk, > hws[IMX8MM_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MM_CLK_A53_SRC], > hws[IMX8MM_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MM_CLK_A53_CORE], > hws[IMX8MM_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MM_CLK_END); > > ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index > 0bc7070235bd..6cac6ca03e12 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -565,9 +565,6 @@ static int imx8mn_clocks_probe(struct platform_device > *pdev) > hws[IMX8MN_ARM_PLL_OUT]->clk, > hws[IMX8MN_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MN_CLK_A53_SRC], > hws[IMX8MN_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MN_CLK_A53_CORE], > hws[IMX8MN_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MN_CLK_END); > > ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index > 41469e2cc3de..e05ec56df285 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -735,9 +735,6 @@ static int imx8mp_clocks_probe(struct platform_device > *pdev) > hws[IMX8MP_ARM_PLL_OUT]->clk, > hws[IMX8MP_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MP_CLK_A53_SRC], > hws[IMX8MP_SYS_PLL1_800M]); > - clk_hw_set_parent(hws[IMX8MP_CLK_A53_CORE], > hws[IMX8MP_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MP_CLK_END); > > of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); diff > --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c index > fdc68db68de5..201c7bbb201f 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -599,9 +599,6 @@ static int imx8mq_clocks_probe(struct platform_device > *pdev) > hws[IMX8MQ_ARM_PLL_OUT]->clk, > hws[IMX8MQ_CLK_A53_DIV]->clk); > > - clk_hw_set_parent(hws[IMX8MQ_CLK_A53_SRC], > hws[IMX8MQ_SYS1_PLL_800M]); > - clk_hw_set_parent(hws[IMX8MQ_CLK_A53_CORE], > hws[IMX8MQ_ARM_PLL_OUT]); > - > imx_check_clk_hws(hws, IMX8MQ_CLK_END); > > err = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > -- > 2.16.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-26 3:54 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-12 10:19 [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M peng.fan 2020-03-12 10:19 ` peng.fan 2020-03-12 10:19 ` [PATCH V2 01/10] arm64: dts: imx8m: assign clocks for A53 peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 3:51 ` Aisheng Dong 2020-04-26 3:51 ` Aisheng Dong 2020-03-12 10:19 ` [PATCH V2 02/10] clk: imx8m: drop clk_hw_set_parent " peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 3:54 ` Aisheng Dong [this message] 2020-04-26 3:54 ` Aisheng Dong 2020-03-12 10:19 ` [PATCH V2 03/10] clk: imx: imx8mp: fix pll mux bit peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 4:23 ` Aisheng Dong 2020-04-26 4:23 ` Aisheng Dong 2020-03-12 10:19 ` [PATCH V2 04/10] clk: imx8mp: Define gates for pll1/2 fixed dividers peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 4:29 ` Aisheng Dong 2020-04-26 4:29 ` Aisheng Dong 2020-03-12 10:19 ` [PATCH V2 05/10] clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 4:38 ` Aisheng Dong 2020-04-26 4:38 ` Aisheng Dong 2020-04-27 8:57 ` Peng Fan 2020-04-27 8:57 ` Peng Fan 2020-03-12 10:19 ` [PATCH V2 06/10] clk: imx8m: migrate A53 clk root to use composite core peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-26 4:43 ` Aisheng Dong 2020-04-26 4:43 ` Aisheng Dong 2020-04-27 8:58 ` Peng Fan 2020-04-27 8:58 ` Peng Fan 2020-03-12 10:19 ` [PATCH V2 07/10] clk: imx: add mux ops for i.MX8M composite clk peng.fan 2020-03-12 10:19 ` peng.fan 2020-04-24 19:29 ` Leonard Crestez 2020-04-24 19:29 ` Leonard Crestez 2020-04-27 9:15 ` Peng Fan 2020-04-27 9:15 ` Peng Fan 2020-04-27 19:34 ` Leonard Crestez 2020-04-27 19:34 ` Leonard Crestez 2020-04-28 1:08 ` Peng Fan 2020-04-28 1:08 ` Peng Fan 2020-04-26 5:08 ` Aisheng Dong 2020-04-26 5:08 ` Aisheng Dong 2020-04-27 9:11 ` Peng Fan 2020-04-27 9:11 ` Peng Fan 2020-04-30 10:00 ` Abel Vesa 2020-04-30 10:00 ` Abel Vesa 2020-04-30 12:56 ` Peng Fan 2020-04-30 12:56 ` Peng Fan 2020-03-12 10:19 ` [PATCH V2 08/10] clk: imx: add imx8m_clk_hw_composite_bus peng.fan 2020-03-12 10:19 ` peng.fan 2020-03-12 10:19 ` [PATCH V2 09/10] clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice peng.fan 2020-03-12 10:19 ` peng.fan 2020-03-12 10:19 ` [PATCH V2 10/10] clk: imx8mp: mark memrepair clock as critical peng.fan 2020-03-12 10:19 ` peng.fan 2020-03-19 10:04 ` [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M Peng Fan 2020-03-19 10:04 ` Peng Fan 2020-04-18 13:45 ` Peng Fan 2020-04-18 13:45 ` Peng Fan 2020-04-24 19:30 ` Leonard Crestez 2020-04-24 19:30 ` Leonard Crestez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM6PR04MB49667AF484D4609B5B5436B080AE0@AM6PR04MB4966.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=abel.vesa@nxp.com \ --cc=aford173@gmail.com \ --cc=agx@sigxcpu.org \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=anson.huang@nxp.com \ --cc=daniel.baluta@nxp.com \ --cc=festevam@gmail.com \ --cc=fugang.duan@nxp.com \ --cc=heiko@sntech.de \ --cc=jun.li@nxp.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=ping.bai@nxp.com \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.