* [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-18 5:09 ` Richard Zhu
0 siblings, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2021-02-18 5:09 UTC (permalink / raw)
To: l.stach, bhelgaas, stefan, lorenzo.pieralisi
Cc: linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel,
Richard Zhu
Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
i.MX6QP PCIe has the similar issue.
Define the length of the DBI registers and limit config space to its
length for i.MX6QP PCIe too.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/pci/controller/dwc/pci-imx6.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 0cf1333c0440..853ea8e82952 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
.variant = IMX6QP,
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
+ .dbi_length = 0x200,
},
[IMX7D] = {
.variant = IMX7D,
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-18 5:09 ` Richard Zhu
0 siblings, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2021-02-18 5:09 UTC (permalink / raw)
To: l.stach, bhelgaas, stefan, lorenzo.pieralisi
Cc: Richard Zhu, linux-pci, linux-kernel, linux-imx, kernel,
linux-arm-kernel
Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
i.MX6QP PCIe has the similar issue.
Define the length of the DBI registers and limit config space to its
length for i.MX6QP PCIe too.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/pci/controller/dwc/pci-imx6.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 0cf1333c0440..853ea8e82952 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
.variant = IMX6QP,
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
+ .dbi_length = 0x200,
},
[IMX7D] = {
.variant = IMX7D,
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
2021-02-18 5:09 ` Richard Zhu
@ 2021-02-18 8:59 ` Lucas Stach
-1 siblings, 0 replies; 10+ messages in thread
From: Lucas Stach @ 2021-02-18 8:59 UTC (permalink / raw)
To: Richard Zhu, bhelgaas, stefan, lorenzo.pieralisi
Cc: linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel
Am Donnerstag, dem 18.02.2021 um 13:09 +0800 schrieb Richard Zhu:
> Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> i.MX6QP PCIe has the similar issue.
> Define the length of the DBI registers and limit config space to its
> length for i.MX6QP PCIe too.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c0440..853ea8e82952 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> .variant = IMX6QP,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> + .dbi_length = 0x200,
> },
> [IMX7D] = {
> .variant = IMX7D,
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-18 8:59 ` Lucas Stach
0 siblings, 0 replies; 10+ messages in thread
From: Lucas Stach @ 2021-02-18 8:59 UTC (permalink / raw)
To: Richard Zhu, bhelgaas, stefan, lorenzo.pieralisi
Cc: kernel, linux-pci, linux-imx, linux-arm-kernel, linux-kernel
Am Donnerstag, dem 18.02.2021 um 13:09 +0800 schrieb Richard Zhu:
> Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> i.MX6QP PCIe has the similar issue.
> Define the length of the DBI registers and limit config space to its
> length for i.MX6QP PCIe too.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c0440..853ea8e82952 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> .variant = IMX6QP,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> + .dbi_length = 0x200,
> },
> [IMX7D] = {
> .variant = IMX7D,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
2021-02-18 5:09 ` Richard Zhu
@ 2021-02-18 11:55 ` Krzysztof Wilczyński
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-18 11:55 UTC (permalink / raw)
To: Richard Zhu
Cc: l.stach, helgaas, stefan, lorenzo.pieralisi, linux-pci,
linux-imx, linux-arm-kernel, linux-kernel, kernel
Hi Richard,
Thank you for sending the patch over!
> Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> i.MX6QP PCIe has the similar issue.
> Define the length of the DBI registers and limit config space to its
> length for i.MX6QP PCIe too.
You could probably flip these two sentences around to make the commit
message read slightly better, so what about this (a suggestion):
Define the length of the DBI registers and limit config space to its
length. This makes sure that the kernel does not access registers beyond
that point that otherwise would lead to an abort on a i.MX 6QuadPlus.
See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
resolves a similar issue on a i.MX 6Quad PCIe.
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c0440..853ea8e82952 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> .variant = IMX6QP,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> + .dbi_length = 0x200,
> },
> [IMX7D] = {
> .variant = IMX7D,
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-18 11:55 ` Krzysztof Wilczyński
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-18 11:55 UTC (permalink / raw)
To: Richard Zhu
Cc: lorenzo.pieralisi, linux-pci, linux-kernel, stefan, helgaas,
linux-imx, kernel, linux-arm-kernel, l.stach
Hi Richard,
Thank you for sending the patch over!
> Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> i.MX6QP PCIe has the similar issue.
> Define the length of the DBI registers and limit config space to its
> length for i.MX6QP PCIe too.
You could probably flip these two sentences around to make the commit
message read slightly better, so what about this (a suggestion):
Define the length of the DBI registers and limit config space to its
length. This makes sure that the kernel does not access registers beyond
that point that otherwise would lead to an abort on a i.MX 6QuadPlus.
See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
resolves a similar issue on a i.MX 6Quad PCIe.
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c0440..853ea8e82952 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> .variant = IMX6QP,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> + .dbi_length = 0x200,
> },
> [IMX7D] = {
> .variant = IMX7D,
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
2021-02-18 11:55 ` Krzysztof Wilczyński
@ 2021-02-18 17:34 ` Krzysztof Wilczyński
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-18 17:34 UTC (permalink / raw)
To: Richard Zhu
Cc: l.stach, helgaas, stefan, lorenzo.pieralisi, linux-pci,
linux-imx, linux-arm-kernel, linux-kernel, kernel
[...]
> > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> > i.MX6QP PCIe has the similar issue.
> > Define the length of the DBI registers and limit config space to its
> > length for i.MX6QP PCIe too.
>
> You could probably flip these two sentences around to make the commit
> message read slightly better, so what about this (a suggestion):
>
> Define the length of the DBI registers and limit config space to its
> length. This makes sure that the kernel does not access registers beyond
> that point that otherwise would lead to an abort on a i.MX 6QuadPlus.
>
> See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> resolves a similar issue on a i.MX 6Quad PCIe.
[...]
If you do decide to send another version, then also use "PCIe" in the
subject, rather than "pcie". I forgot to mention this in the previous
message, apologies.
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-18 17:34 ` Krzysztof Wilczyński
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-18 17:34 UTC (permalink / raw)
To: Richard Zhu
Cc: lorenzo.pieralisi, linux-pci, linux-kernel, stefan, helgaas,
linux-imx, kernel, linux-arm-kernel, l.stach
[...]
> > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> > i.MX6QP PCIe has the similar issue.
> > Define the length of the DBI registers and limit config space to its
> > length for i.MX6QP PCIe too.
>
> You could probably flip these two sentences around to make the commit
> message read slightly better, so what about this (a suggestion):
>
> Define the length of the DBI registers and limit config space to its
> length. This makes sure that the kernel does not access registers beyond
> that point that otherwise would lead to an abort on a i.MX 6QuadPlus.
>
> See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> resolves a similar issue on a i.MX 6Quad PCIe.
[...]
If you do decide to send another version, then also use "PCIe" in the
subject, rather than "pcie". I forgot to mention this in the previous
message, apologies.
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
2021-02-18 17:34 ` Krzysztof Wilczyński
@ 2021-02-20 1:27 ` Richard Zhu
-1 siblings, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2021-02-20 1:27 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: l.stach, helgaas, stefan, lorenzo.pieralisi, linux-pci,
dl-linux-imx, linux-arm-kernel, linux-kernel, kernel
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Friday, February 19, 2021 1:34 AM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; helgaas@kernel.org; stefan@agner.ch;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
> [...]
> > > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register
> > > length"), i.MX6QP PCIe has the similar issue.
> > > Define the length of the DBI registers and limit config space to its
> > > length for i.MX6QP PCIe too.
> >
> > You could probably flip these two sentences around to make the commit
> > message read slightly better, so what about this (a suggestion):
> >
> > Define the length of the DBI registers and limit config space to its
> > length. This makes sure that the kernel does not access registers
> > beyond that point that otherwise would lead to an abort on a i.MX
> 6QuadPlus.
> >
> > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> > resolves a similar issue on a i.MX 6Quad PCIe.
> [...]
>
> If you do decide to send another version, then also use "PCIe" in the subject,
> rather than "pcie". I forgot to mention this in the previous message,
> apologies.
>
[Richard Zhu] Never mind. Thanks a lot for your comments.
Would issue another version a moment later.
Best Regards
Richard Zhu
> Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
@ 2021-02-20 1:27 ` Richard Zhu
0 siblings, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2021-02-20 1:27 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: lorenzo.pieralisi, linux-pci, linux-kernel, stefan, helgaas,
dl-linux-imx, kernel, linux-arm-kernel, l.stach
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Friday, February 19, 2021 1:34 AM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; helgaas@kernel.org; stefan@agner.ch;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
> [...]
> > > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register
> > > length"), i.MX6QP PCIe has the similar issue.
> > > Define the length of the DBI registers and limit config space to its
> > > length for i.MX6QP PCIe too.
> >
> > You could probably flip these two sentences around to make the commit
> > message read slightly better, so what about this (a suggestion):
> >
> > Define the length of the DBI registers and limit config space to its
> > length. This makes sure that the kernel does not access registers
> > beyond that point that otherwise would lead to an abort on a i.MX
> 6QuadPlus.
> >
> > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> > resolves a similar issue on a i.MX 6Quad PCIe.
> [...]
>
> If you do decide to send another version, then also use "PCIe" in the subject,
> rather than "pcie". I forgot to mention this in the previous message,
> apologies.
>
[Richard Zhu] Never mind. Thanks a lot for your comments.
Would issue another version a moment later.
Best Regards
Richard Zhu
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-02-20 1:30 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 5:09 [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie Richard Zhu
2021-02-18 5:09 ` Richard Zhu
2021-02-18 8:59 ` Lucas Stach
2021-02-18 8:59 ` Lucas Stach
2021-02-18 11:55 ` Krzysztof Wilczyński
2021-02-18 11:55 ` Krzysztof Wilczyński
2021-02-18 17:34 ` Krzysztof Wilczyński
2021-02-18 17:34 ` Krzysztof Wilczyński
2021-02-20 1:27 ` [EXT] " Richard Zhu
2021-02-20 1:27 ` Richard Zhu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.