[PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[Ye Li]

Since SPL has initialized clocks for bus and core. We don't need to
set the default clocks for clock controller node.

Signed-off-by: Ye Li <ye.li@nxp.com>
---
 arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi
index d61346d..a6ede2e 100644
--- a/arch/arm/dts/imx8mp-u-boot.dtsi
+++ b/arch/arm/dts/imx8mp-u-boot.dtsi
@@ -18,6 +18,9 @@
 &clk {
 	u-boot,dm-spl;
 	u-boot,dm-pre-reloc;
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+	/delete-property/ assigned-clock-rates;
 };
 
 &osc_32k {
-- 
2.7.4

Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[Teresa Remmet]

Am Dienstag, den 17.08.2021, 14:32 +0800 schrieb Ye Li:
> Since SPL has initialized clocks for bus and core. We don't need to
> set the default clocks for clock controller node.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>

Tested-by: Teresa Remmet <t.remmet@phytec.de>

> ---
>  arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-
> boot.dtsi
> index d61346d..a6ede2e 100644
> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> @@ -18,6 +18,9 @@
>  &clk {
>  	u-boot,dm-spl;
>  	u-boot,dm-pre-reloc;
> +	/delete-property/ assigned-clocks;
> +	/delete-property/ assigned-clock-parents;
> +	/delete-property/ assigned-clock-rates;
>  };
>  
>  &osc_32k {

RE: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[ZHIZHIKIN Andrey]

Hello Stefano,

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Teresa Remmet
> Sent: Thursday, August 26, 2021 9:20 AM
> To: festevam@gmail.com; u-boot@lists.denx.de; sbabic@denx.de;
> ye.li@nxp.com; peng.fan@nxp.com
> Cc: uboot-imx@nxp.com
> Subject: Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller
> node
> 
> Am Dienstag, den 17.08.2021, 14:32 +0800 schrieb Ye Li:
> > Since SPL has initialized clocks for bus and core. We don't need to
> > set the default clocks for clock controller node.

Just a ping on this patch, it seems that without this path uSDHC controllers are not being correctly probed, hence the boot sequence is blocked.
Applying this patch does solve the probing.

Can you please consider taking this patch?

> >
> > Signed-off-by: Ye Li <ye.li@nxp.com>
> 
> Tested-by: Teresa Remmet <t.remmet@phytec.de>

Tested-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>

> 
> > ---
> >  arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-
> > boot.dtsi index d61346d..a6ede2e 100644
> > --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> > @@ -18,6 +18,9 @@
> >  &clk {
> >       u-boot,dm-spl;
> >       u-boot,dm-pre-reloc;
> > +     /delete-property/ assigned-clocks;
> > +     /delete-property/ assigned-clock-parents;
> > +     /delete-property/ assigned-clock-rates;
> >  };
> >
> >  &osc_32k {

Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[Peng Fan (OSS)]

On 2021/8/17 14:32, Ye Li wrote:
> Since SPL has initialized clocks for bus and core. We don't need to
> set the default clocks for clock controller node.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
>   arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi
> index d61346d..a6ede2e 100644
> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> @@ -18,6 +18,9 @@
>   &clk {
>   	u-boot,dm-spl;
>   	u-boot,dm-pre-reloc;
> +	/delete-property/ assigned-clocks;
> +	/delete-property/ assigned-clock-parents;
> +	/delete-property/ assigned-clock-rates;
>   };
>   
>   &osc_32k {
> 

For a release fix, this is ok.
Acked-by: Peng Fan <peng.fan@nxp.com>

But for distro boot, we need think Linux Kernel will
use the device tree exported by U-Boot. Removing
this property may cause issue.

I think other vendors may has similar issue
that U-Boot modify dtb and corrupt distribution
kernel booting.

Thanks,
Peng.

Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[Stefano Babic]

Hi Peng,

On 15.09.21 05:01, Peng Fan (OSS) wrote:
> 
> 
> On 2021/8/17 14:32, Ye Li wrote:
>> Since SPL has initialized clocks for bus and core. We don't need to
>> set the default clocks for clock controller node.
>>
>> Signed-off-by: Ye Li <ye.li@nxp.com>
>> ---
>>   arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi 
>> b/arch/arm/dts/imx8mp-u-boot.dtsi
>> index d61346d..a6ede2e 100644
>> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
>> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
>> @@ -18,6 +18,9 @@
>>   &clk {
>>       u-boot,dm-spl;
>>       u-boot,dm-pre-reloc;
>> +    /delete-property/ assigned-clocks;
>> +    /delete-property/ assigned-clock-parents;
>> +    /delete-property/ assigned-clock-rates;
>>   };
>>   &osc_32k {
>>
> 
> For a release fix, this is ok.
> Acked-by: Peng Fan <peng.fan@nxp.com>
> 
> But for distro boot, we need think Linux Kernel will
> use the device tree exported by U-Boot. Removing
> this property may cause issue.
> 

But let's think this is not the only use case. The other use case is 
kernel has its own DT and not the one from U-Boot. In products in field, 
if kernel has a strong dependency from U-Boot, a kernel update can be 
done only if it is together a bootloader update.

> I think other vendors may has similar issue
> that U-Boot modify dtb and corrupt distribution
> kernel booting.

We should also think about if thsi is a good thing. There could not be a 
kernel update without a u-boot update. And just a few devices have 
support for a powercut safe bootloader update.

I do not want to be very OT, I apply the patch, sorry for delay.

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

[PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

[sbabic]

> Since SPL has initialized clocks for bus and core. We don't need to
> set the default clocks for clock controller node.
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Tested-by: Teresa Remmet <t.remmet@phytec.de>
> Tested-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Acked-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================