RE: [PATCH] phy: freescale: imx8m-pcie: Handle IMX8_PCIE_REFCLK_PAD_UNUSED

[Hongxing Zhu <hongxing.zhu@nxp.com>]

> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: 2022年3月14日 18:53
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; linux-phy@lists.infradead.org
> Cc: Fabio Estevam <festevam@denx.de>; Kishon Vijay Abraham I
> <kishon@ti.com>; Marcel Ziswiler <marcel.ziswiler@toradex.com>;
> dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>; Shawn
> Guo <shawnguo@kernel.org>; Vinod Koul <vkoul@kernel.org>;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] phy: freescale: imx8m-pcie: Handle
> IMX8_PCIE_REFCLK_PAD_UNUSED
> 
> On 3/14/22 04:29, Hongxing Zhu wrote:
> 
> [...]
> 
> >>>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> Hi Marek:
> >>> Thanks for your patch.
> >>> I assume that you had tested this IMX8_PCIE_REFCLK_PAD_UNUSED
> option.
> >>
> >> Yes
> >>
> >>> The CLK_N/P pads are not connected on the tested board, right?
> >>
> >> They are connected from MX8MP SoC to MiniPCIe slot.
> >> There is no external clock source like on the EVK, the MX8MP internal
> >> PLL is the clock source.
> >>
> > Got that, thanks.
> 
> btw. if you plan to resend the MX8MP PCIe patches (assuming they didn't get
> applied yet), CC me, I can provide a Tested-by .

Sure, I would CC you from next review cycle.
It's great that you can help. Thanks.

> 
> >>> BTW, it's better to add the Fixes tag into the commit log.
> >>
> >> Do you think this should be considered a bugfix ?
> > Emm...
> > It's reasonable to consider it as new added.
> > Okay, I'm fine with it. Thanks again for your patch.
> >
> > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
> 
> Let's wait for others' opinion, I'm really unsure whether this is a
> Fixes: or not.
Okay.

Best Regards
Richard Zhu
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy