Re: [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

From: BrillyWu <brillywu@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	BrillyWu@viatech.com.cn, avi@redhat.com, mtosatti@redhat.com,
	qemu-devel@nongnu.org, mst@redhat.com, KaryJin@viatech.com.cn,
	kvm@vger.kernel.org
Subject: Re: [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU
Date: Tue, 31 May 2011 16:22:59 +0800	[thread overview]
Message-ID: <BANLkTimbpXu+bhgn4CCUZ0Ls7Q=QnxNHZw@mail.gmail.com> (raw)
In-Reply-To: <4DE49DB7.30600@web.de>

> >> Blue, this does not trigger the missing braces warning:
> >
> > Do you mean the bug is that it can not trigger missing
> braces warining?
>
> The script fails to detect missing braces as marked below.
>
> > It seems that there is no missing braces in my patch, but some
> > unnecessary braces.
>
> There are no unnecessary braces according to QEMU coding style.

Oh, I see. Thank you!

> >> +                    index = env->cpuid_xlevel;
> >> +                }
> >> +            } else
> >> +                index =  env->cpuid_xlevel;
>
> This should be:
>
>     } else {
>         index = ...
>     }
>
> >> +        }
>
> Nope, see above.

It looks that I should add the missing braces.

>
> > BTW, I have submited a patch v3 a few minutes before withou
> fixing up
> > the braces, and I have tested it with my mail client this
> time, so it
> > could be OK now.
>
> Yes, your mail client works fine as far as I can see.

Yes, you are right. It seems to be the problem of my editor.

I'll check whether other places need any brace, and then send it to
the patch v3 thread.