* [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
@ 2011-05-16 14:06 Thomas Abraham
2011-05-16 16:57 ` Marek Szyprowski
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Abraham @ 2011-05-16 14:06 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim
On SMDKV310 board, a card detect gpio pin is available that is directly
connected to the io pad of the sdhci controller. Fix incorrect value
of cd_type field in platform data for sdhci instance 0 and 2.
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
arch/arm/mach-exynos4/mach-smdkv310.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
index 1526764..f6b1c7e 100644
--- a/arch/arm/mach-exynos4/mach-smdkv310.c
+++ b/arch/arm/mach-exynos4/mach-smdkv310.c
@@ -78,7 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[] __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.ext_cd_gpio = EXYNOS4_GPK0(2),
.ext_cd_gpio_invert = 1,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
@@ -96,7 +96,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.ext_cd_gpio = EXYNOS4_GPK2(2),
.ext_cd_gpio_invert = 1,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
--
1.6.6.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
2011-05-16 14:06 [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board Thomas Abraham
@ 2011-05-16 16:57 ` Marek Szyprowski
2011-05-19 20:10 ` Thomas Abraham
0 siblings, 1 reply; 6+ messages in thread
From: Marek Szyprowski @ 2011-05-16 16:57 UTC (permalink / raw)
To: 'Thomas Abraham', linux-samsung-soc; +Cc: kgene.kim
Hello,
On Monday, May 16, 2011 4:06 PM Thomas Abraham wrote:
> On SMDKV310 board, a card detect gpio pin is available that is directly
> connected to the io pad of the sdhci controller. Fix incorrect value
> of cd_type field in platform data for sdhci instance 0 and 2.
>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> arch/arm/mach-exynos4/mach-smdkv310.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-
> exynos4/mach-smdkv310.c
> index 1526764..f6b1c7e 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -78,7 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[]
> __initdata = {
> };
>
> static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
> - .cd_type = S3C_SDHCI_CD_GPIO,
> + .cd_type = S3C_SDHCI_CD_INTERNAL,
> .ext_cd_gpio = EXYNOS4_GPK0(2),
> .ext_cd_gpio_invert = 1,
When you are changing the card detection type from GPIO to INTERNAL you should
also remove 'ext_cd_gpio' and 'ext_cd_gpio_invert' definitions.
> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
> @@ -96,7 +96,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata
> __initdata = {
> };
>
> static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
> - .cd_type = S3C_SDHCI_CD_GPIO,
> + .cd_type = S3C_SDHCI_CD_INTERNAL,
> .ext_cd_gpio = EXYNOS4_GPK2(2),
> .ext_cd_gpio_invert = 1,
The same as with hsmmc0.
> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
> --
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
2011-05-16 16:57 ` Marek Szyprowski
@ 2011-05-19 20:10 ` Thomas Abraham
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Abraham @ 2011-05-19 20:10 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: linux-samsung-soc, kgene.kim
Hi Marek,
On Mon, May 16, 2011 at 10:27 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Hello,
>
> On Monday, May 16, 2011 4:06 PM Thomas Abraham wrote:
>
>> On SMDKV310 board, a card detect gpio pin is available that is directly
>> connected to the io pad of the sdhci controller. Fix incorrect value
>> of cd_type field in platform data for sdhci instance 0 and 2.
>>
>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
>> ---
>> arch/arm/mach-exynos4/mach-smdkv310.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-
>> exynos4/mach-smdkv310.c
>> index 1526764..f6b1c7e 100644
>> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
>> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
>> @@ -78,7 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[]
>> __initdata = {
>> };
>>
>> static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
>> - .cd_type = S3C_SDHCI_CD_GPIO,
>> + .cd_type = S3C_SDHCI_CD_INTERNAL,
>> .ext_cd_gpio = EXYNOS4_GPK0(2),
>> .ext_cd_gpio_invert = 1,
>
> When you are changing the card detection type from GPIO to INTERNAL you should
> also remove 'ext_cd_gpio' and 'ext_cd_gpio_invert' definitions.
Thanks for your comments. I will fix this and submit another patch.
Thomas.
>
>> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
>> @@ -96,7 +96,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata
>> __initdata = {
>> };
>>
>> static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
>> - .cd_type = S3C_SDHCI_CD_GPIO,
>> + .cd_type = S3C_SDHCI_CD_INTERNAL,
>> .ext_cd_gpio = EXYNOS4_GPK2(2),
>> .ext_cd_gpio_invert = 1,
>
> The same as with hsmmc0.
>
>> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
>> --
>
> Best regards
> --
> Marek Szyprowski
> Samsung Poland R&D Center
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
@ 2011-05-19 20:24 Thomas Abraham
2011-06-16 9:46 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Abraham @ 2011-05-19 20:24 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim
On SMDKV310 board, a card detect gpio pin is available that is directly
connected to the io pad of the sdhci controller. Fix incorrect value
of cd_type field in platform data for sdhci instance 0 and 2.
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
arch/arm/mach-exynos4/mach-smdkv310.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
index 1526764..edd8141 100644
--- a/arch/arm/mach-exynos4/mach-smdkv310.c
+++ b/arch/arm/mach-exynos4/mach-smdkv310.c
@@ -78,9 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[] __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
- .ext_cd_gpio = EXYNOS4_GPK0(2),
- .ext_cd_gpio_invert = 1,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
#ifdef CONFIG_EXYNOS4_SDHCI_CH0_8BIT
.max_width = 8,
@@ -96,9 +94,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
- .ext_cd_gpio = EXYNOS4_GPK2(2),
- .ext_cd_gpio_invert = 1,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
#ifdef CONFIG_EXYNOS4_SDHCI_CH2_8BIT
.max_width = 8,
--
1.6.6.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
2011-05-19 20:24 Thomas Abraham
@ 2011-06-16 9:46 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2011-06-16 9:46 UTC (permalink / raw)
To: 'Thomas Abraham', linux-samsung-soc
Thomas Abraham wrote:
>
> On SMDKV310 board, a card detect gpio pin is available that is directly
> connected to the io pad of the sdhci controller. Fix incorrect value
> of cd_type field in platform data for sdhci instance 0 and 2.
>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> arch/arm/mach-exynos4/mach-smdkv310.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-
> exynos4/mach-smdkv310.c
> index 1526764..edd8141 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -78,9 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[]
__initdata
> = {
> };
>
> static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
> - .cd_type = S3C_SDHCI_CD_GPIO,
> - .ext_cd_gpio = EXYNOS4_GPK0(2),
> - .ext_cd_gpio_invert = 1,
> + .cd_type = S3C_SDHCI_CD_INTERNAL,
> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
> #ifdef CONFIG_EXYNOS4_SDHCI_CH0_8BIT
> .max_width = 8,
> @@ -96,9 +94,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata
> __initdata = {
> };
>
> static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
> - .cd_type = S3C_SDHCI_CD_GPIO,
> - .ext_cd_gpio = EXYNOS4_GPK2(2),
> - .ext_cd_gpio_invert = 1,
> + .cd_type = S3C_SDHCI_CD_INTERNAL,
> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
> #ifdef CONFIG_EXYNOS4_SDHCI_CH2_8BIT
> .max_width = 8,
> --
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board
@ 2011-04-12 14:03 Thomas Abraham
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Abraham @ 2011-04-12 14:03 UTC (permalink / raw)
To: linux-samsung-soc, nicolas.pitre
Cc: kgene.kim, ben-linux, linaro-dev, patches, Thomas Abraham
On SMDKV310 board, a card detect gpio pin is available that is directly
connected to the io pad of the sdhci controller. Fix incorrect value
of cd_type field in platform data for sdhci instance 0 and 2.
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
arch/arm/mach-exynos4/mach-smdkv310.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
index 1526764..f6b1c7e 100644
--- a/arch/arm/mach-exynos4/mach-smdkv310.c
+++ b/arch/arm/mach-exynos4/mach-smdkv310.c
@@ -78,7 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[] __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.ext_cd_gpio = EXYNOS4_GPK0(2),
.ext_cd_gpio_invert = 1,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
@@ -96,7 +96,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata __initdata = {
};
static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
- .cd_type = S3C_SDHCI_CD_GPIO,
+ .cd_type = S3C_SDHCI_CD_INTERNAL,
.ext_cd_gpio = EXYNOS4_GPK2(2),
.ext_cd_gpio_invert = 1,
.clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
--
1.6.6.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-16 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-16 14:06 [PATCH] ARM: EXYNOS4: Fix card insert/removal event detection on smdkv310 board Thomas Abraham
2011-05-16 16:57 ` Marek Szyprowski
2011-05-19 20:10 ` Thomas Abraham
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 20:24 Thomas Abraham
2011-06-16 9:46 ` Kukjin Kim
2011-04-12 14:03 Thomas Abraham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.