All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Miao <eric.y.miao@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: zhangfei gao <zhangfei.gao@gmail.com>,
	Philip Rakity <prakity@marvell.com>,
	Zhangfei Gao <zgao6@marvell.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Nicolas Pitre <nico@fluxnic.net>, Qiming Wu <wuqm@marvell.com>,
	Jun Nie <njun@marvell.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Raymond Wu <xywu@marvell.com>, Chris Ball <cjb@laptop.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/4] mmc: support sdhci-pxav2.c
Date: Tue, 7 Jun 2011 15:31:48 +0800	[thread overview]
Message-ID: <BANLkTinsk0AzBYd+fO9Oz1RO9smNzJTsTA@mail.gmail.com> (raw)
In-Reply-To: <201106070917.41691.arnd@arndb.de>

> How about changing the title of the option though? A user will
> usually not know if he is using the v2 or v3 controller without
> reading the help text. If you change it to
>
> config MMC_SDHCI_PXAV2
>        tristate "Marvell PXA168 SD Host Controller support (PXAV2)"
>        default CPU_PXA168
>
> config MMC_SDHCI_PXAV3
>        tristate "Marvell MMP2/PX9XX SD Host Controller support (PXAV3)"
>        default CPU_MMP2 || CPU_PXA910
>

Yeah, the above is much cleaner/simpler.

> you increase the chances of users getting the configuration right.
>
>        Arnd
>
> BTW, both of you: Please always remove the lines that you don't refer to
> when you reply to an email. It's very annoying having to scroll through
> dozens of lines of citations to see what you are actually writing.
>

WARNING: multiple messages have this Message-ID (diff)
From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] mmc: support sdhci-pxav2.c
Date: Tue, 7 Jun 2011 15:31:48 +0800	[thread overview]
Message-ID: <BANLkTinsk0AzBYd+fO9Oz1RO9smNzJTsTA@mail.gmail.com> (raw)
In-Reply-To: <201106070917.41691.arnd@arndb.de>

> How about changing the title of the option though? A user will
> usually not know if he is using the v2 or v3 controller without
> reading the help text. If you change it to
>
> config MMC_SDHCI_PXAV2
> ? ? ? ?tristate "Marvell PXA168 SD Host Controller support (PXAV2)"
> ? ? ? ?default CPU_PXA168
>
> config MMC_SDHCI_PXAV3
> ? ? ? ?tristate "Marvell MMP2/PX9XX SD Host Controller support (PXAV3)"
> ? ? ? ?default CPU_MMP2 || CPU_PXA910
>

Yeah, the above is much cleaner/simpler.

> you increase the chances of users getting the configuration right.
>
> ? ? ? ?Arnd
>
> BTW, both of you: Please always remove the lines that you don't refer to
> when you reply to an email. It's very annoying having to scroll through
> dozens of lines of citations to see what you are actually writing.
>

  reply	other threads:[~2011-06-07  7:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03  9:50 [PATCH v3 2/4] mmc: support sdhci-pxav2.c Zhangfei Gao
2011-06-03  9:50 ` Zhangfei Gao
2011-06-03 16:15 ` Arnd Bergmann
2011-06-03 16:15   ` Arnd Bergmann
2011-06-03 18:42 ` Philip Rakity
2011-06-03 18:42   ` Philip Rakity
     [not found]   ` <F07D64EA-88E7-4BF2-B677-3A01215923DD@marvell.com>
2011-06-04  0:04     ` Philip Rakity
2011-06-04  0:04       ` Philip Rakity
2011-06-07  6:03       ` zhangfei gao
2011-06-07  6:03         ` zhangfei gao
2011-06-06 19:39 ` Philip Rakity
2011-06-06 19:39   ` Philip Rakity
2011-06-07  6:08   ` zhangfei gao
2011-06-07  6:08     ` zhangfei gao
2011-06-07  7:17     ` Arnd Bergmann
2011-06-07  7:17       ` Arnd Bergmann
2011-06-07  7:31       ` Eric Miao [this message]
2011-06-07  7:31         ` Eric Miao
2011-06-07 15:04         ` Philip Rakity
2011-06-07 15:04           ` Philip Rakity
2011-06-08  3:03           ` zhangfei gao
2011-06-08  3:03             ` zhangfei gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinsk0AzBYd+fO9Oz1RO9smNzJTsTA@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=njun@marvell.com \
    --cc=prakity@marvell.com \
    --cc=shawn.guo@linaro.org \
    --cc=w.sang@pengutronix.de \
    --cc=wuqm@marvell.com \
    --cc=xywu@marvell.com \
    --cc=zgao6@marvell.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.