From: Martin Sperl <martin@sperl.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: wsa@the-dreams.de, Stephen Warren <swarren@wwwdotorg.org>,
Eric Anholt <eric@anholt.net>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors
Date: Thu, 29 Sep 2016 13:05:01 +0200 [thread overview]
Message-ID: <BB56B9B7-75EF-4674-9951-22426C3BD8BF@sperl.org> (raw)
In-Reply-To: <1475085056-5205-4-git-send-email-noralf@tronnes.org>
On 28.09.2016, at 19:50, Noralf Trønnes <noralf@tronnes.org> wrote:
>
> Writing to an AT24C32 generates on average 2x i2c transfer errors per
> 32-byte page write. Which amounts to a lot for a 4k write. This is due
> to the fact that the chip doesn't respond during it's internal write
> cycle when the at24 driver tries and retries the next write.
> Only a handful drivers use dev_err() on transfer error, so switch to
> dev_dbg() instead.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Martin Sperl <kernel@martin.sperl.org>
WARNING: multiple messages have this Message-ID (diff)
From: martin@sperl.org (Martin Sperl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors
Date: Thu, 29 Sep 2016 13:05:01 +0200 [thread overview]
Message-ID: <BB56B9B7-75EF-4674-9951-22426C3BD8BF@sperl.org> (raw)
In-Reply-To: <1475085056-5205-4-git-send-email-noralf@tronnes.org>
On 28.09.2016, at 19:50, Noralf Tr?nnes <noralf@tronnes.org> wrote:
>
> Writing to an AT24C32 generates on average 2x i2c transfer errors per
> 32-byte page write. Which amounts to a lot for a 4k write. This is due
> to the fact that the chip doesn't respond during it's internal write
> cycle when the at24 driver tries and retries the next write.
> Only a handful drivers use dev_err() on transfer error, so switch to
> dev_dbg() instead.
>
> Signed-off-by: Noralf Tr?nnes <noralf@tronnes.org>
Reviewed-by: Martin Sperl <kernel@martin.sperl.org>
next prev parent reply other threads:[~2016-09-29 11:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 17:50 [PATCH v3 0/7] i2c: bcm2835: Bring in changes from downstream Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 1/7] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 22:00 ` Eric Anholt
2016-09-28 22:00 ` Eric Anholt
2016-09-28 22:00 ` Eric Anholt
2016-09-28 22:22 ` Noralf Trønnes
2016-09-28 22:22 ` Noralf Trønnes
2016-09-29 5:37 ` Stefan Wahren
2016-09-29 5:37 ` Stefan Wahren
2016-10-02 14:19 ` Noralf Trønnes
2016-10-02 14:19 ` Noralf Trønnes
2016-10-03 18:58 ` Eric Anholt
2016-10-03 18:58 ` Eric Anholt
2016-10-03 19:42 ` Eric Anholt
2016-10-03 19:42 ` Eric Anholt
2016-10-04 19:24 ` Noralf Trønnes
2016-10-04 19:24 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-29 11:05 ` Martin Sperl [this message]
2016-09-29 11:05 ` Martin Sperl
2016-09-28 17:50 ` [PATCH v3 4/7] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 5/7] i2c: bcm2835: Add support for Repeated Start Condition Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 6/7] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock Noralf Trønnes
2016-09-28 17:50 ` Noralf Trønnes
2016-09-28 21:24 ` Eric Anholt
2016-09-28 21:24 ` Eric Anholt
2016-09-28 21:24 ` Eric Anholt
2016-09-28 22:10 ` Noralf Trønnes
2016-09-28 22:10 ` Noralf Trønnes
2016-09-29 8:02 ` Martin Sperl
2016-09-29 8:02 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB56B9B7-75EF-4674-9951-22426C3BD8BF@sperl.org \
--to=martin@sperl.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=noralf@tronnes.org \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.