From: wenbo.wang@memblaze.com (Wenbo Wang)
Subject: [PATCH] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 10:41:29 +0000 [thread overview]
Message-ID: <BJXPR01MB19942F16BD7672E12033DFCE0C20@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <20160120102228.GP2742@c203.arch.suse.de>
Thanks for this information. I'll add this.
-----Original Message-----
From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Johannes Thumshirn
Sent: Wednesday, January 20, 2016 6:22 PM
To: Sagi Grimberg
Cc: Wenbo Wang; Wenbo Wang; keith.busch at intel.com; axboe at fb.com; Wenwei.Tao; linux-kernel at vger.kernel.org; linux-nvme at lists.infradead.org
Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq
On Wed, Jan 20, 2016@11:56:01AM +0200, Sagi Grimberg wrote:
>
> >>If it can cause a kernel panic shouldn't it go through stable then as well?
> >
> >Sorry, not quite understand this comment.
> >The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> >During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> >During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
>
> I think what Johannes meant was that this patch should include a
> "CC: stable at vger.kernel.org" tag.
>
Exactly. This makes work for us distribution people a lot easier (i.e. we do not have to manually scan all commits and decide if we need to backport a patch or not)
Thanks
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2016-01-20 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 4:57 [PATCH] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20 4:57 ` Wenbo Wang
2016-01-20 9:06 ` Sagi Grimberg
2016-01-20 9:06 ` Sagi Grimberg
2016-01-20 10:52 ` Wenbo Wang
2016-01-20 9:09 ` Johannes Thumshirn
2016-01-20 9:09 ` Johannes Thumshirn
2016-01-20 9:45 ` Wenbo Wang
2016-01-20 9:56 ` Sagi Grimberg
2016-01-20 9:56 ` Sagi Grimberg
2016-01-20 10:22 ` Johannes Thumshirn
2016-01-20 10:22 ` Johannes Thumshirn
2016-01-20 10:41 ` Wenbo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BJXPR01MB19942F16BD7672E12033DFCE0C20@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn \
--to=wenbo.wang@memblaze.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.