From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Wenbo Wang <wenbo.wang@memblaze.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Wenbo Wang <mail_weber_wang@163.com>
Cc: "keith.busch@intel.com" <keith.busch@intel.com>,
"axboe@fb.com" <axboe@fb.com>,
"Wenwei.Tao" <wenwei.tao@memblaze.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 11:56:01 +0200 [thread overview]
Message-ID: <569F59B1.3040207@dev.mellanox.co.il> (raw)
In-Reply-To: <BJXPR01MB199909E00F32CCC29F15C43E0C20@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
>> If it can cause a kernel panic shouldn't it go through stable then as well?
>
> Sorry, not quite understand this comment.
> The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
I think what Johannes meant was that this patch should include a
"CC: stable@vger.kernel.org" tag.
WARNING: multiple messages have this Message-ID (diff)
From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 11:56:01 +0200 [thread overview]
Message-ID: <569F59B1.3040207@dev.mellanox.co.il> (raw)
In-Reply-To: <BJXPR01MB199909E00F32CCC29F15C43E0C20@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
>> If it can cause a kernel panic shouldn't it go through stable then as well?
>
> Sorry, not quite understand this comment.
> The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
I think what Johannes meant was that this patch should include a
"CC: stable at vger.kernel.org" tag.
next prev parent reply other threads:[~2016-01-20 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 4:57 [PATCH] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20 4:57 ` Wenbo Wang
2016-01-20 9:06 ` Sagi Grimberg
2016-01-20 9:06 ` Sagi Grimberg
2016-01-20 10:52 ` Wenbo Wang
2016-01-20 9:09 ` Johannes Thumshirn
2016-01-20 9:09 ` Johannes Thumshirn
2016-01-20 9:45 ` Wenbo Wang
2016-01-20 9:56 ` Sagi Grimberg [this message]
2016-01-20 9:56 ` Sagi Grimberg
2016-01-20 10:22 ` Johannes Thumshirn
2016-01-20 10:22 ` Johannes Thumshirn
2016-01-20 10:41 ` Wenbo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F59B1.3040207@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mail_weber_wang@163.com \
--cc=wenbo.wang@memblaze.com \
--cc=wenwei.tao@memblaze.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.