All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Wenbo Wang <wenbo.wang@memblaze.com>,
	Wenbo Wang <mail_weber_wang@163.com>,
	"keith.busch@intel.com" <keith.busch@intel.com>,
	"axboe@fb.com" <axboe@fb.com>,
	"Wenwei.Tao" <wenwei.tao@memblaze.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 11:22:28 +0100	[thread overview]
Message-ID: <20160120102228.GP2742@c203.arch.suse.de> (raw)
In-Reply-To: <569F59B1.3040207@dev.mellanox.co.il>

On Wed, Jan 20, 2016 at 11:56:01AM +0200, Sagi Grimberg wrote:
> 
> >>If it can cause a kernel panic shouldn't it go through stable then as well?
> >
> >Sorry, not quite understand this comment.
> >The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> >During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> >During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
> 
> I think what Johannes meant was that this patch should include a
> "CC: stable@vger.kernel.org" tag.
> 

Exactly. This makes work for us distribution people a lot easier (i.e. we do
not have to manually scan all commits and decide if we need to backport a
patch or not)

Thanks

> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH] NVMe: init nvme queue before enabling irq
Date: Wed, 20 Jan 2016 11:22:28 +0100	[thread overview]
Message-ID: <20160120102228.GP2742@c203.arch.suse.de> (raw)
In-Reply-To: <569F59B1.3040207@dev.mellanox.co.il>

On Wed, Jan 20, 2016@11:56:01AM +0200, Sagi Grimberg wrote:
> 
> >>If it can cause a kernel panic shouldn't it go through stable then as well?
> >
> >Sorry, not quite understand this comment.
> >The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> >During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> >During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
> 
> I think what Johannes meant was that this patch should include a
> "CC: stable at vger.kernel.org" tag.
> 

Exactly. This makes work for us distribution people a lot easier (i.e. we do
not have to manually scan all commits and decide if we need to backport a
patch or not)

Thanks

> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2016-01-20 10:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20  4:57 [PATCH] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20  4:57 ` Wenbo Wang
2016-01-20  9:06 ` Sagi Grimberg
2016-01-20  9:06   ` Sagi Grimberg
2016-01-20 10:52   ` Wenbo Wang
2016-01-20  9:09 ` Johannes Thumshirn
2016-01-20  9:09   ` Johannes Thumshirn
2016-01-20  9:45   ` Wenbo Wang
2016-01-20  9:56     ` Sagi Grimberg
2016-01-20  9:56       ` Sagi Grimberg
2016-01-20 10:22       ` Johannes Thumshirn [this message]
2016-01-20 10:22         ` Johannes Thumshirn
2016-01-20 10:41         ` Wenbo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120102228.GP2742@c203.arch.suse.de \
    --to=jthumshirn@suse.de \
    --cc=axboe@fb.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mail_weber_wang@163.com \
    --cc=sagig@dev.mellanox.co.il \
    --cc=wenbo.wang@memblaze.com \
    --cc=wenwei.tao@memblaze.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.