From: Haiyang Zhang <haiyangz@microsoft.com>
To: Nicholas Mc Guire <der.herr@hofr.at>, KY Srinivasan <kys@microsoft.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] net: hyperv: else branch not necessary
Date: Mon, 26 Jan 2015 22:47:18 +0000 [thread overview]
Message-ID: <BN1PR0301MB0770F37DD16FE4D9AF368083CA350@BN1PR0301MB0770.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at>
> -----Original Message-----
> From: Nicholas Mc Guire [mailto:der.herr@hofr.at]
> Sent: Sunday, January 25, 2015 1:09 PM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@linuxdriverproject.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Nicholas Mc Guire
> Subject: [PATCH v2] net: hyperv: else branch not necessary
>
> As the if completes with a unconditional goto the else branch
> is not needed here.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Thank you!
> ---
>
> v2: added missing subsystem string in subject line - patch unchanged
>
> All paths of execution that did not exit through the if branch will
> go through the else branch so no need for an explicit else here
>
> Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
> CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m
>
> Patch is against 3.19.0-rc5 -next-20150123
>
> drivers/net/hyperv/rndis_filter.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/hyperv/rndis_filter.c
> b/drivers/net/hyperv/rndis_filter.c
> index 7bd8387..efb84a9 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct
> rndis_device *dev, u32 new_filter)
> * send completion for it.
> */
> goto exit;
> - } else {
> - set_complete = &request->response_msg.msg.set_complete;
> - status = set_complete->status;
> - }
> + }
> +
> + set_complete = &request->response_msg.msg.set_complete;
> + status = set_complete->status;
>
> cleanup:
> if (request)
> --
> 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Haiyang Zhang <haiyangz@microsoft.com>
To: Nicholas Mc Guire <der.herr@hofr.at>, KY Srinivasan <kys@microsoft.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2] net: hyperv: else branch not necessary
Date: Mon, 26 Jan 2015 22:47:18 +0000 [thread overview]
Message-ID: <BN1PR0301MB0770F37DD16FE4D9AF368083CA350@BN1PR0301MB0770.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at>
> -----Original Message-----
> From: Nicholas Mc Guire [mailto:der.herr@hofr.at]
> Sent: Sunday, January 25, 2015 1:09 PM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@linuxdriverproject.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Nicholas Mc Guire
> Subject: [PATCH v2] net: hyperv: else branch not necessary
>
> As the if completes with a unconditional goto the else branch
> is not needed here.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Thank you!
> ---
>
> v2: added missing subsystem string in subject line - patch unchanged
>
> All paths of execution that did not exit through the if branch will
> go through the else branch so no need for an explicit else here
>
> Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
> CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m
>
> Patch is against 3.19.0-rc5 -next-20150123
>
> drivers/net/hyperv/rndis_filter.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/hyperv/rndis_filter.c
> b/drivers/net/hyperv/rndis_filter.c
> index 7bd8387..efb84a9 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct
> rndis_device *dev, u32 new_filter)
> * send completion for it.
> */
> goto exit;
> - } else {
> - set_complete = &request->response_msg.msg.set_complete;
> - status = set_complete->status;
> - }
> + }
> +
> + set_complete = &request->response_msg.msg.set_complete;
> + status = set_complete->status;
>
> cleanup:
> if (request)
> --
> 1.7.10.4
next prev parent reply other threads:[~2015-01-26 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 18:08 [PATCH v2] net: hyperv: else branch not necessary Nicholas Mc Guire
2015-01-25 18:08 ` Nicholas Mc Guire
2015-01-26 22:47 ` Haiyang Zhang [this message]
2015-01-26 22:47 ` Haiyang Zhang
2015-01-27 8:10 ` David Miller
2015-01-27 8:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN1PR0301MB0770F37DD16FE4D9AF368083CA350@BN1PR0301MB0770.namprd03.prod.outlook.com \
--to=haiyangz@microsoft.com \
--cc=der.herr@hofr.at \
--cc=devel@linuxdriverproject.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.