From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Matias Bjorling <Matias.Bjorling@wdc.com>
Subject: Re: [PATCH v4 00/11] Zoned block device support improvements
Date: Wed, 24 Oct 2018 08:04:53 +0000 [thread overview]
Message-ID: <BN3PR0401MB1640DDD064340B0C074055AFE7F60@BN3PR0401MB1640.namprd04.prod.outlook.com> (raw)
In-Reply-To: 78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk
Jens,=0A=
=0A=
On 2018/10/23 16:59, Jens Axboe wrote:=0A=
> On 10/12/18 4:08 AM, Damien Le Moal wrote:=0A=
>> This series improves zoned block device support (reduce overhead) and=0A=
>> introduces many simplifications to the code (overall, there are more del=
etions=0A=
>> than insertions).=0A=
>>=0A=
>> In more details:=0A=
>> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements red=
ucing=0A=
>> the overhead of report zones command execution during disk scan and=0A=
>> revalidation.=0A=
>> * Patches 4 to 9 improve the useability and user API of zoned block devi=
ces.=0A=
>> * Patch 10 is the main part of this series. This patch replaces the=0A=
>> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones co=
mmands=0A=
>> with a block device file operation, removing the need for the command =
reply=0A=
>> payload in-place rewriting in the BIO buffer. This leads to major=0A=
>> simplification of the code in many places.=0A=
>> * Patch 11 further simplifies the code of low level drivers by providing=
a=0A=
>> generic implementation of zoned block device reuest queue zone bitmaps=
=0A=
>> initialization and revalidation.=0A=
> =0A=
> I've applied this, but I have two complaints:=0A=
> =0A=
> 1) Two had to be hand applied, it wasn't against the block tree.=0A=
=0A=
My apologies for that. I had to rebase against the latest RC because of a=
=0A=
conflict with late fixes in DM. I should have checked more carefully agains=
t the=0A=
block tree after that. Sorry about this, I will be more careful going forwa=
rd.=0A=
=0A=
> 2) The ordering of the signed-off-by. Someone told me that this is=0A=
> patchwork, but I absolutely hate it. SOB should go last, not before=0A=
> the reviewed-by. I fixed that up too.=0A=
=0A=
Thank you. I think this was me rather than patchwork when I a manually adde=
d the=0A=
reviewed-by tags with new versions of the series. I will remember this and =
tag=0A=
in you preferred order.=0A=
=0A=
Thank you.=0A=
=0A=
Best regards.=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Matias Bjorling <Matias.Bjorling@wdc.com>
Subject: Re: [PATCH v4 00/11] Zoned block device support improvements
Date: Wed, 24 Oct 2018 08:04:53 +0000 [thread overview]
Message-ID: <BN3PR0401MB1640DDD064340B0C074055AFE7F60@BN3PR0401MB1640.namprd04.prod.outlook.com> (raw)
In-Reply-To: 78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk
Jens,
On 2018/10/23 16:59, Jens Axboe wrote:
> On 10/12/18 4:08 AM, Damien Le Moal wrote:
>> This series improves zoned block device support (reduce overhead) and
>> introduces many simplifications to the code (overall, there are more deletions
>> than insertions).
>>
>> In more details:
>> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing
>> the overhead of report zones command execution during disk scan and
>> revalidation.
>> * Patches 4 to 9 improve the useability and user API of zoned block devices.
>> * Patch 10 is the main part of this series. This patch replaces the
>> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones commands
>> with a block device file operation, removing the need for the command reply
>> payload in-place rewriting in the BIO buffer. This leads to major
>> simplification of the code in many places.
>> * Patch 11 further simplifies the code of low level drivers by providing a
>> generic implementation of zoned block device reuest queue zone bitmaps
>> initialization and revalidation.
>
> I've applied this, but I have two complaints:
>
> 1) Two had to be hand applied, it wasn't against the block tree.
My apologies for that. I had to rebase against the latest RC because of a
conflict with late fixes in DM. I should have checked more carefully against the
block tree after that. Sorry about this, I will be more careful going forward.
> 2) The ordering of the signed-off-by. Someone told me that this is
> patchwork, but I absolutely hate it. SOB should go last, not before
> the reviewed-by. I fixed that up too.
Thank you. I think this was me rather than patchwork when I a manually added the
reviewed-by tags with new versions of the series. I will remember this and tag
in you preferred order.
Thank you.
Best regards.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2018-10-24 8:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 10:08 [PATCH v4 00/11] Zoned block device support improvements Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 01/11] scsi: sd_zbc: Rearrange code Damien Le Moal
2018-10-16 4:48 ` Martin K. Petersen
2018-10-16 4:48 ` Martin K. Petersen
2018-10-12 10:08 ` [PATCH v4 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time Damien Le Moal
2018-10-16 4:50 ` Martin K. Petersen
2018-10-16 4:50 ` Martin K. Petersen
2018-10-12 10:08 ` [PATCH v4 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks Damien Le Moal
2018-10-12 10:23 ` Hannes Reinecke
2018-10-12 10:23 ` Hannes Reinecke
2018-10-12 11:41 ` Damien Le Moal
2018-10-12 11:41 ` Damien Le Moal
2018-10-16 4:51 ` Martin K. Petersen
2018-10-16 4:51 ` Martin K. Petersen
2018-10-17 7:21 ` Christoph Hellwig
2018-10-17 7:21 ` Christoph Hellwig
2018-10-12 10:08 ` [PATCH v4 04/11] block: Introduce blkdev_nr_zones() helper Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 05/11] block: Limit allocation of zone descriptors for report zones Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 06/11] block: Introduce BLKGETZONESZ ioctl Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 07/11] block: Introduce BLKGETNRZONES ioctl Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 08/11] block: Improve zone reset execution Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 09/11] block: Expose queue nr_zones in sysfs Damien Le Moal
2018-10-12 10:08 ` [PATCH v4 10/11] block: add a report_zones method Damien Le Moal
2018-10-16 4:55 ` Martin K. Petersen
2018-10-16 4:55 ` Martin K. Petersen
2018-10-16 15:17 ` Mike Snitzer
2018-10-16 15:17 ` Mike Snitzer
2018-10-12 10:08 ` [PATCH v4 11/11] block: Introduce blk_revalidate_disk_zones() Damien Le Moal
2018-10-16 5:00 ` Martin K. Petersen
2018-10-16 5:00 ` Martin K. Petersen
2018-10-16 15:17 ` Mike Snitzer
2018-10-16 15:17 ` Mike Snitzer
2018-10-13 22:43 ` [PATCH v4 00/11] Zoned block device support improvements Jens Axboe
2018-10-15 0:45 ` Damien Le Moal
2018-10-15 0:45 ` Damien Le Moal
2018-10-16 2:34 ` Jens Axboe
2018-10-16 3:43 ` Damien Le Moal
2018-10-16 3:43 ` Damien Le Moal
2018-10-18 7:57 ` Damien Le Moal
2018-10-18 7:57 ` Damien Le Moal
2018-10-23 15:59 ` Jens Axboe
2018-10-24 2:26 ` Martin K. Petersen
2018-10-24 2:26 ` Martin K. Petersen
2018-10-24 15:03 ` Mike Snitzer
2018-10-24 15:03 ` Mike Snitzer
2018-10-24 15:37 ` Martin K. Petersen
2018-10-24 15:37 ` Martin K. Petersen
2018-10-24 16:04 ` Bart Van Assche
2018-10-24 16:04 ` Bart Van Assche
2018-10-25 14:30 ` Jens Axboe
2018-10-25 14:30 ` Jens Axboe
2018-10-24 8:04 ` Damien Le Moal [this message]
2018-10-24 8:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN3PR0401MB1640DDD064340B0C074055AFE7F60@BN3PR0401MB1640.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.