* [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older @ 2018-05-03 19:45 Harry Wentland [not found] ` <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Harry Wentland @ 2018-05-03 19:45 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Harry Wentland We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should probably fallback to the non-DC driver for ASICs that support VGA and LVDS. These ASICs are: * Hawaii * Bonaire * Kabini * Kaveri ASIC support can always be force enabled with amdgpu.dc=1 Signed-off-by: Harry Wentland <harry.wentland@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 887f7c9e84e0..66d8b96a04ac 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type) case CHIP_HAWAII: case CHIP_KAVERI: case CHIP_KABINI: + /* + * We have systems in the wild with these ASICs that require + * LVDS and VGA support which is not supported with DC. + * + * Fallback to the non-DC driver here by default so as not to + * cause regressions. + */ + return amdgpu_dc > 0; case CHIP_MULLINS: case CHIP_CARRIZO: case CHIP_STONEY: -- 2.17.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older [not found] ` <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> @ 2018-05-07 18:38 ` Deucher, Alexander 2018-05-07 18:39 ` Deucher, Alexander 1 sibling, 0 replies; 3+ messages in thread From: Deucher, Alexander @ 2018-05-07 18:38 UTC (permalink / raw) To: Wentland, Harry, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 2232 bytes --] Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org> ________________________________ From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org> Sent: Thursday, May 3, 2018 3:45:30 PM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Wentland, Harry Subject: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should probably fallback to the non-DC driver for ASICs that support VGA and LVDS. These ASICs are: * Hawaii * Bonaire * Kabini * Kaveri ASIC support can always be force enabled with amdgpu.dc=1 Signed-off-by: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 887f7c9e84e0..66d8b96a04ac 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type) case CHIP_HAWAII: case CHIP_KAVERI: case CHIP_KABINI: + /* + * We have systems in the wild with these ASICs that require + * LVDS and VGA support which is not supported with DC. + * + * Fallback to the non-DC driver here by default so as not to + * cause regressions. + */ + return amdgpu_dc > 0; case CHIP_MULLINS: case CHIP_CARRIZO: case CHIP_STONEY: -- 2.17.0 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 4209 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older [not found] ` <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> 2018-05-07 18:38 ` Deucher, Alexander @ 2018-05-07 18:39 ` Deucher, Alexander 1 sibling, 0 replies; 3+ messages in thread From: Deucher, Alexander @ 2018-05-07 18:39 UTC (permalink / raw) To: Wentland, Harry, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 2271 bytes --] Actually, we could arguably enable hawaii since it does not support a DAC and there are no mobile skus. Alex ________________________________ From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org> Sent: Thursday, May 3, 2018 3:45:30 PM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Wentland, Harry Subject: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should probably fallback to the non-DC driver for ASICs that support VGA and LVDS. These ASICs are: * Hawaii * Bonaire * Kabini * Kaveri ASIC support can always be force enabled with amdgpu.dc=1 Signed-off-by: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 887f7c9e84e0..66d8b96a04ac 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type) case CHIP_HAWAII: case CHIP_KAVERI: case CHIP_KABINI: + /* + * We have systems in the wild with these ASICs that require + * LVDS and VGA support which is not supported with DC. + * + * Fallback to the non-DC driver here by default so as not to + * cause regressions. + */ + return amdgpu_dc > 0; case CHIP_MULLINS: case CHIP_CARRIZO: case CHIP_STONEY: -- 2.17.0 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 4334 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-07 18:39 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-03 19:45 [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older Harry Wentland [not found] ` <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> 2018-05-07 18:38 ` Deucher, Alexander 2018-05-07 18:39 ` Deucher, Alexander
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.