From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"sricharan@codeaurora.org" <sricharan@codeaurora.org>
Cc: "jgg@nvidia.com" <jgg@nvidia.com>,
"konrad.dybcio@somainline.org" <konrad.dybcio@somainline.org>,
"yong.wu@mediatek.com" <yong.wu@mediatek.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vdumpa@nvidia.com" <vdumpa@nvidia.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"quic_saipraka@quicinc.com" <quic_saipraka@quicinc.com>,
"jon@solid-run.com" <jon@solid-run.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: RE: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs
Date: Thu, 22 Sep 2022 08:17:03 +0000 [thread overview]
Message-ID: <BN9PR11MB527632E5F21AD412991509458C4E9@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8c3dbf153b63a3002a46bab6e707c63fd8635bb8.1663744983.git.nicolinc@nvidia.com>
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, September 21, 2022 4:23 PM
>
>
> +/**
> + * iommu_attach_device - Attach a device to an IOMMU domain
> + * @domain: IOMMU domain to attach
> + * @dev: Device that will be attached
> + *
> + * Returns 0 on success and error code on failure
> + *
> + * Note that EINVAL may be returned as a soft failure if the domain and
> device
> + * are incompatible due to some previous configuration of the domain, in
> which
> + * case attaching the same device to a different domain may succeed.
Revise a bit:
* Note that EINVAL can be treated as a soft failure, indicating
* that certain configuration of the domain is incompatible with
* the device. In this case attaching a different domain to the
* device may succeed.
Apart from that:
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"sricharan@codeaurora.org" <sricharan@codeaurora.org>
Cc: "quic_saipraka@quicinc.com" <quic_saipraka@quicinc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jon@solid-run.com" <jon@solid-run.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"konrad.dybcio@somainline.org" <konrad.dybcio@somainline.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"vdumpa@nvidia.com" <vdumpa@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"yong.wu@mediatek.com" <yong.wu@mediatek.com>
Subject: RE: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs
Date: Thu, 22 Sep 2022 08:17:03 +0000 [thread overview]
Message-ID: <BN9PR11MB527632E5F21AD412991509458C4E9@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8c3dbf153b63a3002a46bab6e707c63fd8635bb8.1663744983.git.nicolinc@nvidia.com>
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, September 21, 2022 4:23 PM
>
>
> +/**
> + * iommu_attach_device - Attach a device to an IOMMU domain
> + * @domain: IOMMU domain to attach
> + * @dev: Device that will be attached
> + *
> + * Returns 0 on success and error code on failure
> + *
> + * Note that EINVAL may be returned as a soft failure if the domain and
> device
> + * are incompatible due to some previous configuration of the domain, in
> which
> + * case attaching the same device to a different domain may succeed.
Revise a bit:
* Note that EINVAL can be treated as a soft failure, indicating
* that certain configuration of the domain is incompatible with
* the device. In this case attaching a different domain to the
* device may succeed.
Apart from that:
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"sricharan@codeaurora.org" <sricharan@codeaurora.org>
Cc: "quic_saipraka@quicinc.com" <quic_saipraka@quicinc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jon@solid-run.com" <jon@solid-run.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"konrad.dybcio@somainline.org" <konrad.dybcio@somainline.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"yong.wu@mediatek.com" <yong.wu@mediatek.com>
Subject: RE: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs
Date: Thu, 22 Sep 2022 08:17:03 +0000 [thread overview]
Message-ID: <BN9PR11MB527632E5F21AD412991509458C4E9@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8c3dbf153b63a3002a46bab6e707c63fd8635bb8.1663744983.git.nicolinc@nvidia.com>
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, September 21, 2022 4:23 PM
>
>
> +/**
> + * iommu_attach_device - Attach a device to an IOMMU domain
> + * @domain: IOMMU domain to attach
> + * @dev: Device that will be attached
> + *
> + * Returns 0 on success and error code on failure
> + *
> + * Note that EINVAL may be returned as a soft failure if the domain and
> device
> + * are incompatible due to some previous configuration of the domain, in
> which
> + * case attaching the same device to a different domain may succeed.
Revise a bit:
* Note that EINVAL can be treated as a soft failure, indicating
* that certain configuration of the domain is incompatible with
* the device. In this case attaching a different domain to the
* device may succeed.
Apart from that:
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-22 8:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:22 [PATCH v4 0/6] Define EINVAL as device/domain incompatibility Nicolin Chen
2022-09-21 8:22 ` Nicolin Chen
2022-09-21 8:22 ` [PATCH v4 1/6] iommu/msm: Fix error-out routine in msm_iommu_attach_dev() Nicolin Chen
2022-09-22 8:08 ` Tian, Kevin
2022-09-21 8:23 ` [PATCH v4 2/6] iommu/amd: Drop unnecessary checks in amd_iommu_attach_device() Nicolin Chen
2022-09-21 8:23 ` [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs Nicolin Chen
2022-09-21 8:23 ` Nicolin Chen
2022-09-22 2:02 ` Baolu Lu
2022-09-22 2:02 ` Baolu Lu
2022-09-22 5:09 ` Nicolin Chen
2022-09-22 5:09 ` Nicolin Chen
2022-09-22 8:17 ` Tian, Kevin [this message]
2022-09-22 8:17 ` Tian, Kevin
2022-09-22 8:17 ` Tian, Kevin
2022-09-22 8:38 ` Nicolin Chen
2022-09-22 8:38 ` Nicolin Chen
2022-09-21 8:23 ` [PATCH v4 4/6] iommu: Regulate EINVAL in ->attach_dev callback functions Nicolin Chen
2022-09-21 8:23 ` Nicolin Chen
2022-09-22 2:14 ` Baolu Lu
2022-09-22 2:14 ` Baolu Lu
2022-09-22 8:18 ` Tian, Kevin
2022-09-22 8:18 ` Tian, Kevin
2022-09-21 8:23 ` [PATCH v4 5/6] iommu: Use EINVAL for incompatible device/domain in ->attach_dev Nicolin Chen
2022-09-21 8:23 ` Nicolin Chen
2022-09-22 2:16 ` Baolu Lu
2022-09-22 2:16 ` Baolu Lu
2022-09-22 8:19 ` Tian, Kevin
2022-09-22 8:19 ` Tian, Kevin
2022-09-22 8:19 ` Tian, Kevin
2022-09-21 8:23 ` [PATCH v4 6/6] iommu: Propagate return value in ->attach_dev callback functions Nicolin Chen
2022-09-21 8:23 ` Nicolin Chen
2022-09-21 8:55 ` [PATCH v4 0/6] Define EINVAL as device/domain incompatibility Jean-Philippe Brucker
2022-09-21 8:55 ` Jean-Philippe Brucker
2022-09-21 8:55 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB527632E5F21AD412991509458C4E9@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=agross@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baolu.lu@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=jon@solid-run.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=quic_saipraka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sricharan@codeaurora.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.