All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: <joro@8bytes.org>, <suravee.suthikulpanit@amd.com>,
	<will@kernel.org>, <robin.murphy@arm.com>, <robdclark@gmail.com>,
	<dwmw2@infradead.org>, <agross@kernel.org>,
	<bjorn.andersson@linaro.org>, <matthias.bgg@gmail.com>,
	<orsonzhai@gmail.com>, <baolin.wang@linux.alibaba.com>,
	<zhang.lyra@gmail.com>, <jean-philippe@linaro.org>,
	<sricharan@codeaurora.org>, <jgg@nvidia.com>,
	<kevin.tian@intel.com>, <konrad.dybcio@somainline.org>,
	<yong.wu@mediatek.com>, <thierry.reding@gmail.com>,
	<vdumpa@nvidia.com>, <jonathanh@nvidia.com>, <tglx@linutronix.de>,
	<shameerali.kolothum.thodi@huawei.com>,
	<christophe.jaillet@wanadoo.fr>, <thunder.leizhen@huawei.com>,
	<quic_saipraka@quicinc.com>, <jon@solid-run.com>,
	<yangyingliang@huawei.com>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-tegra@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs
Date: Wed, 21 Sep 2022 22:09:02 -0700	[thread overview]
Message-ID: <Yyvt7kBng3iKl56l@Asurada-Nvidia> (raw)
In-Reply-To: <73008702-87e1-688f-b194-c259c9c03caa@linux.intel.com>

On Thu, Sep 22, 2022 at 10:02:42AM +0800, Baolu Lu wrote:
> > +/**
> > + * iommu_attach_device - Attach a device to an IOMMU domain
> 
> Normally we say "attach an iommu domain to a device/group ...".

OK. I can fix it in the next respin.

And I'll add your Reviewed-by in the other two patches too.

Thanks!
Nic

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicolinc@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: quic_saipraka@quicinc.com, konrad.dybcio@somainline.org,
	bjorn.andersson@linaro.org, linux-tegra@vger.kernel.org,
	thierry.reding@gmail.com, will@kernel.org,
	jean-philippe@linaro.org, zhang.lyra@gmail.com, joro@8bytes.org,
	jon@solid-run.com, jonathanh@nvidia.com, iommu@lists.linux.dev,
	agross@kernel.org, linux-arm-kernel@lists.infradead.org,
	jgg@nvidia.com, yangyingliang@huawei.com, orsonzhai@gmail.com,
	kevin.tian@intel.com, linux-arm-msm@vger.kernel.org,
	robin.murphy@arm.com, christophe.jaillet@wanadoo.fr,
	baolin.wang@linux.alibaba.com, thunder.leizhen@huawei.com,
	matthias.bgg@gmail.com, tglx@linutronix.de,
	virtualization@lists.linux-foundation.org, yong.wu@mediatek.com,
	dwmw2@infradead.org, linux-kernel@vger.kernel.org,
	shameerali.kolothum.thodi@huawei.com, robdclark@gmail.com,
	suravee.suthikulpanit@amd.com,
	linux-mediatek@lists.infradead.org, sricharan@codeaurora.org
Subject: Re: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs
Date: Wed, 21 Sep 2022 22:09:02 -0700	[thread overview]
Message-ID: <Yyvt7kBng3iKl56l@Asurada-Nvidia> (raw)
In-Reply-To: <73008702-87e1-688f-b194-c259c9c03caa@linux.intel.com>

On Thu, Sep 22, 2022 at 10:02:42AM +0800, Baolu Lu wrote:
> > +/**
> > + * iommu_attach_device - Attach a device to an IOMMU domain
> 
> Normally we say "attach an iommu domain to a device/group ...".

OK. I can fix it in the next respin.

And I'll add your Reviewed-by in the other two patches too.

Thanks!
Nic

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-22  5:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  8:22 [PATCH v4 0/6] Define EINVAL as device/domain incompatibility Nicolin Chen
2022-09-21  8:22 ` Nicolin Chen
2022-09-21  8:22 ` [PATCH v4 1/6] iommu/msm: Fix error-out routine in msm_iommu_attach_dev() Nicolin Chen
2022-09-22  8:08   ` Tian, Kevin
2022-09-21  8:23 ` [PATCH v4 2/6] iommu/amd: Drop unnecessary checks in amd_iommu_attach_device() Nicolin Chen
2022-09-21  8:23 ` [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and APIs Nicolin Chen
2022-09-21  8:23   ` Nicolin Chen
2022-09-22  2:02   ` Baolu Lu
2022-09-22  2:02     ` Baolu Lu
2022-09-22  5:09     ` Nicolin Chen [this message]
2022-09-22  5:09       ` Nicolin Chen
2022-09-22  8:17   ` Tian, Kevin
2022-09-22  8:17     ` Tian, Kevin
2022-09-22  8:17     ` Tian, Kevin
2022-09-22  8:38     ` Nicolin Chen
2022-09-22  8:38       ` Nicolin Chen
2022-09-21  8:23 ` [PATCH v4 4/6] iommu: Regulate EINVAL in ->attach_dev callback functions Nicolin Chen
2022-09-21  8:23   ` Nicolin Chen
2022-09-22  2:14   ` Baolu Lu
2022-09-22  2:14     ` Baolu Lu
2022-09-22  8:18   ` Tian, Kevin
2022-09-22  8:18     ` Tian, Kevin
2022-09-21  8:23 ` [PATCH v4 5/6] iommu: Use EINVAL for incompatible device/domain in ->attach_dev Nicolin Chen
2022-09-21  8:23   ` Nicolin Chen
2022-09-22  2:16   ` Baolu Lu
2022-09-22  2:16     ` Baolu Lu
2022-09-22  8:19   ` Tian, Kevin
2022-09-22  8:19     ` Tian, Kevin
2022-09-22  8:19     ` Tian, Kevin
2022-09-21  8:23 ` [PATCH v4 6/6] iommu: Propagate return value in ->attach_dev callback functions Nicolin Chen
2022-09-21  8:23   ` Nicolin Chen
2022-09-21  8:55 ` [PATCH v4 0/6] Define EINVAL as device/domain incompatibility Jean-Philippe Brucker
2022-09-21  8:55   ` Jean-Philippe Brucker
2022-09-21  8:55   ` Jean-Philippe Brucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yyvt7kBng3iKl56l@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=agross@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=jean-philippe@linaro.org \
    --cc=jgg@nvidia.com \
    --cc=jon@solid-run.com \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=orsonzhai@gmail.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=sricharan@codeaurora.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=vdumpa@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will@kernel.org \
    --cc=yangyingliang@huawei.com \
    --cc=yong.wu@mediatek.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.