From: Jeffrey Lien <Jeff.Lien@wdc.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Kenneth Burgener <Kenneth.Burgener@wdc.com>,
Randy Bates <randall.bates@wdc.com>,
linux-nvme <linux-nvme@lists.infradead.org>
Subject: RE: NVMe-CLI issue on Ubuntu 18.04 Kernel
Date: Tue, 31 Mar 2020 16:09:10 +0000 [thread overview]
Message-ID: <BYAPR04MB5656A704F3836756F70D8C77EAC80@BYAPR04MB5656.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200331143236.GA30875@redsun51.ssa.fujisawa.hgst.com>
Sounds good Keith. We'll make the change to the nvme cli code and submit a pull req.
Jeff Lien
-----Original Message-----
From: Keith Busch <kbusch@kernel.org>
Sent: Tuesday, March 31, 2020 9:33 AM
To: Jeffrey Lien <Jeff.Lien@wdc.com>
Cc: linux-nvme <linux-nvme@lists.infradead.org>; Randy Bates <randall.bates@wdc.com>; Kenneth Burgener <Kenneth.Burgener@wdc.com>
Subject: Re: NVMe-CLI issue on Ubuntu 18.04 Kernel
CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.
On Tue, Mar 31, 2020 at 02:21:01PM +0000, Jeffrey Lien wrote:
> We are seeing the following error message when executing the "nvme list" command on Ubuntu 18.04 with the 4.15.0 kernel:
> root@lmt-store-17:~/.src/nvme-cli-old# nvme list Failed to open
> /sys/class/nvme-subsystem/nvme-subsys0/nvme0/address: No such file or
> directory
>
> It does not seem to effect the completion of the command; it's just extra noise back from the command. I'm not sure why the address is not present with the 4.15.0 kernel, but also not sure what it's used for by the nvme cli code. It's referenced in the scan_ctrl function in nvme-topology.c part but I don't think it's used by any other functions. Is it ok to just remove the reference to the address attribute in the the nvme cli code? Or is there a better fix for this issue?
I think we should suppress the output in this case. We don't need the 'address' attribute, though it's nice to have.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-03-31 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 14:21 NVMe-CLI issue on Ubuntu 18.04 Kernel Jeffrey Lien
2020-03-31 14:32 ` Keith Busch
2020-03-31 16:09 ` Jeffrey Lien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5656A704F3836756F70D8C77EAC80@BYAPR04MB5656.namprd04.prod.outlook.com \
--to=jeff.lien@wdc.com \
--cc=Kenneth.Burgener@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randall.bates@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.