NVMe-CLI issue on Ubuntu 18.04 Kernel

NVMe-CLI issue on Ubuntu 18.04 Kernel

[Jeffrey Lien]

We are seeing the following error message when executing the "nvme list" command on Ubuntu 18.04 with the 4.15.0 kernel:
root@lmt-store-17:~/.src/nvme-cli-old# nvme list
Failed to open /sys/class/nvme-subsystem/nvme-subsys0/nvme0/address: No such file or directory

It does not seem to effect the completion of the command; it's just extra noise back from the command.  I'm not sure why the address is not present with the 4.15.0 kernel, but also not sure what it's used for by the nvme cli code.  It's referenced in the scan_ctrl function in nvme-topology.c part but I don't think it's used by any other functions.   Is it ok to just remove the reference to the address attribute in the the nvme cli code?  Or is there a better fix for this issue?

Jeff Lien
Linux Device Driver Development
Device Host Apps and Drivers
jeff.lien@wdc.com
o: 507-322-2416 (ext. 23-2416)
m: 507-273-9124







_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: NVMe-CLI issue on Ubuntu 18.04 Kernel

[Keith Busch]

On Tue, Mar 31, 2020 at 02:21:01PM +0000, Jeffrey Lien wrote:
> We are seeing the following error message when executing the "nvme list" command on Ubuntu 18.04 with the 4.15.0 kernel:
> root@lmt-store-17:~/.src/nvme-cli-old# nvme list
> Failed to open /sys/class/nvme-subsystem/nvme-subsys0/nvme0/address: No such file or directory
> 
> It does not seem to effect the completion of the command; it's just extra noise back from the command.  I'm not sure why the address is not present with the 4.15.0 kernel, but also not sure what it's used for by the nvme cli code.  It's referenced in the scan_ctrl function in nvme-topology.c part but I don't think it's used by any other functions.   Is it ok to just remove the reference to the address attribute in the the nvme cli code?  Or is there a better fix for this issue?

I think we should suppress the output in this case. We don't need the
'address' attribute, though it's nice to have.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

RE: NVMe-CLI issue on Ubuntu 18.04 Kernel

[Jeffrey Lien]

Sounds good Keith.   We'll make the change to the nvme cli code and submit a pull req.  


Jeff Lien

-----Original Message-----
From: Keith Busch <kbusch@kernel.org> 
Sent: Tuesday, March 31, 2020 9:33 AM
To: Jeffrey Lien <Jeff.Lien@wdc.com>
Cc: linux-nvme <linux-nvme@lists.infradead.org>; Randy Bates <randall.bates@wdc.com>; Kenneth Burgener <Kenneth.Burgener@wdc.com>
Subject: Re: NVMe-CLI issue on Ubuntu 18.04 Kernel

CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.


On Tue, Mar 31, 2020 at 02:21:01PM +0000, Jeffrey Lien wrote:
> We are seeing the following error message when executing the "nvme list" command on Ubuntu 18.04 with the 4.15.0 kernel:
> root@lmt-store-17:~/.src/nvme-cli-old# nvme list Failed to open 
> /sys/class/nvme-subsystem/nvme-subsys0/nvme0/address: No such file or 
> directory
>
> It does not seem to effect the completion of the command; it's just extra noise back from the command.  I'm not sure why the address is not present with the 4.15.0 kernel, but also not sure what it's used for by the nvme cli code.  It's referenced in the scan_ctrl function in nvme-topology.c part but I don't think it's used by any other functions.   Is it ok to just remove the reference to the address attribute in the the nvme cli code?  Or is there a better fix for this issue?

I think we should suppress the output in this case. We don't need the 'address' attribute, though it's nice to have.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme