From: "Moore, Robert" <robert.moore@intel.com> To: Paul Menzel <pmenzel@molgen.mpg.de>, "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>, Len Brown <lenb@kernel.org> Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "devel@acpica.org" <devel@acpica.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Date: Thu, 24 Feb 2022 16:19:52 +0000 [thread overview] Message-ID: <BYAPR11MB32563DC0413B8595D1339B37873D9@BYAPR11MB3256.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220224113807.91771-3-pmenzel@molgen.mpg.de> So, this is the current implementation: /* * For compatibility with other ACPI implementations and to prevent * accidental deep sleeps, limit the sleep time to something reasonable. */ if (HowLong > ACPI_MAX_SLEEP) { HowLong = ACPI_MAX_SLEEP; } AcpiOsSleep (HowLong); Where ACPI_MAX_SLEEP is: #define ACPI_MAX_SLEEP 2000 /* 2000 millisec == two seconds */ -----Original Message----- From: Paul Menzel <pmenzel@molgen.mpg.de> Sent: Thursday, February 24, 2022 3:38 AM To: Moore, Robert <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len Brown <lenb@kernel.org> Cc: Paul Menzel <pmenzel@molgen.mpg.de>; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org Subject: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Quick boottime is important, so warn about sleeps greater than 50 ms in ACPI. 50 ms is still long compared to distribution Linux kernels reaching initrd in 350 ms, so should probably changed to 10 ms, so people are aware about this. Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> --- drivers/acpi/acpica/exsystem.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c index 00f66af31ffa..bdffb8aac05c 100644 --- a/drivers/acpi/acpica/exsystem.c +++ b/drivers/acpi/acpica/exsystem.c @@ -167,6 +167,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms) acpi_ex_exit_interpreter(); + if (how_long_ms > 50) { + ACPI_WARNING((AE_INFO, + "Time parameter %llu > 50 ms. Please contact firmware vendor for more responsive system.", how_long_ms)); + } + /* * For compatibility with other ACPI implementations and to prevent * accidental deep sleeps, limit the sleep time to something reasonable. -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Moore, Robert <robert.moore at intel.com> To: devel@acpica.org Subject: [Devel] Re: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Date: Thu, 24 Feb 2022 16:19:52 +0000 [thread overview] Message-ID: <BYAPR11MB32563DC0413B8595D1339B37873D9@BYAPR11MB3256.namprd11.prod.outlook.com> (raw) In-Reply-To: 20220224113807.91771-3-pmenzel@molgen.mpg.de [-- Attachment #1: Type: text/plain, Size: 1912 bytes --] So, this is the current implementation: /* * For compatibility with other ACPI implementations and to prevent * accidental deep sleeps, limit the sleep time to something reasonable. */ if (HowLong > ACPI_MAX_SLEEP) { HowLong = ACPI_MAX_SLEEP; } AcpiOsSleep (HowLong); Where ACPI_MAX_SLEEP is: #define ACPI_MAX_SLEEP 2000 /* 2000 millisec == two seconds */ -----Original Message----- From: Paul Menzel <pmenzel(a)molgen.mpg.de> Sent: Thursday, February 24, 2022 3:38 AM To: Moore, Robert <robert.moore(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; Len Brown <lenb(a)kernel.org> Cc: Paul Menzel <pmenzel(a)molgen.mpg.de>; linux-acpi(a)vger.kernel.org; devel(a)acpica.org; linux-kernel(a)vger.kernel.org Subject: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Quick boottime is important, so warn about sleeps greater than 50 ms in ACPI. 50 ms is still long compared to distribution Linux kernels reaching initrd in 350 ms, so should probably changed to 10 ms, so people are aware about this. Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- drivers/acpi/acpica/exsystem.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c index 00f66af31ffa..bdffb8aac05c 100644 --- a/drivers/acpi/acpica/exsystem.c +++ b/drivers/acpi/acpica/exsystem.c @@ -167,6 +167,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms) acpi_ex_exit_interpreter(); + if (how_long_ms > 50) { + ACPI_WARNING((AE_INFO, + "Time parameter %llu > 50 ms. Please contact firmware vendor for more responsive system.", how_long_ms)); + } + /* * For compatibility with other ACPI implementations and to prevent * accidental deep sleeps, limit the sleep time to something reasonable. -- 2.35.1
next prev parent reply other threads:[~2022-02-24 16:34 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-24 11:38 [PATCH 1/4] acpi: exsystem: Add units to time variable names Paul Menzel 2022-02-24 11:38 ` [PATCH 2/4] acpi: exsystem: Inform users about ACPI spec violation Paul Menzel 2022-02-24 11:38 ` [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Paul Menzel 2022-02-24 16:19 ` Moore, Robert [this message] 2022-02-24 16:19 ` [Devel] " Moore, Robert 2022-02-25 7:38 ` Paul Menzel 2022-02-25 15:39 ` Rafael J. Wysocki 2022-02-25 15:39 ` [Devel] " Rafael J. Wysocki 2022-02-24 11:38 ` [PATCH 4/4] acpi: exsystem: Decrease sleep warning threshold to 10 ms Paul Menzel 2022-03-01 19:40 ` [PATCH 1/4] acpi: exsystem: Add units to time variable names Rafael J. Wysocki 2022-03-01 19:40 ` [Devel] " Rafael J. Wysocki 2022-03-02 8:06 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR11MB32563DC0413B8595D1339B37873D9@BYAPR11MB3256.namprd11.prod.outlook.com \ --to=robert.moore@intel.com \ --cc=devel@acpica.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmenzel@molgen.mpg.de \ --cc=rafael.j.wysocki@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.