From: "Rafael J. Wysocki" <rafael@kernel.org> To: Paul Menzel <pmenzel@molgen.mpg.de> Cc: Robert Moore <robert.moore@intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Len Brown <lenb@kernel.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@acpica.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/4] acpi: exsystem: Add units to time variable names Date: Tue, 1 Mar 2022 20:40:26 +0100 [thread overview] Message-ID: <CAJZ5v0iCwJ10gM0+LsOMU9X3X4ToN_OHBW=9vVsfEP3+cRpudQ@mail.gmail.com> (raw) In-Reply-To: <20220224113807.91771-1-pmenzel@molgen.mpg.de> On Thu, Feb 24, 2022 at 12:38 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote: > > `how_long` uses different units in both functions, so make it more > clear, what unit they expect. > > Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> > --- > drivers/acpi/acpica/exsystem.c | 20 ++++++++++---------- As ACPICA material, this should be submitted to the upstream project via https://github.com/acpica/acpica/. This applies to the other patches in the series too. > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c > index 1281c07112de..6bc5b46e6927 100644 > --- a/drivers/acpi/acpica/exsystem.c > +++ b/drivers/acpi/acpica/exsystem.c > @@ -107,7 +107,7 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) > * > * FUNCTION: acpi_ex_system_do_stall > * > - * PARAMETERS: how_long - The amount of time to stall, > + * PARAMETERS: how_long_us - The amount of time to stall, > * in microseconds > * > * RETURN: Status > @@ -120,13 +120,13 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) > * > ******************************************************************************/ > > -acpi_status acpi_ex_system_do_stall(u32 how_long) > +acpi_status acpi_ex_system_do_stall(u32 how_long_us) > { > acpi_status status = AE_OK; > > ACPI_FUNCTION_ENTRY(); > > - if (how_long > 255) { /* 255 microseconds */ > + if (how_long_us > 255) { /* 255 microseconds */ > /* > * Longer than 255 usec, this is an error > * > @@ -134,10 +134,10 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * order to support existing BIOSs) > */ > ACPI_ERROR((AE_INFO, > - "Time parameter is too large (%u)", how_long)); > + "Time parameter is too large (%u)", how_long_us)); > status = AE_AML_OPERAND_VALUE; > } else { > - acpi_os_stall(how_long); > + acpi_os_stall(how_long_us); > } > > return (status); > @@ -147,7 +147,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * > * FUNCTION: acpi_ex_system_do_sleep > * > - * PARAMETERS: how_long - The amount of time to sleep, > + * PARAMETERS: how_long_ms - The amount of time to sleep, > * in milliseconds > * > * RETURN: None > @@ -156,7 +156,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * > ******************************************************************************/ > > -acpi_status acpi_ex_system_do_sleep(u64 how_long) > +acpi_status acpi_ex_system_do_sleep(u64 how_long_ms) > { > ACPI_FUNCTION_ENTRY(); > > @@ -168,11 +168,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long) > * For compatibility with other ACPI implementations and to prevent > * accidental deep sleeps, limit the sleep time to something reasonable. > */ > - if (how_long > ACPI_MAX_SLEEP) { > - how_long = ACPI_MAX_SLEEP; > + if (how_long_ms > ACPI_MAX_SLEEP) { > + how_long_ms = ACPI_MAX_SLEEP; > } > > - acpi_os_sleep(how_long); > + acpi_os_sleep(how_long_ms); > > /* And now we must get the interpreter again */ > > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael at kernel.org> To: devel@acpica.org Subject: [Devel] Re: [PATCH 1/4] acpi: exsystem: Add units to time variable names Date: Tue, 01 Mar 2022 20:40:26 +0100 [thread overview] Message-ID: <CAJZ5v0iCwJ10gM0+LsOMU9X3X4ToN_OHBW=9vVsfEP3+cRpudQ@mail.gmail.com> (raw) In-Reply-To: 20220224113807.91771-1-pmenzel@molgen.mpg.de [-- Attachment #1: Type: text/plain, Size: 3572 bytes --] On Thu, Feb 24, 2022 at 12:38 PM Paul Menzel <pmenzel(a)molgen.mpg.de> wrote: > > `how_long` uses different units in both functions, so make it more > clear, what unit they expect. > > Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> > --- > drivers/acpi/acpica/exsystem.c | 20 ++++++++++---------- As ACPICA material, this should be submitted to the upstream project via https://github.com/acpica/acpica/. This applies to the other patches in the series too. > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c > index 1281c07112de..6bc5b46e6927 100644 > --- a/drivers/acpi/acpica/exsystem.c > +++ b/drivers/acpi/acpica/exsystem.c > @@ -107,7 +107,7 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) > * > * FUNCTION: acpi_ex_system_do_stall > * > - * PARAMETERS: how_long - The amount of time to stall, > + * PARAMETERS: how_long_us - The amount of time to stall, > * in microseconds > * > * RETURN: Status > @@ -120,13 +120,13 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) > * > ******************************************************************************/ > > -acpi_status acpi_ex_system_do_stall(u32 how_long) > +acpi_status acpi_ex_system_do_stall(u32 how_long_us) > { > acpi_status status = AE_OK; > > ACPI_FUNCTION_ENTRY(); > > - if (how_long > 255) { /* 255 microseconds */ > + if (how_long_us > 255) { /* 255 microseconds */ > /* > * Longer than 255 usec, this is an error > * > @@ -134,10 +134,10 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * order to support existing BIOSs) > */ > ACPI_ERROR((AE_INFO, > - "Time parameter is too large (%u)", how_long)); > + "Time parameter is too large (%u)", how_long_us)); > status = AE_AML_OPERAND_VALUE; > } else { > - acpi_os_stall(how_long); > + acpi_os_stall(how_long_us); > } > > return (status); > @@ -147,7 +147,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * > * FUNCTION: acpi_ex_system_do_sleep > * > - * PARAMETERS: how_long - The amount of time to sleep, > + * PARAMETERS: how_long_ms - The amount of time to sleep, > * in milliseconds > * > * RETURN: None > @@ -156,7 +156,7 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) > * > ******************************************************************************/ > > -acpi_status acpi_ex_system_do_sleep(u64 how_long) > +acpi_status acpi_ex_system_do_sleep(u64 how_long_ms) > { > ACPI_FUNCTION_ENTRY(); > > @@ -168,11 +168,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long) > * For compatibility with other ACPI implementations and to prevent > * accidental deep sleeps, limit the sleep time to something reasonable. > */ > - if (how_long > ACPI_MAX_SLEEP) { > - how_long = ACPI_MAX_SLEEP; > + if (how_long_ms > ACPI_MAX_SLEEP) { > + how_long_ms = ACPI_MAX_SLEEP; > } > > - acpi_os_sleep(how_long); > + acpi_os_sleep(how_long_ms); > > /* And now we must get the interpreter again */ > > -- > 2.35.1 >
next prev parent reply other threads:[~2022-03-01 19:40 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-24 11:38 [PATCH 1/4] acpi: exsystem: Add units to time variable names Paul Menzel 2022-02-24 11:38 ` [PATCH 2/4] acpi: exsystem: Inform users about ACPI spec violation Paul Menzel 2022-02-24 11:38 ` [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Paul Menzel 2022-02-24 16:19 ` Moore, Robert 2022-02-24 16:19 ` [Devel] " Moore, Robert 2022-02-25 7:38 ` Paul Menzel 2022-02-25 15:39 ` Rafael J. Wysocki 2022-02-25 15:39 ` [Devel] " Rafael J. Wysocki 2022-02-24 11:38 ` [PATCH 4/4] acpi: exsystem: Decrease sleep warning threshold to 10 ms Paul Menzel 2022-03-01 19:40 ` Rafael J. Wysocki [this message] 2022-03-01 19:40 ` [Devel] Re: [PATCH 1/4] acpi: exsystem: Add units to time variable names Rafael J. Wysocki 2022-03-02 8:06 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJZ5v0iCwJ10gM0+LsOMU9X3X4ToN_OHBW=9vVsfEP3+cRpudQ@mail.gmail.com' \ --to=rafael@kernel.org \ --cc=devel@acpica.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmenzel@molgen.mpg.de \ --cc=rafael.j.wysocki@intel.com \ --cc=robert.moore@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.