From: Mathieu Malaterre <malat@debian.org> To: Nicholas Piggin <npiggin@gmail.com> Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-arch@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>, linux-kbuild@vger.kernel.org Subject: Re: [PATCH 4/4] powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected Date: Fri, 20 Apr 2018 12:00:49 +0200 [thread overview] Message-ID: <CA+7wUswuyn+YgNe732rQAzVmgDBohTMEqwsd76nQ_CH5h7Y5WA@mail.gmail.com> (raw) In-Reply-To: <20180420073414.23169-5-npiggin@gmail.com> On Fri, Apr 20, 2018 at 9:34 AM, Nicholas Piggin <npiggin@gmail.com> wrote: > This requires further changes to linker script to KEEP some tables > and wildcard compiler generated sections into the right place. This > includes pp32 modifications from Christophe Leroy. > > When compiling powernv_defconfig with this option: > > text data bss dec filename > 11827621 4810490 1341080 17979191 vmlinux > 11752437 4598858 1338776 17690071 vmlinux.dcde > > Resulting kernel is almost 400kB smaller (and still boots). > > [ppc32 numbers here] ^^^ Do you want somebody else to provide those numbers ? > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > arch/powerpc/Kconfig | 1 + > arch/powerpc/kernel/vmlinux.lds.S | 22 +++++++++++----------- > 2 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index c32a181a7cbb..ee6dbe2efc8b 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -205,6 +205,7 @@ config PPC > select HAVE_KPROBES > select HAVE_KPROBES_ON_FTRACE > select HAVE_KRETPROBES > + select HAVE_LD_DEAD_CODE_DATA_ELIMINATION > select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_REGS > select HAVE_MEMBLOCK > select HAVE_MEMBLOCK_NODE_MAP > diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S > index c8af90ff49f0..89381dc959ce 100644 > --- a/arch/powerpc/kernel/vmlinux.lds.S > +++ b/arch/powerpc/kernel/vmlinux.lds.S > @@ -89,7 +89,7 @@ SECTIONS > */ > .text BLOCK(0) : AT(ADDR(.text) - LOAD_OFFSET) { > #ifdef CONFIG_LD_HEAD_STUB_CATCH > - *(.linker_stub_catch); > + KEEP(*(.linker_stub_catch)); > . = . ; > #endif > > @@ -98,7 +98,7 @@ SECTIONS > ALIGN_FUNCTION(); > #endif > /* careful! __ftr_alt_* sections need to be close to .text */ > - *(.text.hot .text .text.fixup .text.unlikely .fixup __ftr_alt_* .ref.text); > + *(.text.hot .text .text.[0-9a-zA-Z_]* .text.fixup .text.unlikely .fixup __ftr_alt_* .ref.text); > SCHED_TEXT > CPUIDLE_TEXT > LOCK_TEXT > @@ -170,10 +170,10 @@ SECTIONS > .init.data : AT(ADDR(.init.data) - LOAD_OFFSET) { > INIT_DATA > __vtop_table_begin = .; > - *(.vtop_fixup); > + KEEP(*(.vtop_fixup)); > __vtop_table_end = .; > __ptov_table_begin = .; > - *(.ptov_fixup); > + KEEP(*(.ptov_fixup)); > __ptov_table_end = .; > } > > @@ -194,26 +194,26 @@ SECTIONS > . = ALIGN(8); > __ftr_fixup : AT(ADDR(__ftr_fixup) - LOAD_OFFSET) { > __start___ftr_fixup = .; > - *(__ftr_fixup) > + KEEP(*(__ftr_fixup)) > __stop___ftr_fixup = .; > } > . = ALIGN(8); > __mmu_ftr_fixup : AT(ADDR(__mmu_ftr_fixup) - LOAD_OFFSET) { > __start___mmu_ftr_fixup = .; > - *(__mmu_ftr_fixup) > + KEEP(*(__mmu_ftr_fixup)) > __stop___mmu_ftr_fixup = .; > } > . = ALIGN(8); > __lwsync_fixup : AT(ADDR(__lwsync_fixup) - LOAD_OFFSET) { > __start___lwsync_fixup = .; > - *(__lwsync_fixup) > + KEEP(*(__lwsync_fixup)) > __stop___lwsync_fixup = .; > } > #ifdef CONFIG_PPC64 > . = ALIGN(8); > __fw_ftr_fixup : AT(ADDR(__fw_ftr_fixup) - LOAD_OFFSET) { > __start___fw_ftr_fixup = .; > - *(__fw_ftr_fixup) > + KEEP(*(__fw_ftr_fixup)) > __stop___fw_ftr_fixup = .; > } > #endif > @@ -226,7 +226,7 @@ SECTIONS > . = ALIGN(8); > .machine.desc : AT(ADDR(.machine.desc) - LOAD_OFFSET) { > __machine_desc_start = . ; > - *(.machine.desc) > + KEEP(*(.machine.desc)) > __machine_desc_end = . ; > } > #ifdef CONFIG_RELOCATABLE > @@ -274,7 +274,7 @@ SECTIONS > .data : AT(ADDR(.data) - LOAD_OFFSET) { > DATA_DATA > *(.data.rel*) > - *(.sdata) > + *(SDATA_MAIN) > *(.sdata2) > *(.got.plt) *(.got) > *(.plt) > @@ -289,7 +289,7 @@ SECTIONS > > .opd : AT(ADDR(.opd) - LOAD_OFFSET) { > __start_opd = .; > - *(.opd) > + KEEP(*(.opd)) > __end_opd = .; > } > > -- > 2.17.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Malaterre <malat@debian.org> To: Nicholas Piggin <npiggin@gmail.com> Cc: linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, Nicolas Pitre <nico@fluxnic.net> Subject: Re: [PATCH 4/4] powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected Date: Fri, 20 Apr 2018 12:00:49 +0200 [thread overview] Message-ID: <CA+7wUswuyn+YgNe732rQAzVmgDBohTMEqwsd76nQ_CH5h7Y5WA@mail.gmail.com> (raw) In-Reply-To: <20180420073414.23169-5-npiggin@gmail.com> On Fri, Apr 20, 2018 at 9:34 AM, Nicholas Piggin <npiggin@gmail.com> wrote: > This requires further changes to linker script to KEEP some tables > and wildcard compiler generated sections into the right place. This > includes pp32 modifications from Christophe Leroy. > > When compiling powernv_defconfig with this option: > > text data bss dec filename > 11827621 4810490 1341080 17979191 vmlinux > 11752437 4598858 1338776 17690071 vmlinux.dcde > > Resulting kernel is almost 400kB smaller (and still boots). > > [ppc32 numbers here] ^^^ Do you want somebody else to provide those numbers ? > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > arch/powerpc/Kconfig | 1 + > arch/powerpc/kernel/vmlinux.lds.S | 22 +++++++++++----------- > 2 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index c32a181a7cbb..ee6dbe2efc8b 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -205,6 +205,7 @@ config PPC > select HAVE_KPROBES > select HAVE_KPROBES_ON_FTRACE > select HAVE_KRETPROBES > + select HAVE_LD_DEAD_CODE_DATA_ELIMINATION > select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_REGS > select HAVE_MEMBLOCK > select HAVE_MEMBLOCK_NODE_MAP > diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S > index c8af90ff49f0..89381dc959ce 100644 > --- a/arch/powerpc/kernel/vmlinux.lds.S > +++ b/arch/powerpc/kernel/vmlinux.lds.S > @@ -89,7 +89,7 @@ SECTIONS > */ > .text BLOCK(0) : AT(ADDR(.text) - LOAD_OFFSET) { > #ifdef CONFIG_LD_HEAD_STUB_CATCH > - *(.linker_stub_catch); > + KEEP(*(.linker_stub_catch)); > . = . ; > #endif > > @@ -98,7 +98,7 @@ SECTIONS > ALIGN_FUNCTION(); > #endif > /* careful! __ftr_alt_* sections need to be close to .text */ > - *(.text.hot .text .text.fixup .text.unlikely .fixup __ftr_alt_* .ref.text); > + *(.text.hot .text .text.[0-9a-zA-Z_]* .text.fixup .text.unlikely .fixup __ftr_alt_* .ref.text); > SCHED_TEXT > CPUIDLE_TEXT > LOCK_TEXT > @@ -170,10 +170,10 @@ SECTIONS > .init.data : AT(ADDR(.init.data) - LOAD_OFFSET) { > INIT_DATA > __vtop_table_begin = .; > - *(.vtop_fixup); > + KEEP(*(.vtop_fixup)); > __vtop_table_end = .; > __ptov_table_begin = .; > - *(.ptov_fixup); > + KEEP(*(.ptov_fixup)); > __ptov_table_end = .; > } > > @@ -194,26 +194,26 @@ SECTIONS > . = ALIGN(8); > __ftr_fixup : AT(ADDR(__ftr_fixup) - LOAD_OFFSET) { > __start___ftr_fixup = .; > - *(__ftr_fixup) > + KEEP(*(__ftr_fixup)) > __stop___ftr_fixup = .; > } > . = ALIGN(8); > __mmu_ftr_fixup : AT(ADDR(__mmu_ftr_fixup) - LOAD_OFFSET) { > __start___mmu_ftr_fixup = .; > - *(__mmu_ftr_fixup) > + KEEP(*(__mmu_ftr_fixup)) > __stop___mmu_ftr_fixup = .; > } > . = ALIGN(8); > __lwsync_fixup : AT(ADDR(__lwsync_fixup) - LOAD_OFFSET) { > __start___lwsync_fixup = .; > - *(__lwsync_fixup) > + KEEP(*(__lwsync_fixup)) > __stop___lwsync_fixup = .; > } > #ifdef CONFIG_PPC64 > . = ALIGN(8); > __fw_ftr_fixup : AT(ADDR(__fw_ftr_fixup) - LOAD_OFFSET) { > __start___fw_ftr_fixup = .; > - *(__fw_ftr_fixup) > + KEEP(*(__fw_ftr_fixup)) > __stop___fw_ftr_fixup = .; > } > #endif > @@ -226,7 +226,7 @@ SECTIONS > . = ALIGN(8); > .machine.desc : AT(ADDR(.machine.desc) - LOAD_OFFSET) { > __machine_desc_start = . ; > - *(.machine.desc) > + KEEP(*(.machine.desc)) > __machine_desc_end = . ; > } > #ifdef CONFIG_RELOCATABLE > @@ -274,7 +274,7 @@ SECTIONS > .data : AT(ADDR(.data) - LOAD_OFFSET) { > DATA_DATA > *(.data.rel*) > - *(.sdata) > + *(SDATA_MAIN) > *(.sdata2) > *(.got.plt) *(.got) > *(.plt) > @@ -289,7 +289,7 @@ SECTIONS > > .opd : AT(ADDR(.opd) - LOAD_OFFSET) { > __start_opd = .; > - *(.opd) > + KEEP(*(.opd)) > __end_opd = .; > } > > -- > 2.17.0 >
next prev parent reply other threads:[~2018-04-20 10:01 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 7:34 [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc Nicholas Piggin 2018-04-20 7:34 ` Nicholas Piggin 2018-04-20 7:34 ` [PATCH 1/4] kbuild: Fix asm-generic/vmlinux.lds.h for LD_DEAD_CODE_DATA_ELIMINATION Nicholas Piggin 2018-04-20 7:34 ` Nicholas Piggin 2018-04-20 7:34 ` [PATCH 2/4] kbuild: LD_DEAD_CODE_DATA_ELIMINATION no -ffunction-sections/-fdata-sections for module build Nicholas Piggin 2018-04-20 7:34 ` Nicholas Piggin 2018-04-20 7:34 ` [PATCH 3/4] kbuild: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selectable if enabled Nicholas Piggin 2018-04-20 7:34 ` Nicholas Piggin 2018-04-20 7:34 ` [PATCH 4/4] powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected Nicholas Piggin 2018-04-20 7:34 ` Nicholas Piggin 2018-04-20 10:00 ` Mathieu Malaterre [this message] 2018-04-20 10:00 ` Mathieu Malaterre 2018-04-20 10:41 ` Nicholas Piggin 2018-04-20 10:41 ` Nicholas Piggin 2018-04-20 20:08 ` Mathieu Malaterre 2018-04-20 20:08 ` Mathieu Malaterre 2018-04-21 2:48 ` Nicholas Piggin 2018-04-21 2:48 ` Nicholas Piggin 2018-05-02 9:17 ` Mathieu Malaterre 2018-05-02 9:17 ` Mathieu Malaterre 2018-05-02 12:24 ` Nicholas Piggin 2018-05-02 12:24 ` Nicholas Piggin 2018-05-14 19:10 ` Mathieu Malaterre 2018-05-14 19:10 ` Mathieu Malaterre 2018-04-21 7:16 ` christophe leroy 2018-04-21 7:16 ` christophe leroy 2018-04-23 11:01 ` Mathieu Malaterre 2018-04-23 11:01 ` Mathieu Malaterre 2018-04-23 11:01 ` Mathieu Malaterre 2018-05-07 0:46 ` Masahiro Yamada 2018-05-07 0:46 ` Masahiro Yamada 2018-05-07 9:53 ` Nicholas Piggin 2018-05-07 9:53 ` Nicholas Piggin 2018-04-20 10:01 ` Christophe LEROY 2018-04-20 10:01 ` Christophe LEROY 2018-04-20 10:36 ` Nicholas Piggin 2018-04-20 10:36 ` Nicholas Piggin 2018-04-20 13:21 ` Christophe LEROY 2018-04-20 13:21 ` Christophe LEROY 2018-04-20 10:39 ` Christophe LEROY 2018-04-20 10:39 ` Christophe LEROY 2018-04-20 9:59 ` [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc Mathieu Malaterre 2018-04-20 9:59 ` Mathieu Malaterre 2018-04-20 10:02 ` Christophe LEROY 2018-04-20 10:02 ` Christophe LEROY
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+7wUswuyn+YgNe732rQAzVmgDBohTMEqwsd76nQ_CH5h7Y5WA@mail.gmail.com \ --to=malat@debian.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=nico@fluxnic.net \ --cc=npiggin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.