All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Malaterre <malat@debian.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-arch@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
	linux-kbuild@vger.kernel.org,
	Christophe LEROY <christophe.leroy@c-s.fr>
Subject: Re: [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc
Date: Fri, 20 Apr 2018 11:59:56 +0200	[thread overview]
Message-ID: <CA+7wUsz37qQCngaMMo2S6SRa6M-F4u_inyborA7zLf+-oSPMpA@mail.gmail.com> (raw)
In-Reply-To: <20180420073414.23169-1-npiggin@gmail.com>

On Fri, Apr 20, 2018 at 9:34 AM, Nicholas Piggin <npiggin@gmail.com> wrote:
> A few people have been interested in this again. And I promised
> if it remains dead code it should be removed, so I would like to
> have another try.
>
> I think I got snagged on the modules problem last time and did
> not take the time to work it out, this time I just turned off the
> compile options for modules (the linker option was never set anyway
> so no loss).
>
> This includes some linker script catches and ideas from others, I
> didn't documnt them all, but thanks for looking.

This series works for me. v2 from Christophe was triggering a kernel
panic (call stack mentioned set_pte_at...).

So if needed:

Tested-by: Mathieu Malaterre <malat@debian.org>

Env: Mac Mini G4, with custom config.

> I would be interested to help other archs get this working too, if
> anybody needs some help.
>
> Thanks,
> Nick
>
> Nicholas Piggin (4):
>   kbuild: Fix asm-generic/vmlinux.lds.h for
>     LD_DEAD_CODE_DATA_ELIMINATION
>   kbuild: LD_DEAD_CODE_DATA_ELIMINATION no
>     -ffunction-sections/-fdata-sections for module build
>   kbuild: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selectable if
>     enabled
>   powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected
>
>  Makefile                          |  4 +--
>  arch/Kconfig                      | 15 ----------
>  arch/powerpc/Kconfig              |  1 +
>  arch/powerpc/kernel/vmlinux.lds.S | 22 +++++++-------
>  include/asm-generic/vmlinux.lds.h | 49 ++++++++++++++++++-------------
>  init/Kconfig                      | 27 +++++++++++++++++
>  6 files changed, 70 insertions(+), 48 deletions(-)
>
> --
> 2.17.0
>

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Malaterre <malat@debian.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc
Date: Fri, 20 Apr 2018 11:59:56 +0200	[thread overview]
Message-ID: <CA+7wUsz37qQCngaMMo2S6SRa6M-F4u_inyborA7zLf+-oSPMpA@mail.gmail.com> (raw)
In-Reply-To: <20180420073414.23169-1-npiggin@gmail.com>

On Fri, Apr 20, 2018 at 9:34 AM, Nicholas Piggin <npiggin@gmail.com> wrote:
> A few people have been interested in this again. And I promised
> if it remains dead code it should be removed, so I would like to
> have another try.
>
> I think I got snagged on the modules problem last time and did
> not take the time to work it out, this time I just turned off the
> compile options for modules (the linker option was never set anyway
> so no loss).
>
> This includes some linker script catches and ideas from others, I
> didn't documnt them all, but thanks for looking.

This series works for me. v2 from Christophe was triggering a kernel
panic (call stack mentioned set_pte_at...).

So if needed:

Tested-by: Mathieu Malaterre <malat@debian.org>

Env: Mac Mini G4, with custom config.

> I would be interested to help other archs get this working too, if
> anybody needs some help.
>
> Thanks,
> Nick
>
> Nicholas Piggin (4):
>   kbuild: Fix asm-generic/vmlinux.lds.h for
>     LD_DEAD_CODE_DATA_ELIMINATION
>   kbuild: LD_DEAD_CODE_DATA_ELIMINATION no
>     -ffunction-sections/-fdata-sections for module build
>   kbuild: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selectable if
>     enabled
>   powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected
>
>  Makefile                          |  4 +--
>  arch/Kconfig                      | 15 ----------
>  arch/powerpc/Kconfig              |  1 +
>  arch/powerpc/kernel/vmlinux.lds.S | 22 +++++++-------
>  include/asm-generic/vmlinux.lds.h | 49 ++++++++++++++++++-------------
>  init/Kconfig                      | 27 +++++++++++++++++
>  6 files changed, 70 insertions(+), 48 deletions(-)
>
> --
> 2.17.0
>

  parent reply	other threads:[~2018-04-20 10:00 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20  7:34 [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc Nicholas Piggin
2018-04-20  7:34 ` Nicholas Piggin
2018-04-20  7:34 ` [PATCH 1/4] kbuild: Fix asm-generic/vmlinux.lds.h for LD_DEAD_CODE_DATA_ELIMINATION Nicholas Piggin
2018-04-20  7:34   ` Nicholas Piggin
2018-04-20  7:34 ` [PATCH 2/4] kbuild: LD_DEAD_CODE_DATA_ELIMINATION no -ffunction-sections/-fdata-sections for module build Nicholas Piggin
2018-04-20  7:34   ` Nicholas Piggin
2018-04-20  7:34 ` [PATCH 3/4] kbuild: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selectable if enabled Nicholas Piggin
2018-04-20  7:34   ` Nicholas Piggin
2018-04-20  7:34 ` [PATCH 4/4] powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected Nicholas Piggin
2018-04-20  7:34   ` Nicholas Piggin
2018-04-20 10:00   ` Mathieu Malaterre
2018-04-20 10:00     ` Mathieu Malaterre
2018-04-20 10:41     ` Nicholas Piggin
2018-04-20 10:41       ` Nicholas Piggin
2018-04-20 20:08       ` Mathieu Malaterre
2018-04-20 20:08         ` Mathieu Malaterre
2018-04-21  2:48         ` Nicholas Piggin
2018-04-21  2:48           ` Nicholas Piggin
2018-05-02  9:17           ` Mathieu Malaterre
2018-05-02  9:17             ` Mathieu Malaterre
2018-05-02 12:24             ` Nicholas Piggin
2018-05-02 12:24               ` Nicholas Piggin
2018-05-14 19:10               ` Mathieu Malaterre
2018-05-14 19:10                 ` Mathieu Malaterre
2018-04-21  7:16         ` christophe leroy
2018-04-21  7:16           ` christophe leroy
2018-04-23 11:01           ` Mathieu Malaterre
2018-04-23 11:01             ` Mathieu Malaterre
2018-04-23 11:01             ` Mathieu Malaterre
2018-05-07  0:46       ` Masahiro Yamada
2018-05-07  0:46         ` Masahiro Yamada
2018-05-07  9:53         ` Nicholas Piggin
2018-05-07  9:53           ` Nicholas Piggin
2018-04-20 10:01   ` Christophe LEROY
2018-04-20 10:01     ` Christophe LEROY
2018-04-20 10:36     ` Nicholas Piggin
2018-04-20 10:36       ` Nicholas Piggin
2018-04-20 13:21       ` Christophe LEROY
2018-04-20 13:21         ` Christophe LEROY
2018-04-20 10:39   ` Christophe LEROY
2018-04-20 10:39     ` Christophe LEROY
2018-04-20  9:59 ` Mathieu Malaterre [this message]
2018-04-20  9:59   ` [PATCH 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc Mathieu Malaterre
2018-04-20 10:02 ` Christophe LEROY
2018-04-20 10:02   ` Christophe LEROY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+7wUsz37qQCngaMMo2S6SRa6M-F4u_inyborA7zLf+-oSPMpA@mail.gmail.com \
    --to=malat@debian.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nico@fluxnic.net \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.