From: Michal Kazior <michal.kazior@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix htt t2h message conflicts among firmware revisions
Date: Thu, 19 Mar 2015 09:40:39 +0100 [thread overview]
Message-ID: <CA+BoTQmcdiy3u8cvYYRueSoQxGzYf9Suf4dy8HpLG6UaQzJzZQ@mail.gmail.com> (raw)
In-Reply-To: <878uetl7cn.fsf@kamboji.qca.qualcomm.com>
On 19 March 2015 at 09:27, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>
>> Target to host HTT messages are conflicting between 10.x and other
>> firmware revisions. By maintaining separate HTT T2H tables for each
>> firmware revisions (main, 10x and tlv) similar to WMI abstraction,
>> solves the conflicts.
>>
>> Cc: Michal Kazior <michal.kazior@tieto.com>
>> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>
> So this is needed to get managements frames over HTT working, right?
> It's good to mention that in the commit log, does this look ok:
>
> Author: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> Date: Wed Mar 11 15:03:02 2015 +0530
>
> ath10k: fix htt t2h message conflicts among firmware revisions
>
> Target to host HTT messages are conflicting between 10.x and other
> firmware revisions. By maintaining separate HTT T2H tables for each
> firmware revisions (main, 10x and tlv) similar to WMI abstraction,
> solves the conflicts.
>
> This fix is needed to get management frames over HTT (ie.
> ATH10K_FW_FEATURE_HAS_WMI_MGMT_TX disabled) working with 10.2.4.48-2 firmware.
> Otherwise there will be unknown htt events and nothing works:
>
> [30087.438343] ath10k_pci 0000:02:00.0: htt event (19) not handled
> [30087.448691] ath10k_pci 0000:02:00.0: htt event (19) not handled
> [30149.032974] ath10k_pci 0000:02:00.0: htt event (19) not handled
[...]
>
> When I was adding WMI_OP_VERSION, my idea was that we will add similar
> version for HTT as well once we need it. But I guess this is good enough
> for now, we can add HTT_OP_VERSION later if more changes are needed.
Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID
or something else?
It's not like HTT wasn't diverging. It was. However only WMI ABI was
seeing major breakage that needed taking care of. HTT changes were
small enough and could be ignored until now.
Perhaps the rename could be accompanied by FW API bump to 5?
Michał
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: fix htt t2h message conflicts among firmware revisions
Date: Thu, 19 Mar 2015 09:40:39 +0100 [thread overview]
Message-ID: <CA+BoTQmcdiy3u8cvYYRueSoQxGzYf9Suf4dy8HpLG6UaQzJzZQ@mail.gmail.com> (raw)
In-Reply-To: <878uetl7cn.fsf@kamboji.qca.qualcomm.com>
On 19 March 2015 at 09:27, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>
>> Target to host HTT messages are conflicting between 10.x and other
>> firmware revisions. By maintaining separate HTT T2H tables for each
>> firmware revisions (main, 10x and tlv) similar to WMI abstraction,
>> solves the conflicts.
>>
>> Cc: Michal Kazior <michal.kazior@tieto.com>
>> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>
> So this is needed to get managements frames over HTT working, right?
> It's good to mention that in the commit log, does this look ok:
>
> Author: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> Date: Wed Mar 11 15:03:02 2015 +0530
>
> ath10k: fix htt t2h message conflicts among firmware revisions
>
> Target to host HTT messages are conflicting between 10.x and other
> firmware revisions. By maintaining separate HTT T2H tables for each
> firmware revisions (main, 10x and tlv) similar to WMI abstraction,
> solves the conflicts.
>
> This fix is needed to get management frames over HTT (ie.
> ATH10K_FW_FEATURE_HAS_WMI_MGMT_TX disabled) working with 10.2.4.48-2 firmware.
> Otherwise there will be unknown htt events and nothing works:
>
> [30087.438343] ath10k_pci 0000:02:00.0: htt event (19) not handled
> [30087.448691] ath10k_pci 0000:02:00.0: htt event (19) not handled
> [30149.032974] ath10k_pci 0000:02:00.0: htt event (19) not handled
[...]
>
> When I was adding WMI_OP_VERSION, my idea was that we will add similar
> version for HTT as well once we need it. But I guess this is good enough
> for now, we can add HTT_OP_VERSION later if more changes are needed.
Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID
or something else?
It's not like HTT wasn't diverging. It was. However only WMI ABI was
seeing major breakage that needed taking care of. HTT changes were
small enough and could be ignored until now.
Perhaps the rename could be accompanied by FW API bump to 5?
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-03-19 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:33 [PATCH] ath10k: fix htt t2h message conflicts among firmware revisions Rajkumar Manoharan
2015-03-11 9:33 ` Rajkumar Manoharan
2015-03-19 8:27 ` Kalle Valo
2015-03-19 8:27 ` Kalle Valo
2015-03-19 8:40 ` Michal Kazior [this message]
2015-03-19 8:40 ` Michal Kazior
2015-03-19 9:32 ` Kalle Valo
2015-03-19 9:32 ` Kalle Valo
2015-03-19 10:14 ` Michal Kazior
2015-03-19 10:14 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+BoTQmcdiy3u8cvYYRueSoQxGzYf9Suf4dy8HpLG6UaQzJzZQ@mail.gmail.com \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.