Re: [PATCH 06/16] iommu/dma: use page allocation function provided by iommu-pages.h

From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: akpm@linux-foundation.org, alex.williamson@redhat.com,
	 alim.akhtar@samsung.com, alyssa@rosenzweig.io,
	asahi@lists.linux.dev,  baolu.lu@linux.intel.com,
	bhelgaas@google.com, cgroups@vger.kernel.org,  corbet@lwn.net,
	david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org,
	 heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com,
	 jernej.skrabec@gmail.com, jgg@ziepe.ca, jonathanh@nvidia.com,
	joro@8bytes.org,  kevin.tian@intel.com,
	krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mm@kvack.org, linux-rockchip@lists.infradead.org,
	 linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
	 linux-tegra@vger.kernel.org, lizefan.x@bytedance.com,
	marcan@marcan.st,  mhiramat@kernel.org, mst@redhat.com,
	m.szyprowski@samsung.com,  netdev@vger.kernel.org,
	paulmck@kernel.org, rdunlap@infradead.org,  samuel@sholland.org,
	suravee.suthikulpanit@amd.com, sven@svenpeter.dev,
	 thierry.reding@gmail.com, tj@kernel.org,
	tomas.mudrunka@gmail.com,  vdumpa@nvidia.com,
	virtualization@lists.linux.dev, wens@csie.org,  will@kernel.org,
	yu-cheng.yu@intel.com
Subject: Re: [PATCH 06/16] iommu/dma: use page allocation function provided by iommu-pages.h
Date: Tue, 28 Nov 2023 18:08:11 -0500	[thread overview]
Message-ID: <CA+CK2bDZUHSLWB=ec6Jdjbi+y6fD8=j96bK-kPHYKc1uiVLZWw@mail.gmail.com> (raw)
In-Reply-To: <79c397ee-b71b-470e-9184-401b4b96a0d2@arm.com>

> > This is true, however, we want to account and observe the pages
> > allocated by IOMMU subsystem for DMA buffers, as they are essentially
> > unmovable locked pages. Should we separate IOMMU memory from KVM
> > memory all together and add another field to /proc/meminfo, something
> > like "iommu -> iommu pagetable and dma memory", or do we want to
> > export DMA memory separately from IOMMU page tables?
>
> These are not allocated by "the IOMMU subsystem", they are allocated by
> the DMA API. Even if you want to claim that a driver pinning memory via
> iommu_dma_ops is somehow different from the same driver pinning the same
> amount of memory via dma-direct when iommu.passthrough=1, it's still
> nonsense because you're failing to account the pages which iommu_dma_ops
> gets from CMA, dma_common_alloc_pages(), dynamic SWIOTLB, the various
> pools, and so on.

I see, IOMMU variants are used only for discontiguous allocations, and
the common ones are defined outside of driver/iommu. Alright, I can
remove all the changes for all no-page table related IOMMU
allocations.

Pasha