From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> To: Tonghao Zhang <xiangxia.m.yue@gmail.com> Cc: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, virtualization@lists.linux-foundation.org, Network Development <netdev@vger.kernel.org> Subject: Re: [PATCH net v2] virtio-net: don't disable guest csum when disable LRO Date: Tue, 29 Sep 2020 10:38:59 +0200 [thread overview] Message-ID: <CA+FuTSdJ78xSTQJeLOuarSm5sR_MJZ3MFjiA9V6SiMJy81E5dg@mail.gmail.com> (raw) In-Reply-To: <CAMDZJNW=hEEcsJy1gUEwrnERRgH3kRBkEuDtcPwPdfXr91eTGg@mail.gmail.com> On Tue, Sep 29, 2020 at 9:56 AM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote: > > On Tue, Sep 29, 2020 at 3:32 PM Willem de Bruijn > <willemdebruijn.kernel@gmail.com> wrote: > > > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue@gmail.com> wrote: > > > > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > when this interface added to them. Now when disable the LRO, the > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > I had focused on the code previously. > > > > The s/w checksum verification cost is significant in a VM with traffic > > to local destinations. A bridge does not verify transport layer > > checksums OTOH? > Hi Willem. > No, think about GRO(In the GRO we don't know packets will be forwarded > to other ports or to local). I had expected a pure bridging setup that disables LRO to disable GRO as well. But if not, then, indeed, the checksum needs to be verified before coalescing. Makes sense. > The call tree as below: > + 5.41% secondary_startup_64 > - 1.22% ret_from_fork > .... > net_rx_action > napi_poll > virtnet_poll > virtnet_receive > napi_gro_receive > dev_gro_receive > inet_gro_receive > tcp4_gro_receive > __skb_gro_checksum_complete > skb_checksum > __skb_checksum > csum_partial > do_csum > - 1.13% do_csum > > $ brctl show > bridge name bridge id STP enabled interfaces > br0 8000.001122330001 no eth1 > eth2
WARNING: multiple messages have this Message-ID (diff)
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> To: Tonghao Zhang <xiangxia.m.yue@gmail.com> Cc: Network Development <netdev@vger.kernel.org>, virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" <mst@redhat.com> Subject: Re: [PATCH net v2] virtio-net: don't disable guest csum when disable LRO Date: Tue, 29 Sep 2020 10:38:59 +0200 [thread overview] Message-ID: <CA+FuTSdJ78xSTQJeLOuarSm5sR_MJZ3MFjiA9V6SiMJy81E5dg@mail.gmail.com> (raw) In-Reply-To: <CAMDZJNW=hEEcsJy1gUEwrnERRgH3kRBkEuDtcPwPdfXr91eTGg@mail.gmail.com> On Tue, Sep 29, 2020 at 9:56 AM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote: > > On Tue, Sep 29, 2020 at 3:32 PM Willem de Bruijn > <willemdebruijn.kernel@gmail.com> wrote: > > > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue@gmail.com> wrote: > > > > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > when this interface added to them. Now when disable the LRO, the > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > I had focused on the code previously. > > > > The s/w checksum verification cost is significant in a VM with traffic > > to local destinations. A bridge does not verify transport layer > > checksums OTOH? > Hi Willem. > No, think about GRO(In the GRO we don't know packets will be forwarded > to other ports or to local). I had expected a pure bridging setup that disables LRO to disable GRO as well. But if not, then, indeed, the checksum needs to be verified before coalescing. Makes sense. > The call tree as below: > + 5.41% secondary_startup_64 > - 1.22% ret_from_fork > .... > net_rx_action > napi_poll > virtnet_poll > virtnet_receive > napi_gro_receive > dev_gro_receive > inet_gro_receive > tcp4_gro_receive > __skb_gro_checksum_complete > skb_checksum > __skb_checksum > csum_partial > do_csum > - 1.13% do_csum > > $ brctl show > bridge name bridge id STP enabled interfaces > br0 8000.001122330001 no eth1 > eth2 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-29 8:39 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 1:58 [PATCH net v2] virtio-net: don't disable guest csum when disable LRO xiangxia.m.yue 2020-09-29 1:58 ` xiangxia.m.yue 2020-09-29 6:23 ` Michael S. Tsirkin 2020-09-29 6:23 ` Michael S. Tsirkin 2020-09-29 6:59 ` Tonghao Zhang 2020-09-29 6:59 ` Tonghao Zhang 2020-09-29 7:21 ` Michael S. Tsirkin 2020-09-29 7:21 ` Michael S. Tsirkin 2020-09-29 7:29 ` Willem de Bruijn 2020-09-29 7:29 ` Willem de Bruijn 2020-09-29 8:04 ` Tonghao Zhang 2020-09-29 8:04 ` Tonghao Zhang 2020-09-29 7:31 ` Willem de Bruijn 2020-09-29 7:31 ` Willem de Bruijn 2020-09-29 7:52 ` Tonghao Zhang 2020-09-29 7:52 ` Tonghao Zhang 2020-09-29 8:38 ` Willem de Bruijn [this message] 2020-09-29 8:38 ` Willem de Bruijn 2020-09-29 8:39 ` Willem de Bruijn 2020-09-29 8:39 ` Willem de Bruijn 2020-09-29 19:54 ` David Miller 2020-09-29 19:54 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+FuTSdJ78xSTQJeLOuarSm5sR_MJZ3MFjiA9V6SiMJy81E5dg@mail.gmail.com \ --to=willemdebruijn.kernel@gmail.com \ --cc=jasowang@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiangxia.m.yue@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.