Re: [PATCH] PCI: dwc: Added link up check in map_bus of dw_child_pcie_ops

From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "Z.Q. Hou" <Zhiqiang.Hou@nxp.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Michael Walle <michael@walle.cc>,
	Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Ard Biesheuvel <ardb@kernel.org>, PCI <linux-pci@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] PCI: dwc: Added link up check in map_bus of dw_child_pcie_ops
Date: Thu, 8 Oct 2020 22:21:24 +0530	[thread overview]
Message-ID: <CA+G9fYufopBTRdqdHy=m17mc2N2Y8o-bcqAz_nON7X6ZYAb7Ug@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+uFJp5Vt=u2ZFhGCTTM62mb_1rKOz_Dj2=ez5bKJad1Q@mail.gmail.com>

On Thu, 8 Oct 2020 at 20:42, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Oct 8, 2020 at 9:47 AM Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Fri, 2 Oct 2020 at 14:59, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > >
> > > On Thu, 1 Oct 2020 at 22:16, Michael Walle <michael@walle.cc> wrote:
> > > >
> > > > Am 2020-10-01 15:32, schrieb Kishon Vijay Abraham I:
> > > >
> > > > > Meanwhile would it be okay to add linkup check atleast for DRA7X so
> > > > > that
> > > > > we could have it booting in linux-next?
> > > >
> > > > Layerscape SoCs (at least the LS1028A) are also still broken in
> > > > linux-next,
> > > > did I miss something here?
> > >
> > > I have been monitoring linux next boot and functional testing on nxp devices
> > > for more than two week and still the problem exists on nxp-ls2088.
> > >
> > > Do you mind checking the possibilities to revert bad patches on linux next tree
> > > and continue to work on fixes please ?
> > >
> > > suspected bad commit: [ I have not bisected this problem ]
> > > c2b0c098fbd1 ("PCI: dwc: Use generic config accessors")
> > >
> > > crash log snippet:
> > > [    1.563008] SError Interrupt on CPU5, code 0xbf000002 -- SError
> > > [    1.563010] CPU: 5 PID: 1 Comm: swapper/0 Not tainted
> > > 5.9.0-rc7-next-20201001 #1
> > > [    1.563011] Hardware name: Freescale Layerscape 2088A RDB Board (DT)
> > > [    1.563013] pstate: 20000085 (nzCv daIf -PAN -UAO -TCO BTYPE=--)
> > > [    1.563014] pc : pci_generic_config_read+0x44/0xe8
> > > [    1.563015] lr : pci_generic_config_read+0x2c/0xe8
> >
> >
> > This reported issue is gone now on Linux next master branch.

I am taking this verdict back.
I have seen the boot pass and the reported issue is gone but after checking
all 20 test jobs the 4 boot passes without the above reported error.
and later the 16 boot failed with the reported error.

> > I am not sure which is a fix commit.
>
> There isn't one, better double check that. We're still waiting on
> respinning of the revert patch.
>
> BTW, why is the kernelci NXP lab almost always down? I have a branch
> now to test things and I'm not done breaking the DWC driver. :)

Now the NXP LAVA lab is back online after upgrade.
LKFT running daily testing on device "nxp-ls2088" [1]

You can monitor and check results on Linaro Linux next project [2]

[1] https://lavalab.nxp.com/scheduler/device_type/nxp-ls2088
[2] https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20201008/?results_layout=table&failures_only=false#!?details=995,999#test-results

- Naresh