All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>,
	Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
	"Z.q. Hou" <zhiqiang.hou@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	PCI <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Michael Walle <michael@walle.cc>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] PCI: dwc: Added link up check in map_bus of dw_child_pcie_ops
Date: Mon, 12 Oct 2020 22:01:23 +0530	[thread overview]
Message-ID: <c8f2abfc-5860-abf4-d157-38756bd09907@ti.com> (raw)
In-Reply-To: <20201008150819.GA3871@e121166-lin.cambridge.arm.com>

Hi Lorenzo,

On 08/10/20 8:38 pm, Lorenzo Pieralisi wrote:
> On Thu, Oct 01, 2020 at 07:02:04PM +0530, Kishon Vijay Abraham I wrote:
> 
> [...]
> 
>>>> Yeah, I don't see any registers in the DRA7x PCIe wrapper for disabling
>>>> error forwarding.
>>>
>>> It's a DWC port logic register AFAICT, but perhaps not present in all versions.
>>
>> Okay. I see there's a register PCIECTRL_PL_AXIS_SLV_ERR_RESP which has a
>> reset value of 0.
>>
>> It has four bit-fields, RESET_TIMEOUT_ERR_MAP, NO_VID_ERR_MAP,
>> DBI_ERR_MAP and SLAVE_ERR_MAP. I'm not seeing any difference in behavior
>> if I set all these bits. Maybe it requires platform support too. I'll
>> check this with our design team.
>>
>> Meanwhile would it be okay to add linkup check atleast for DRA7X so that
>> we could have it booting in linux-next?
> 
> Do you mind sending a patch on top of my pci/dwc please ?

I just tried applying this on your pci/dwc branch and it applied without
any conflicts. Please let me know if you still want me or Hou to resend
the patch.

Thank you,
Kishon

  reply	other threads:[~2020-10-12 16:31 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  5:41 [PATCH] PCI: dwc: Added link up check in map_bus of dw_child_pcie_ops Zhiqiang Hou
2020-09-16 20:28 ` Rob Herring
2020-09-18 11:02   ` Z.q. Hou
2020-09-18 11:14     ` Michael Walle
2020-09-21 14:48       ` Z.q. Hou
2020-09-18 12:47     ` Bjorn Helgaas
2020-09-21 16:31       ` Z.q. Hou
2020-09-18 15:27     ` Rob Herring
2020-09-24  4:24       ` Z.q. Hou
2020-09-28  9:39         ` Lorenzo Pieralisi
2020-09-29  4:05           ` Z.q. Hou
2020-09-29 15:24             ` Gustavo Pimentel
2020-09-29 17:11               ` Rob Herring
2020-09-30 13:22                 ` Kishon Vijay Abraham I
2020-09-30 15:01                   ` Rob Herring
2020-10-01 13:32                     ` Kishon Vijay Abraham I
2020-10-01 16:46                       ` Michael Walle
2020-10-02  9:29                         ` Naresh Kamboju
2020-10-08 14:46                           ` Naresh Kamboju
2020-10-08 15:12                             ` Rob Herring
2020-10-08 16:51                               ` Naresh Kamboju
2020-10-08 15:08                       ` Lorenzo Pieralisi
2020-10-12 16:31                         ` Kishon Vijay Abraham I [this message]
2020-10-12  4:41                       ` Z.q. Hou
2020-10-19 16:13                         ` Lorenzo Pieralisi
2020-10-20  8:07                           ` Kishon Vijay Abraham I
2020-10-12  4:22                 ` Z.q. Hou
2020-10-20  9:48       ` Lorenzo Pieralisi
2020-10-13  9:15 ` Lorenzo Pieralisi
2020-10-14 11:13 ` Lorenzo Pieralisi
2020-10-14 12:37   ` Rob Herring
2020-10-15 22:47 ` Bjorn Helgaas
2020-10-16 11:59   ` Lorenzo Pieralisi
2020-10-19  5:24   ` Z.q. Hou
2020-10-19  5:41     ` Kishon Vijay Abraham I
2020-10-20  2:13       ` Z.q. Hou
2020-10-20  9:12         ` Lorenzo Pieralisi
2020-10-20  9:55         ` Lorenzo Pieralisi
2020-10-21  8:47           ` Z.q. Hou
2020-10-22  6:20             ` Richard Zhu
2020-10-19 16:26   ` Lorenzo Pieralisi
2020-10-20 10:19   ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8f2abfc-5860-abf4-d157-38756bd09907@ti.com \
    --to=kishon@ti.com \
    --cc=Gustavo.Pimentel@synopsys.com \
    --cc=ardb@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=michael@walle.cc \
    --cc=robh@kernel.org \
    --cc=zhiqiang.hou@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.