All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Pittman <jpittman@redhat.com>
To: nborisov@suse.com
Cc: Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] dm flakey: Document "error_writes" feature
Date: Wed, 10 Oct 2018 08:18:40 -0400	[thread overview]
Message-ID: <CA+RJvhz8U=SkvrDGT9GcJL9WP6kEY0-U3wU7DcrkuKnDQNYejg@mail.gmail.com> (raw)
In-Reply-To: <1539073891-7701-1-git-send-email-nborisov@suse.com>

Hi Nikolay, I sent this one to Mike at the end of September.("dm
flakey: add error_writes to documentation -
"https://www.redhat.com/archives/dm-devel/2018-September/msg00146.html).
Unsure if he has picked it up or not.

Best Regards,

John Pittman
Customer Engagement and Experience
Red Hat Inc.

On Wed, Oct 10, 2018 at 4:20 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  Documentation/device-mapper/dm-flakey.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
> index c43030718cef..9f0e247d0877 100644
> --- a/Documentation/device-mapper/dm-flakey.txt
> +++ b/Documentation/device-mapper/dm-flakey.txt
> @@ -33,6 +33,10 @@ Table parameters
>         All write I/O is silently ignored.
>         Read I/O is handled correctly.
>
> +  error_writes:
> +       All write I/O is failed with an error signalled.
> +       Read I/O is handled correctly.
> +
>    corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
>         During <down interval>, replace <Nth_byte> of the data of
>         each matching bio with <value>.
> --
> 2.7.4
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

WARNING: multiple messages have this Message-ID (diff)
From: John Pittman <jpittman@redhat.com>
To: nborisov@suse.com
Cc: dm-devel@redhat.com, linux-doc@vger.kernel.org,
	Mike Snitzer <snitzer@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] dm flakey: Document "error_writes" feature
Date: Wed, 10 Oct 2018 08:18:40 -0400	[thread overview]
Message-ID: <CA+RJvhz8U=SkvrDGT9GcJL9WP6kEY0-U3wU7DcrkuKnDQNYejg@mail.gmail.com> (raw)
In-Reply-To: <1539073891-7701-1-git-send-email-nborisov@suse.com>

Hi Nikolay, I sent this one to Mike at the end of September.("dm
flakey: add error_writes to documentation -
"https://www.redhat.com/archives/dm-devel/2018-September/msg00146.html).
Unsure if he has picked it up or not.

Best Regards,

John Pittman
Customer Engagement and Experience
Red Hat Inc.

On Wed, Oct 10, 2018 at 4:20 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  Documentation/device-mapper/dm-flakey.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
> index c43030718cef..9f0e247d0877 100644
> --- a/Documentation/device-mapper/dm-flakey.txt
> +++ b/Documentation/device-mapper/dm-flakey.txt
> @@ -33,6 +33,10 @@ Table parameters
>         All write I/O is silently ignored.
>         Read I/O is handled correctly.
>
> +  error_writes:
> +       All write I/O is failed with an error signalled.
> +       Read I/O is handled correctly.
> +
>    corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
>         During <down interval>, replace <Nth_byte> of the data of
>         each matching bio with <value>.
> --
> 2.7.4
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2018-10-10 12:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  8:31 [PATCH] dm flakey: Document "error_writes" feature Nikolay Borisov
2018-10-09  8:31 ` Nikolay Borisov
2018-10-10 12:18 ` John Pittman [this message]
2018-10-10 12:18   ` John Pittman
2018-10-12 17:31 ` Jonathan Corbet
2018-10-12 17:31   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+RJvhz8U=SkvrDGT9GcJL9WP6kEY0-U3wU7DcrkuKnDQNYejg@mail.gmail.com' \
    --to=jpittman@redhat.com \
    --cc=corbet@lwn.net \
    --cc=dm-devel@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.