All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dm flakey: Document "error_writes" feature
@ 2018-10-09  8:31 ` Nikolay Borisov
  0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Borisov @ 2018-10-09  8:31 UTC (permalink / raw)
  To: snitzer; +Cc: linux-doc, dm-devel, corbet, Nikolay Borisov

Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
added the ability to dm flakey to error out writes in contrast to
silently dropping it with 'drop_writes'. Unfortunately this feature
is not currently documented and one has to be either familiar with the
source code of dm flakey or check out xfstests sources to know of
this parameter. So document it.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 Documentation/device-mapper/dm-flakey.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
index c43030718cef..9f0e247d0877 100644
--- a/Documentation/device-mapper/dm-flakey.txt
+++ b/Documentation/device-mapper/dm-flakey.txt
@@ -33,6 +33,10 @@ Table parameters
 	All write I/O is silently ignored.
 	Read I/O is handled correctly.
 
+  error_writes:
+	All write I/O is failed with an error signalled.
+	Read I/O is handled correctly.
+
   corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
 	During <down interval>, replace <Nth_byte> of the data of
 	each matching bio with <value>.
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] dm flakey: Document "error_writes" feature
@ 2018-10-09  8:31 ` Nikolay Borisov
  0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Borisov @ 2018-10-09  8:31 UTC (permalink / raw)
  To: snitzer; +Cc: Nikolay Borisov, dm-devel, corbet, linux-doc

Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
added the ability to dm flakey to error out writes in contrast to
silently dropping it with 'drop_writes'. Unfortunately this feature
is not currently documented and one has to be either familiar with the
source code of dm flakey or check out xfstests sources to know of
this parameter. So document it.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 Documentation/device-mapper/dm-flakey.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
index c43030718cef..9f0e247d0877 100644
--- a/Documentation/device-mapper/dm-flakey.txt
+++ b/Documentation/device-mapper/dm-flakey.txt
@@ -33,6 +33,10 @@ Table parameters
 	All write I/O is silently ignored.
 	Read I/O is handled correctly.
 
+  error_writes:
+	All write I/O is failed with an error signalled.
+	Read I/O is handled correctly.
+
   corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
 	During <down interval>, replace <Nth_byte> of the data of
 	each matching bio with <value>.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [dm-devel] [PATCH] dm flakey: Document "error_writes" feature
  2018-10-09  8:31 ` Nikolay Borisov
@ 2018-10-10 12:18   ` John Pittman
  -1 siblings, 0 replies; 6+ messages in thread
From: John Pittman @ 2018-10-10 12:18 UTC (permalink / raw)
  To: nborisov; +Cc: Mike Snitzer, dm-devel, Jonathan Corbet, linux-doc

Hi Nikolay, I sent this one to Mike at the end of September.("dm
flakey: add error_writes to documentation -
"https://www.redhat.com/archives/dm-devel/2018-September/msg00146.html).
Unsure if he has picked it up or not.

Best Regards,

John Pittman
Customer Engagement and Experience
Red Hat Inc.

On Wed, Oct 10, 2018 at 4:20 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  Documentation/device-mapper/dm-flakey.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
> index c43030718cef..9f0e247d0877 100644
> --- a/Documentation/device-mapper/dm-flakey.txt
> +++ b/Documentation/device-mapper/dm-flakey.txt
> @@ -33,6 +33,10 @@ Table parameters
>         All write I/O is silently ignored.
>         Read I/O is handled correctly.
>
> +  error_writes:
> +       All write I/O is failed with an error signalled.
> +       Read I/O is handled correctly.
> +
>    corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
>         During <down interval>, replace <Nth_byte> of the data of
>         each matching bio with <value>.
> --
> 2.7.4
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dm flakey: Document "error_writes" feature
@ 2018-10-10 12:18   ` John Pittman
  0 siblings, 0 replies; 6+ messages in thread
From: John Pittman @ 2018-10-10 12:18 UTC (permalink / raw)
  To: nborisov; +Cc: dm-devel, linux-doc, Mike Snitzer, Jonathan Corbet

Hi Nikolay, I sent this one to Mike at the end of September.("dm
flakey: add error_writes to documentation -
"https://www.redhat.com/archives/dm-devel/2018-September/msg00146.html).
Unsure if he has picked it up or not.

Best Regards,

John Pittman
Customer Engagement and Experience
Red Hat Inc.

On Wed, Oct 10, 2018 at 4:20 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  Documentation/device-mapper/dm-flakey.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
> index c43030718cef..9f0e247d0877 100644
> --- a/Documentation/device-mapper/dm-flakey.txt
> +++ b/Documentation/device-mapper/dm-flakey.txt
> @@ -33,6 +33,10 @@ Table parameters
>         All write I/O is silently ignored.
>         Read I/O is handled correctly.
>
> +  error_writes:
> +       All write I/O is failed with an error signalled.
> +       Read I/O is handled correctly.
> +
>    corrupt_bio_byte <Nth_byte> <direction> <value> <flags>:
>         During <down interval>, replace <Nth_byte> of the data of
>         each matching bio with <value>.
> --
> 2.7.4
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dm flakey: Document "error_writes" feature
  2018-10-09  8:31 ` Nikolay Borisov
@ 2018-10-12 17:31   ` Jonathan Corbet
  -1 siblings, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2018-10-12 17:31 UTC (permalink / raw)
  To: Nikolay Borisov; +Cc: snitzer, linux-doc, dm-devel

On Tue,  9 Oct 2018 11:31:31 +0300
Nikolay Borisov <nborisov@suse.com> wrote:

> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Applied to the docs tree, thanks.

jon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dm flakey: Document "error_writes" feature
@ 2018-10-12 17:31   ` Jonathan Corbet
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2018-10-12 17:31 UTC (permalink / raw)
  To: Nikolay Borisov; +Cc: dm-devel, snitzer, linux-doc

On Tue,  9 Oct 2018 11:31:31 +0300
Nikolay Borisov <nborisov@suse.com> wrote:

> Commit ef548c551e72 ("dm flakey: introduce "error_writes" feature")
> added the ability to dm flakey to error out writes in contrast to
> silently dropping it with 'drop_writes'. Unfortunately this feature
> is not currently documented and one has to be either familiar with the
> source code of dm flakey or check out xfstests sources to know of
> this parameter. So document it.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Applied to the docs tree, thanks.

jon

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-10-12 17:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09  8:31 [PATCH] dm flakey: Document "error_writes" feature Nikolay Borisov
2018-10-09  8:31 ` Nikolay Borisov
2018-10-10 12:18 ` [dm-devel] " John Pittman
2018-10-10 12:18   ` John Pittman
2018-10-12 17:31 ` Jonathan Corbet
2018-10-12 17:31   ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.