* [PATCH] coresight: syscfg: fix compiler warnings
@ 2021-08-25 22:25 ` Jian Cai
0 siblings, 0 replies; 10+ messages in thread
From: Jian Cai @ 2021-08-25 22:25 UTC (permalink / raw)
Cc: mike.leach, dianders, mka, linux, manojgupta, llozano, coresight,
linux-arm-kernel, clang-built-linux, Jian Cai, Mathieu Poirier,
Suzuki K Poulose, Leo Yan, Alexander Shishkin, linux-kernel
This fixes warnings with -Wimplicit-function-declaration, e.g.
^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
^[[0;1;32m ^
Signed-off-by: Jian Cai <jiancai@google.com>
---
drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
index fc0760f55c53..43054568430f 100644
--- a/drivers/hwtracing/coresight/coresight-syscfg.c
+++ b/drivers/hwtracing/coresight/coresight-syscfg.c
@@ -5,6 +5,7 @@
*/
#include <linux/platform_device.h>
+#include <linux/slab.h>
#include "coresight-config.h"
#include "coresight-etm-perf.h"
--
2.33.0.259.gc128427fd7-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread[parent not found: <CA+SOCLLyKaEmCSrSNUKfpgPmUxcu8RyZLqZxpmw87BiO=m84Mg@mail.gmail.com>]
* Re: [PATCH] coresight: syscfg: fix compiler warnings
[not found] ` <CA+SOCLLyKaEmCSrSNUKfpgPmUxcu8RyZLqZxpmw87BiO=m84Mg@mail.gmail.com>
@ 2021-08-25 22:33 ` Jian Cai
0 siblings, 0 replies; 10+ messages in thread
From: Jian Cai @ 2021-08-25 22:33 UTC (permalink / raw)
Cc: mike.leach, dianders, mka, Guenter Roeck, Manoj Gupta,
Luis Lozano, coresight, Linux ARM, clang-built-linux,
Mathieu Poirier, Suzuki K Poulose, Leo Yan, Alexander Shishkin,
Linux Kernel Mailing List
The last message was meant for the wrong patch. Please ignore. Sorry
for the noise.
On Wed, Aug 25, 2021 at 3:27 PM Jian Cai <jiancai@google.com> wrote:
>
> Please ignore this patch. The title is incorrect, I've updated and resented it at https://lore.kernel.org/lkml/20210825222514.2107728-1-jiancai@google.com/. Sorry for any inconvenience.
>
> On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>>
>> This fixes warnings with -Wimplicit-function-declaration, e.g.
>>
>> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
>> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
>> ^[[0;1;32m ^
>>
>> Signed-off-by: Jian Cai <jiancai@google.com>
>> ---
>> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
>> index fc0760f55c53..43054568430f 100644
>> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
>> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
>> @@ -5,6 +5,7 @@
>> */
>>
>> #include <linux/platform_device.h>
>> +#include <linux/slab.h>
>>
>> #include "coresight-config.h"
>> #include "coresight-etm-perf.h"
>> --
>> 2.33.0.259.gc128427fd7-goog
>>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] coresight: syscfg: fix compiler warnings
@ 2021-08-25 22:33 ` Jian Cai
0 siblings, 0 replies; 10+ messages in thread
From: Jian Cai @ 2021-08-25 22:33 UTC (permalink / raw)
Cc: mike.leach, dianders, mka, Guenter Roeck, Manoj Gupta,
Luis Lozano, coresight, Linux ARM, clang-built-linux,
Mathieu Poirier, Suzuki K Poulose, Leo Yan, Alexander Shishkin,
Linux Kernel Mailing List
The last message was meant for the wrong patch. Please ignore. Sorry
for the noise.
On Wed, Aug 25, 2021 at 3:27 PM Jian Cai <jiancai@google.com> wrote:
>
> Please ignore this patch. The title is incorrect, I've updated and resented it at https://lore.kernel.org/lkml/20210825222514.2107728-1-jiancai@google.com/. Sorry for any inconvenience.
>
> On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>>
>> This fixes warnings with -Wimplicit-function-declaration, e.g.
>>
>> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
>> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
>> ^[[0;1;32m ^
>>
>> Signed-off-by: Jian Cai <jiancai@google.com>
>> ---
>> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
>> index fc0760f55c53..43054568430f 100644
>> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
>> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
>> @@ -5,6 +5,7 @@
>> */
>>
>> #include <linux/platform_device.h>
>> +#include <linux/slab.h>
>>
>> #include "coresight-config.h"
>> #include "coresight-etm-perf.h"
>> --
>> 2.33.0.259.gc128427fd7-goog
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coresight: syscfg: fix compiler warnings
2021-08-25 22:25 ` Jian Cai
@ 2021-08-26 15:49 ` Guenter Roeck
-1 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-08-26 15:49 UTC (permalink / raw)
To: Jian Cai
Cc: mike.leach, dianders, mka, manojgupta, llozano, coresight,
linux-arm-kernel, clang-built-linux, Mathieu Poirier,
Suzuki K Poulose, Leo Yan, Alexander Shishkin, linux-kernel
On Wed, Aug 25, 2021 at 03:25:14PM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
> ^[[0;1;32m ^
You might want to split this into multiple lines and remove the ANSI
escape codes. Otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "coresight-config.h"
> #include "coresight-etm-perf.h"
> --
> 2.33.0.259.gc128427fd7-goog
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coresight: syscfg: fix compiler warnings
@ 2021-08-26 15:49 ` Guenter Roeck
0 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-08-26 15:49 UTC (permalink / raw)
To: Jian Cai
Cc: mike.leach, dianders, mka, manojgupta, llozano, coresight,
linux-arm-kernel, clang-built-linux, Mathieu Poirier,
Suzuki K Poulose, Leo Yan, Alexander Shishkin, linux-kernel
On Wed, Aug 25, 2021 at 03:25:14PM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
> ^[[0;1;32m ^
You might want to split this into multiple lines and remove the ANSI
escape codes. Otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "coresight-config.h"
> #include "coresight-etm-perf.h"
> --
> 2.33.0.259.gc128427fd7-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coresight: syscfg: fix compiler warnings
2021-08-25 22:25 ` Jian Cai
@ 2021-08-26 16:19 ` Doug Anderson
-1 siblings, 0 replies; 10+ messages in thread
From: Doug Anderson @ 2021-08-26 16:19 UTC (permalink / raw)
To: Jian Cai
Cc: Mike Leach, Matthias Kaehlcke, Guenter Roeck, Manoj Gupta,
Luis Lozano, coresight, Linux ARM, clang-built-linux,
Mathieu Poirier, Suzuki K Poulose, Leo Yan, Alexander Shishkin,
LKML
Hi,
On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
> ^[[0;1;32m ^
>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
Can you figure out which patch introduced these warnings and add a "Fixes" tag?
-Doug
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coresight: syscfg: fix compiler warnings
@ 2021-08-26 16:19 ` Doug Anderson
0 siblings, 0 replies; 10+ messages in thread
From: Doug Anderson @ 2021-08-26 16:19 UTC (permalink / raw)
To: Jian Cai
Cc: Mike Leach, Matthias Kaehlcke, Guenter Roeck, Manoj Gupta,
Luis Lozano, coresight, Linux ARM, clang-built-linux,
Mathieu Poirier, Suzuki K Poulose, Leo Yan, Alexander Shishkin,
LKML
Hi,
On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
> ^[[0;1;32m ^
>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
Can you figure out which patch introduced these warnings and add a "Fixes" tag?
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coresight: syscfg: fix compiler warnings
2021-08-26 16:19 ` Doug Anderson
@ 2021-08-26 16:30 ` Guenter Roeck
-1 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-08-26 16:30 UTC (permalink / raw)
To: Doug Anderson, Jian Cai
Cc: Mike Leach, Matthias Kaehlcke, Manoj Gupta, Luis Lozano,
coresight, Linux ARM, clang-built-linux, Mathieu Poirier,
Suzuki K Poulose, Leo Yan, Alexander Shishkin, LKML
On 8/26/21 9:19 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>>
>> This fixes warnings with -Wimplicit-function-declaration, e.g.
>>
>> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
>> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
>> ^[[0;1;32m ^
>>
>> Signed-off-by: Jian Cai <jiancai@google.com>
>> ---
>> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Can you figure out which patch introduced these warnings and add a "Fixes" tag?
>
Assuming the SHA is stable, that would be commit 85e2414c518a
("coresight: syscfg: Initial coresight system configuration")
Guenter
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] coresight: syscfg: fix compiler warnings
@ 2021-08-26 16:30 ` Guenter Roeck
0 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-08-26 16:30 UTC (permalink / raw)
To: Doug Anderson, Jian Cai
Cc: Mike Leach, Matthias Kaehlcke, Manoj Gupta, Luis Lozano,
coresight, Linux ARM, clang-built-linux, Mathieu Poirier,
Suzuki K Poulose, Leo Yan, Alexander Shishkin, LKML
On 8/26/21 9:19 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote:
>>
>> This fixes warnings with -Wimplicit-function-declaration, e.g.
>>
>> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
>> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
>> ^[[0;1;32m ^
>>
>> Signed-off-by: Jian Cai <jiancai@google.com>
>> ---
>> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Can you figure out which patch introduced these warnings and add a "Fixes" tag?
>
Assuming the SHA is stable, that would be commit 85e2414c518a
("coresight: syscfg: Initial coresight system configuration")
Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread