From: Alexandru Ardelean <ardeleanalex@gmail.com> To: Paul Cercueil <paul@crapouillou.net> Cc: "Jonathan Cameron" <jic23@kernel.org>, "Lars-Peter Clausen" <lars@metafoo.de>, "Michael Hennerich" <Michael.Hennerich@analog.com>, "Sumit Semwal" <sumit.semwal@linaro.org>, "Christian König" <christian.koenig@amd.com>, linux-iio <linux-iio@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 13/15] iio: core: Add support for cyclic buffers Date: Tue, 16 Nov 2021 11:50:03 +0200 [thread overview] Message-ID: <CA+U=DsoJWgifThUwcQ61M6851H7JVKH2s_O3=JJ0CsPeX8wdoA@mail.gmail.com> (raw) In-Reply-To: <20211115142243.60605-2-paul@crapouillou.net> On Mon, Nov 15, 2021 at 4:22 PM Paul Cercueil <paul@crapouillou.net> wrote: > > Introduce a new flag IIO_BUFFER_DMABUF_CYCLIC in the "flags" field of > the iio_dmabuf uapi structure. > > When set, the DMABUF enqueued with the enqueue ioctl will be endlessly > repeated on the TX output, until the buffer is disabled. > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/iio/industrialio-buffer.c | 5 +++++ > include/uapi/linux/iio/buffer.h | 3 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index 30910e6c2346..41bc51c88002 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -1600,6 +1600,11 @@ static int iio_buffer_enqueue_dmabuf(struct iio_buffer *buffer, > if (dmabuf.flags & ~IIO_BUFFER_DMABUF_SUPPORTED_FLAGS) > return -EINVAL; > > + /* Cyclic flag is only supported on output buffers */ > + if ((dmabuf.flags & IIO_BUFFER_DMABUF_CYCLIC) && > + buffer->direction != IIO_BUFFER_DIRECTION_OUT) > + return -EINVAL; > + > return buffer->access->enqueue_dmabuf(buffer, &dmabuf); > } > > diff --git a/include/uapi/linux/iio/buffer.h b/include/uapi/linux/iio/buffer.h > index e4621b926262..2d541d038c02 100644 > --- a/include/uapi/linux/iio/buffer.h > +++ b/include/uapi/linux/iio/buffer.h > @@ -7,7 +7,8 @@ > > #include <linux/types.h> > > -#define IIO_BUFFER_DMABUF_SUPPORTED_FLAGS 0x00000000 > +#define IIO_BUFFER_DMABUF_CYCLIC (1 << 0) > +#define IIO_BUFFER_DMABUF_SUPPORTED_FLAGS 0x00000001 > > /** > * struct iio_dmabuf_alloc_req - Descriptor for allocating IIO DMABUFs > -- > 2.33.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <ardeleanalex@gmail.com> To: Paul Cercueil <paul@crapouillou.net> Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>, linux-iio <linux-iio@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, "Christian König" <christian.koenig@amd.com>, "Jonathan Cameron" <jic23@kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH 13/15] iio: core: Add support for cyclic buffers Date: Tue, 16 Nov 2021 11:50:03 +0200 [thread overview] Message-ID: <CA+U=DsoJWgifThUwcQ61M6851H7JVKH2s_O3=JJ0CsPeX8wdoA@mail.gmail.com> (raw) In-Reply-To: <20211115142243.60605-2-paul@crapouillou.net> On Mon, Nov 15, 2021 at 4:22 PM Paul Cercueil <paul@crapouillou.net> wrote: > > Introduce a new flag IIO_BUFFER_DMABUF_CYCLIC in the "flags" field of > the iio_dmabuf uapi structure. > > When set, the DMABUF enqueued with the enqueue ioctl will be endlessly > repeated on the TX output, until the buffer is disabled. > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/iio/industrialio-buffer.c | 5 +++++ > include/uapi/linux/iio/buffer.h | 3 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index 30910e6c2346..41bc51c88002 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -1600,6 +1600,11 @@ static int iio_buffer_enqueue_dmabuf(struct iio_buffer *buffer, > if (dmabuf.flags & ~IIO_BUFFER_DMABUF_SUPPORTED_FLAGS) > return -EINVAL; > > + /* Cyclic flag is only supported on output buffers */ > + if ((dmabuf.flags & IIO_BUFFER_DMABUF_CYCLIC) && > + buffer->direction != IIO_BUFFER_DIRECTION_OUT) > + return -EINVAL; > + > return buffer->access->enqueue_dmabuf(buffer, &dmabuf); > } > > diff --git a/include/uapi/linux/iio/buffer.h b/include/uapi/linux/iio/buffer.h > index e4621b926262..2d541d038c02 100644 > --- a/include/uapi/linux/iio/buffer.h > +++ b/include/uapi/linux/iio/buffer.h > @@ -7,7 +7,8 @@ > > #include <linux/types.h> > > -#define IIO_BUFFER_DMABUF_SUPPORTED_FLAGS 0x00000000 > +#define IIO_BUFFER_DMABUF_CYCLIC (1 << 0) > +#define IIO_BUFFER_DMABUF_SUPPORTED_FLAGS 0x00000001 > > /** > * struct iio_dmabuf_alloc_req - Descriptor for allocating IIO DMABUFs > -- > 2.33.0 >
next prev parent reply other threads:[~2021-11-16 9:52 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-15 14:19 [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-15 14:19 ` [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:23 ` Alexandru Ardelean 2021-11-16 8:23 ` Alexandru Ardelean 2021-11-21 14:05 ` Jonathan Cameron 2021-11-21 14:05 ` Jonathan Cameron 2021-11-21 16:23 ` Lars-Peter Clausen 2021-11-21 16:23 ` Lars-Peter Clausen 2021-11-21 17:52 ` Paul Cercueil 2021-11-21 17:52 ` Paul Cercueil 2021-11-21 18:49 ` Lars-Peter Clausen 2021-11-21 18:49 ` Lars-Peter Clausen 2021-11-21 20:08 ` Paul Cercueil 2021-11-21 20:08 ` Paul Cercueil 2021-11-22 15:08 ` Lars-Peter Clausen 2021-11-22 15:08 ` Lars-Peter Clausen 2021-11-22 15:16 ` Paul Cercueil 2021-11-22 15:16 ` Paul Cercueil 2021-11-22 15:17 ` Lars-Peter Clausen 2021-11-22 15:17 ` Lars-Peter Clausen 2021-11-22 15:27 ` Paul Cercueil 2021-11-22 15:27 ` Paul Cercueil 2021-11-15 14:19 ` [PATCH 02/15] iio: buffer-dma: Remove unused iio_buffer_block struct Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:22 ` Alexandru Ardelean 2021-11-16 8:22 ` Alexandru Ardelean 2021-11-15 14:19 ` [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown() Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:26 ` Alexandru Ardelean 2021-11-16 8:26 ` Alexandru Ardelean 2021-11-21 14:08 ` Jonathan Cameron 2021-11-21 14:08 ` Jonathan Cameron 2021-11-22 10:00 ` Paul Cercueil 2021-11-22 10:00 ` Paul Cercueil 2021-11-27 15:15 ` Jonathan Cameron 2021-11-27 15:15 ` Jonathan Cameron 2021-11-15 14:19 ` [PATCH 04/15] iio: buffer-dma: Enable buffer write support Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:52 ` Alexandru Ardelean 2021-11-16 8:52 ` Alexandru Ardelean 2021-11-21 14:20 ` Jonathan Cameron 2021-11-21 14:20 ` Jonathan Cameron 2021-11-21 17:19 ` Paul Cercueil 2021-11-21 17:19 ` Paul Cercueil 2021-11-27 15:17 ` Jonathan Cameron 2021-11-27 15:17 ` Jonathan Cameron 2021-11-15 14:19 ` [PATCH 05/15] iio: buffer-dmaengine: Support specifying buffer direction Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:53 ` Alexandru Ardelean 2021-11-16 8:53 ` Alexandru Ardelean 2021-11-15 14:19 ` [PATCH 06/15] iio: buffer-dmaengine: Enable write support Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 8:55 ` Alexandru Ardelean 2021-11-16 8:55 ` Alexandru Ardelean 2021-11-15 14:19 ` [PATCH 07/15] iio: core: Add new DMABUF interface infrastructure Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-21 14:31 ` Jonathan Cameron 2021-11-21 14:31 ` Jonathan Cameron 2021-11-15 14:19 ` [PATCH 08/15] iio: buffer-dma: split iio_dma_buffer_fileio_free() function Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-16 10:59 ` Alexandru Ardelean 2021-11-16 10:59 ` Alexandru Ardelean 2021-11-21 13:49 ` Jonathan Cameron 2021-11-21 13:49 ` Jonathan Cameron 2021-11-15 14:19 ` [PATCH 09/15] iio: buffer-dma: Use DMABUFs instead of custom solution Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-15 14:19 ` [PATCH 10/15] iio: buffer-dma: Implement new DMABUF based userspace API Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-15 14:19 ` [PATCH 11/15] iio: buffer-dma: Boost performance using write-combine cache setting Paul Cercueil 2021-11-15 14:19 ` Paul Cercueil 2021-11-18 11:45 ` Paul Cercueil 2021-11-18 11:45 ` Paul Cercueil 2021-11-21 15:00 ` Jonathan Cameron 2021-11-21 15:00 ` Jonathan Cameron 2021-11-21 17:43 ` Paul Cercueil 2021-11-21 17:43 ` Paul Cercueil 2021-11-25 17:29 ` Paul Cercueil 2021-11-25 17:29 ` Paul Cercueil 2021-11-27 16:05 ` Jonathan Cameron 2021-11-27 16:05 ` Jonathan Cameron 2021-11-28 13:25 ` Lars-Peter Clausen 2021-11-28 13:25 ` Lars-Peter Clausen 2021-11-27 15:20 ` Jonathan Cameron 2021-11-27 15:20 ` Jonathan Cameron 2021-11-15 14:22 ` [PATCH 12/15] iio: buffer-dmaengine: Support new DMABUF based userspace API Paul Cercueil 2021-11-15 14:22 ` Paul Cercueil 2021-11-15 14:22 ` [PATCH 13/15] iio: core: Add support for cyclic buffers Paul Cercueil 2021-11-15 14:22 ` Paul Cercueil 2021-11-16 9:50 ` Alexandru Ardelean [this message] 2021-11-16 9:50 ` Alexandru Ardelean 2021-11-15 14:22 ` [PATCH 14/15] iio: buffer-dmaengine: " Paul Cercueil 2021-11-15 14:22 ` Paul Cercueil 2021-11-16 9:50 ` Alexandru Ardelean 2021-11-16 9:50 ` Alexandru Ardelean 2021-11-15 14:22 ` [PATCH 15/15] Documentation: iio: Document high-speed DMABUF based API Paul Cercueil 2021-11-15 14:22 ` Paul Cercueil 2021-11-21 15:10 ` Jonathan Cameron 2021-11-21 15:10 ` Jonathan Cameron 2021-11-21 17:46 ` Paul Cercueil 2021-11-21 17:46 ` Paul Cercueil 2021-11-15 14:37 ` [PATCH 00/15] iio: buffer-dma: write() and new " Daniel Vetter 2021-11-15 14:37 ` Daniel Vetter 2021-11-15 14:57 ` Paul Cercueil 2021-11-15 14:57 ` Paul Cercueil 2021-11-16 16:02 ` Daniel Vetter 2021-11-16 16:02 ` Daniel Vetter 2021-11-16 16:31 ` Laurent Pinchart 2021-11-16 16:31 ` Laurent Pinchart 2021-11-17 8:48 ` Christian König 2021-11-17 8:48 ` Christian König 2021-11-17 12:50 ` Paul Cercueil 2021-11-17 12:50 ` Paul Cercueil 2021-11-17 13:42 ` Hennerich, Michael 2021-11-17 13:42 ` Hennerich, Michael 2021-11-21 13:57 ` Jonathan Cameron 2021-11-21 13:57 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+U=DsoJWgifThUwcQ61M6851H7JVKH2s_O3=JJ0CsPeX8wdoA@mail.gmail.com' \ --to=ardeleanalex@gmail.com \ --cc=Michael.Hennerich@analog.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=paul@crapouillou.net \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.