From: Prabhakar Lad <prabhakar.csengg@gmail.com> To: Anatolij Gustschin <agust@denx.de> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>, linux-media@vger.kernel.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Sakari Ailus <sakari.ailus@iki.fi>, Prabhakar Lad <prabhakar.lad@ti.com> Subject: Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers Date: Thu, 21 Mar 2013 09:25:11 +0000 [thread overview] Message-ID: <CA+V-a8tMkphQGwOVnqEv11h+FfC+=-W=ewFCYpwg8OD-gNyFbw@mail.gmail.com> (raw) In-Reply-To: <20130321101059.03e9f811@crub> Anatolij, On Thu, Mar 21, 2013 at 2:40 PM, Anatolij Gustschin <agust@denx.de> wrote: > On Thu, 21 Mar 2013 13:49:50 +0530 > Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > ... >> > drivers/media/v4l2-core/Makefile | 2 +- >> > drivers/media/v4l2-core/v4l2-clk.c | 184 ++++++++++++++++++++++++++++++++++++ >> > include/media/v4l2-clk.h | 55 +++++++++++ >> > 3 files changed, 240 insertions(+), 1 deletions(-) >> > create mode 100644 drivers/media/v4l2-core/v4l2-clk.c >> > create mode 100644 include/media/v4l2-clk.h >> > >> While trying out this patch I got following error (using 3.9-rc3):- >> >> drivers/media/v4l2-core/v4l2-clk.c: In function 'v4l2_clk_register': >> drivers/media/v4l2-core/v4l2-clk.c:134:2: error: implicit declaration >> of function 'kzalloc' >> drivers/media/v4l2-core/v4l2-clk.c:134:6: warning: assignment makes >> pointer from integer without a cast >> drivers/media/v4l2-core/v4l2-clk.c:162:2: error: implicit declaration >> of function 'kfree' >> make[3]: *** [drivers/media/v4l2-core/v4l2-clk.o] Error 1 >> make[2]: *** [drivers/media/v4l2-core] Error 2 > > please try adding > > #include <linux/slab.h> > > in the affected file. > Thanks for pointing it :), I have already fixed it. Just wanted to point Guennadi so that he could fix it in his next version. Cheers, --Prabhakar > Thanks, > > Anatolij
WARNING: multiple messages have this Message-ID (diff)
From: Prabhakar Lad <prabhakar.csengg@gmail.com> To: Anatolij Gustschin <agust@denx.de> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>, linux-media@vger.kernel.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Sakari Ailus <sakari.ailus@iki.fi>, Prabhakar Lad <prabhakar.lad@ti.com> Subject: Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers Date: Thu, 21 Mar 2013 14:43:11 +0530 [thread overview] Message-ID: <CA+V-a8tMkphQGwOVnqEv11h+FfC+=-W=ewFCYpwg8OD-gNyFbw@mail.gmail.com> (raw) In-Reply-To: <20130321101059.03e9f811@crub> Anatolij, On Thu, Mar 21, 2013 at 2:40 PM, Anatolij Gustschin <agust@denx.de> wrote: > On Thu, 21 Mar 2013 13:49:50 +0530 > Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > ... >> > drivers/media/v4l2-core/Makefile | 2 +- >> > drivers/media/v4l2-core/v4l2-clk.c | 184 ++++++++++++++++++++++++++++++++++++ >> > include/media/v4l2-clk.h | 55 +++++++++++ >> > 3 files changed, 240 insertions(+), 1 deletions(-) >> > create mode 100644 drivers/media/v4l2-core/v4l2-clk.c >> > create mode 100644 include/media/v4l2-clk.h >> > >> While trying out this patch I got following error (using 3.9-rc3):- >> >> drivers/media/v4l2-core/v4l2-clk.c: In function 'v4l2_clk_register': >> drivers/media/v4l2-core/v4l2-clk.c:134:2: error: implicit declaration >> of function 'kzalloc' >> drivers/media/v4l2-core/v4l2-clk.c:134:6: warning: assignment makes >> pointer from integer without a cast >> drivers/media/v4l2-core/v4l2-clk.c:162:2: error: implicit declaration >> of function 'kfree' >> make[3]: *** [drivers/media/v4l2-core/v4l2-clk.o] Error 1 >> make[2]: *** [drivers/media/v4l2-core] Error 2 > > please try adding > > #include <linux/slab.h> > > in the affected file. > Thanks for pointing it :), I have already fixed it. Just wanted to point Guennadi so that he could fix it in his next version. Cheers, --Prabhakar > Thanks, > > Anatolij
next prev parent reply other threads:[~2013-03-21 9:25 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-15 21:27 [PATCH v6 0/7] V4L2 clock and async patches and soc-camera example Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-15 21:27 ` [PATCH v6 1/7] media: V4L2: add temporary clock helpers Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-18 22:21 ` Sylwester Nawrocki 2013-03-18 22:21 ` Sylwester Nawrocki 2013-03-19 7:32 ` Guennadi Liakhovetski 2013-03-19 7:32 ` Guennadi Liakhovetski 2013-03-19 9:52 ` Sylwester Nawrocki 2013-03-19 9:52 ` Sylwester Nawrocki 2013-03-19 10:27 ` Guennadi Liakhovetski 2013-03-19 10:27 ` Guennadi Liakhovetski 2013-03-26 23:09 ` Laurent Pinchart 2013-03-26 23:09 ` Laurent Pinchart 2013-03-26 23:08 ` Laurent Pinchart 2013-03-26 23:08 ` Laurent Pinchart 2013-04-08 10:36 ` Guennadi Liakhovetski 2013-04-08 10:36 ` Guennadi Liakhovetski 2013-04-08 15:20 ` Sylwester Nawrocki 2013-04-08 15:20 ` Sylwester Nawrocki 2013-03-21 8:19 ` Prabhakar Lad 2013-03-21 8:31 ` Prabhakar Lad 2013-03-21 9:10 ` Anatolij Gustschin 2013-03-21 9:10 ` Anatolij Gustschin 2013-03-21 9:13 ` Prabhakar Lad [this message] 2013-03-21 9:25 ` Prabhakar Lad 2013-03-15 21:27 ` [PATCH v6 2/7] media: V4L2: support asynchronous subdevice registration Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-26 23:41 ` Laurent Pinchart 2013-03-26 23:41 ` Laurent Pinchart 2013-03-15 21:27 ` [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-18 7:47 ` Hans Verkuil 2013-03-18 7:47 ` Hans Verkuil 2013-03-18 10:08 ` Guennadi Liakhovetski 2013-03-18 10:08 ` Guennadi Liakhovetski 2013-03-18 10:23 ` Hans Verkuil 2013-03-18 10:23 ` Hans Verkuil 2013-03-18 22:48 ` Sylwester Nawrocki 2013-03-18 22:48 ` Sylwester Nawrocki 2013-03-26 23:54 ` Laurent Pinchart 2013-03-26 23:54 ` Laurent Pinchart 2013-04-08 10:53 ` Guennadi Liakhovetski 2013-04-08 10:53 ` Guennadi Liakhovetski 2013-03-15 21:27 ` [PATCH v6 4/7] soc-camera: add V4L2-async support Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-15 21:27 ` [PATCH v6 5/7] sh_mobile_ceu_camera: add asynchronous subdevice probing support Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-15 21:27 ` [PATCH v6 6/7] imx074: support asynchronous probing Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-15 21:27 ` [PATCH v6 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices Guennadi Liakhovetski 2013-03-15 21:27 ` Guennadi Liakhovetski 2013-03-19 3:36 ` Simon Horman 2013-03-19 3:36 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+V-a8tMkphQGwOVnqEv11h+FfC+=-W=ewFCYpwg8OD-gNyFbw@mail.gmail.com' \ --to=prabhakar.csengg@gmail.com \ --cc=agust@denx.de \ --cc=g.liakhovetski@gmx.de \ --cc=hverkuil@xs4all.nl \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=prabhakar.lad@ti.com \ --cc=s.nawrocki@samsung.com \ --cc=sakari.ailus@iki.fi \ --cc=sylvester.nawrocki@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.