From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH 2/7] drm: rcar-du: Add r8a7742 support Date: Sun, 9 Aug 2020 21:38:05 +0100 [thread overview] Message-ID: <CA+V-a8ts72UAUbtcN6TTDwcHqFEF3HipLx=dkQxFCXTLLzgfXA@mail.gmail.com> (raw) In-Reply-To: <20200808210219.GN6186@pendragon.ideasonboard.com> Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:02 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > > Add direct support for the r8a7742 (RZ/G1H). > > > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > > (R-Car H2) so that device info structure is reused, the only difference > > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > index 3e67cf70f040..7e286c7a7a6c 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > > .channels_mask = BIT(2) | BIT(1) | BIT(0), > > .routes = { > > /* > > - * R8A7790 has one RGB output, two LVDS outputs and one > > - * (currently unsupported) TCON output. > > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > > + * R8A7790 supports one TCON output (currently unsupported by the driver). > > Once we support TCON we'll have to split this, but for now I suppose > it's fine. Would you however mind wrapping this to 80 columns ? I can do > so when applying if it's fine with you. > Agreed once TCON is added this has to be split. But isn't the column size has been increased (checkpatch too doesn't complain about), but feel free to wrapp it for 80 columns. Cheers, Prabhakar > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > */ > > [RCAR_DU_OUTPUT_DPAD0] = { > > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > > }; > > > > static const struct of_device_id rcar_du_of_table[] = { > > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > > -- > Regards, > > Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Magnus Damm <magnus.damm@gmail.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, dri-devel@lists.freedesktop.org, LKML <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH 2/7] drm: rcar-du: Add r8a7742 support Date: Sun, 9 Aug 2020 21:38:05 +0100 [thread overview] Message-ID: <CA+V-a8ts72UAUbtcN6TTDwcHqFEF3HipLx=dkQxFCXTLLzgfXA@mail.gmail.com> (raw) In-Reply-To: <20200808210219.GN6186@pendragon.ideasonboard.com> Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:02 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > > Add direct support for the r8a7742 (RZ/G1H). > > > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > > (R-Car H2) so that device info structure is reused, the only difference > > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > index 3e67cf70f040..7e286c7a7a6c 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > > .channels_mask = BIT(2) | BIT(1) | BIT(0), > > .routes = { > > /* > > - * R8A7790 has one RGB output, two LVDS outputs and one > > - * (currently unsupported) TCON output. > > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > > + * R8A7790 supports one TCON output (currently unsupported by the driver). > > Once we support TCON we'll have to split this, but for now I suppose > it's fine. Would you however mind wrapping this to 80 columns ? I can do > so when applying if it's fine with you. > Agreed once TCON is added this has to be split. But isn't the column size has been increased (checkpatch too doesn't complain about), but feel free to wrapp it for 80 columns. Cheers, Prabhakar > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > */ > > [RCAR_DU_OUTPUT_DPAD0] = { > > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > > }; > > > > static const struct of_device_id rcar_du_of_table[] = { > > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > > -- > Regards, > > Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-09 20:38 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-07 17:49 [PATCH 0/7] r8a7742: Enable DU and LVDS Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-07 17:49 ` [PATCH 1/7] dt-bindings: display: renesas,du: Document the r8a7742 bindings Lad Prabhakar 2020-08-07 17:49 ` [PATCH 1/7] dt-bindings: display: renesas, du: " Lad Prabhakar 2020-08-08 20:59 ` [PATCH 1/7] dt-bindings: display: renesas,du: " Laurent Pinchart 2020-08-08 20:59 ` Laurent Pinchart 2020-08-24 22:20 ` [PATCH 1/7] dt-bindings: display: renesas, du: " Rob Herring 2020-08-24 22:20 ` Rob Herring 2020-08-07 17:49 ` [PATCH 2/7] drm: rcar-du: Add r8a7742 support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:02 ` Laurent Pinchart 2020-08-08 21:02 ` Laurent Pinchart 2020-08-09 20:38 ` Lad, Prabhakar [this message] 2020-08-09 20:38 ` Lad, Prabhakar 2020-08-09 23:03 ` Laurent Pinchart 2020-08-09 23:03 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: Document r8a7742 bindings Lad Prabhakar 2020-08-07 17:49 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Lad Prabhakar 2020-08-08 21:03 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Laurent Pinchart 2020-08-08 21:03 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Laurent Pinchart 2020-08-08 21:05 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Laurent Pinchart 2020-08-08 21:05 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Laurent Pinchart 2020-08-09 21:10 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Lad, Prabhakar 2020-08-09 21:10 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Lad, Prabhakar 2020-08-24 22:20 ` Rob Herring 2020-08-24 22:20 ` Rob Herring 2020-08-07 17:49 ` [PATCH 4/7] drm: rcar-du: lvds: Add r8a7742 support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:06 ` Laurent Pinchart 2020-08-08 21:06 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 5/7] ARM: dts: r8a7742: Add DU support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-07 19:48 ` Sergei Shtylyov 2020-08-07 19:48 ` Sergei Shtylyov 2020-08-07 20:22 ` Lad, Prabhakar 2020-08-07 20:22 ` Lad, Prabhakar 2020-08-10 8:53 ` Geert Uytterhoeven 2020-08-10 8:53 ` Geert Uytterhoeven 2020-08-08 21:15 ` Laurent Pinchart 2020-08-08 21:15 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:13 ` Laurent Pinchart 2020-08-08 21:13 ` Laurent Pinchart 2020-08-09 21:29 ` Lad, Prabhakar 2020-08-09 21:29 ` Lad, Prabhakar 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-07 17:49 ` [PATCH 7/7] ARM: dts: r8a7742-iwg21d-q7: Add LCD support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:22 ` Laurent Pinchart 2020-08-08 21:22 ` Laurent Pinchart 2020-08-09 21:35 ` Lad, Prabhakar 2020-08-09 21:35 ` Lad, Prabhakar 2020-08-11 11:26 ` Laurent Pinchart 2020-08-11 11:26 ` Laurent Pinchart 2020-08-13 12:54 ` Lad, Prabhakar 2020-08-13 12:54 ` Lad, Prabhakar 2020-08-08 20:55 ` [PATCH 0/7] r8a7742: Enable DU and LVDS Laurent Pinchart 2020-08-08 20:55 ` Laurent Pinchart 2020-08-09 21:43 ` Lad, Prabhakar 2020-08-09 21:43 ` Lad, Prabhakar 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-10 8:27 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+V-a8ts72UAUbtcN6TTDwcHqFEF3HipLx=dkQxFCXTLLzgfXA@mail.gmail.com' \ --to=prabhakar.csengg@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.