From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Date: Sun, 9 Aug 2020 22:29:32 +0100 [thread overview] Message-ID: <CA+V-a8v0nXwe0iN2ymqE5YgcgOymWYv-Xf6N+rw_nJnUgx4yMQ@mail.gmail.com> (raw) In-Reply-To: <20200808211323.GR6186@pendragon.ideasonboard.com> Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:13 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:53PM +0100, Lad Prabhakar wrote: > > Add LVDS encoder node to r8a7742 SoC DT. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > arch/arm/boot/dts/r8a7742.dtsi | 54 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi > > index a979a4b3de61..a7e66220d63a 100644 > > --- a/arch/arm/boot/dts/r8a7742.dtsi > > +++ b/arch/arm/boot/dts/r8a7742.dtsi > > @@ -1534,11 +1534,65 @@ > > port@1 { > > reg = <1>; > > du_out_lvds0: endpoint { > > + remote-endpoint = <&lvds0_in>; > > }; > > }; > > port@2 { > > reg = <2>; > > du_out_lvds1: endpoint { > > + remote-endpoint = <&lvds1_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + lvds0: lvds@feb90000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb90000 0 0x1c>; > > Isn't 0x14 enough for the size ? 0x1c won't hurt though. Same comment > below. > Agreed, 0x1c comes from Gen-3 manuals. Cheers, Prabhakar > With or without this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > + clocks = <&cpg CPG_MOD 726>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 726>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds0_in: endpoint { > > + remote-endpoint = <&du_out_lvds0>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds0_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + > > + lvds1: lvds@feb94000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb94000 0 0x1c>; > > + clocks = <&cpg CPG_MOD 725>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 725>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds1_in: endpoint { > > + remote-endpoint = <&du_out_lvds1>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds1_out: endpoint { > > }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Magnus Damm <magnus.damm@gmail.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, dri-devel@lists.freedesktop.org, LKML <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Date: Sun, 9 Aug 2020 22:29:32 +0100 [thread overview] Message-ID: <CA+V-a8v0nXwe0iN2ymqE5YgcgOymWYv-Xf6N+rw_nJnUgx4yMQ@mail.gmail.com> (raw) In-Reply-To: <20200808211323.GR6186@pendragon.ideasonboard.com> Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:13 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:53PM +0100, Lad Prabhakar wrote: > > Add LVDS encoder node to r8a7742 SoC DT. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > arch/arm/boot/dts/r8a7742.dtsi | 54 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi > > index a979a4b3de61..a7e66220d63a 100644 > > --- a/arch/arm/boot/dts/r8a7742.dtsi > > +++ b/arch/arm/boot/dts/r8a7742.dtsi > > @@ -1534,11 +1534,65 @@ > > port@1 { > > reg = <1>; > > du_out_lvds0: endpoint { > > + remote-endpoint = <&lvds0_in>; > > }; > > }; > > port@2 { > > reg = <2>; > > du_out_lvds1: endpoint { > > + remote-endpoint = <&lvds1_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + lvds0: lvds@feb90000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb90000 0 0x1c>; > > Isn't 0x14 enough for the size ? 0x1c won't hurt though. Same comment > below. > Agreed, 0x1c comes from Gen-3 manuals. Cheers, Prabhakar > With or without this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > + clocks = <&cpg CPG_MOD 726>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 726>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds0_in: endpoint { > > + remote-endpoint = <&du_out_lvds0>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds0_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + > > + lvds1: lvds@feb94000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb94000 0 0x1c>; > > + clocks = <&cpg CPG_MOD 725>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 725>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds1_in: endpoint { > > + remote-endpoint = <&du_out_lvds1>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds1_out: endpoint { > > }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-09 21:30 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-07 17:49 [PATCH 0/7] r8a7742: Enable DU and LVDS Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-07 17:49 ` [PATCH 1/7] dt-bindings: display: renesas,du: Document the r8a7742 bindings Lad Prabhakar 2020-08-07 17:49 ` [PATCH 1/7] dt-bindings: display: renesas, du: " Lad Prabhakar 2020-08-08 20:59 ` [PATCH 1/7] dt-bindings: display: renesas,du: " Laurent Pinchart 2020-08-08 20:59 ` Laurent Pinchart 2020-08-24 22:20 ` [PATCH 1/7] dt-bindings: display: renesas, du: " Rob Herring 2020-08-24 22:20 ` Rob Herring 2020-08-07 17:49 ` [PATCH 2/7] drm: rcar-du: Add r8a7742 support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:02 ` Laurent Pinchart 2020-08-08 21:02 ` Laurent Pinchart 2020-08-09 20:38 ` Lad, Prabhakar 2020-08-09 20:38 ` Lad, Prabhakar 2020-08-09 23:03 ` Laurent Pinchart 2020-08-09 23:03 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: Document r8a7742 bindings Lad Prabhakar 2020-08-07 17:49 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Lad Prabhakar 2020-08-08 21:03 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Laurent Pinchart 2020-08-08 21:03 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Laurent Pinchart 2020-08-08 21:05 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Laurent Pinchart 2020-08-08 21:05 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Laurent Pinchart 2020-08-09 21:10 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: " Lad, Prabhakar 2020-08-09 21:10 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Lad, Prabhakar 2020-08-24 22:20 ` Rob Herring 2020-08-24 22:20 ` Rob Herring 2020-08-07 17:49 ` [PATCH 4/7] drm: rcar-du: lvds: Add r8a7742 support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:06 ` Laurent Pinchart 2020-08-08 21:06 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 5/7] ARM: dts: r8a7742: Add DU support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-07 19:48 ` Sergei Shtylyov 2020-08-07 19:48 ` Sergei Shtylyov 2020-08-07 20:22 ` Lad, Prabhakar 2020-08-07 20:22 ` Lad, Prabhakar 2020-08-10 8:53 ` Geert Uytterhoeven 2020-08-10 8:53 ` Geert Uytterhoeven 2020-08-08 21:15 ` Laurent Pinchart 2020-08-08 21:15 ` Laurent Pinchart 2020-08-07 17:49 ` [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:13 ` Laurent Pinchart 2020-08-08 21:13 ` Laurent Pinchart 2020-08-09 21:29 ` Lad, Prabhakar [this message] 2020-08-09 21:29 ` Lad, Prabhakar 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-07 17:49 ` [PATCH 7/7] ARM: dts: r8a7742-iwg21d-q7: Add LCD support Lad Prabhakar 2020-08-07 17:49 ` Lad Prabhakar 2020-08-08 21:22 ` Laurent Pinchart 2020-08-08 21:22 ` Laurent Pinchart 2020-08-09 21:35 ` Lad, Prabhakar 2020-08-09 21:35 ` Lad, Prabhakar 2020-08-11 11:26 ` Laurent Pinchart 2020-08-11 11:26 ` Laurent Pinchart 2020-08-13 12:54 ` Lad, Prabhakar 2020-08-13 12:54 ` Lad, Prabhakar 2020-08-08 20:55 ` [PATCH 0/7] r8a7742: Enable DU and LVDS Laurent Pinchart 2020-08-08 20:55 ` Laurent Pinchart 2020-08-09 21:43 ` Lad, Prabhakar 2020-08-09 21:43 ` Lad, Prabhakar 2020-08-10 8:27 ` Geert Uytterhoeven 2020-08-10 8:27 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+V-a8v0nXwe0iN2ymqE5YgcgOymWYv-Xf6N+rw_nJnUgx4yMQ@mail.gmail.com \ --to=prabhakar.csengg@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.