* [media] i2c: ov2659: signedness bug inov2659_set_fmt()
@ 2015-04-15 19:12 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-04-15 19:12 UTC (permalink / raw)
To: Lad, Prabhakar, Benoit Parrot
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
This needs to be signed or there is a risk of hitting a forever loop.
Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index edebd11..d700a1d 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
struct v4l2_subdev_format *fmt)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
- unsigned int index = ARRAY_SIZE(ov2659_formats);
+ int index = ARRAY_SIZE(ov2659_formats);
struct v4l2_mbus_framefmt *mf = &fmt->format;
const struct ov2659_framesize *size = NULL;
struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [media] i2c: ov2659: signedness bug inov2659_set_fmt()
@ 2015-04-15 19:12 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-04-15 19:12 UTC (permalink / raw)
To: Lad, Prabhakar, Benoit Parrot
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
This needs to be signed or there is a risk of hitting a forever loop.
Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index edebd11..d700a1d 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
struct v4l2_subdev_format *fmt)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
- unsigned int index = ARRAY_SIZE(ov2659_formats);
+ int index = ARRAY_SIZE(ov2659_formats);
struct v4l2_mbus_framefmt *mf = &fmt->format;
const struct ov2659_framesize *size = NULL;
struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
2015-04-15 19:12 ` Dan Carpenter
@ 2015-04-16 10:03 ` Lad, Prabhakar
-1 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2015-04-16 10:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: Benoit Parrot, Mauro Carvalho Chehab, linux-media, kernel-janitors
On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
--Prabhakar Lad
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *fmt)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> - unsigned int index = ARRAY_SIZE(ov2659_formats);
> + int index = ARRAY_SIZE(ov2659_formats);
> struct v4l2_mbus_framefmt *mf = &fmt->format;
> const struct ov2659_framesize *size = NULL;
> struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
@ 2015-04-16 10:03 ` Lad, Prabhakar
0 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2015-04-16 10:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: Benoit Parrot, Mauro Carvalho Chehab, linux-media, kernel-janitors
On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
--Prabhakar Lad
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *fmt)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> - unsigned int index = ARRAY_SIZE(ov2659_formats);
> + int index = ARRAY_SIZE(ov2659_formats);
> struct v4l2_mbus_framefmt *mf = &fmt->format;
> const struct ov2659_framesize *size = NULL;
> struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
2015-04-15 19:12 ` Dan Carpenter
@ 2015-04-16 15:40 ` Benoit Parrot
-1 siblings, 0 replies; 6+ messages in thread
From: Benoit Parrot @ 2015-04-16 15:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lad, Prabhakar, Mauro Carvalho Chehab, linux-media, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed [2015-Apr-15 22:12:18 +0300]:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Benoit Parrot <bparrot@ti.com>
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *fmt)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> - unsigned int index = ARRAY_SIZE(ov2659_formats);
> + int index = ARRAY_SIZE(ov2659_formats);
> struct v4l2_mbus_framefmt *mf = &fmt->format;
> const struct ov2659_framesize *size = NULL;
> struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
@ 2015-04-16 15:40 ` Benoit Parrot
0 siblings, 0 replies; 6+ messages in thread
From: Benoit Parrot @ 2015-04-16 15:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lad, Prabhakar, Mauro Carvalho Chehab, linux-media, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed [2015-Apr-15 22:12:18 +0300]:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Benoit Parrot <bparrot@ti.com>
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *fmt)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> - unsigned int index = ARRAY_SIZE(ov2659_formats);
> + int index = ARRAY_SIZE(ov2659_formats);
> struct v4l2_mbus_framefmt *mf = &fmt->format;
> const struct ov2659_framesize *size = NULL;
> struct ov2659 *ov2659 = to_ov2659(sd);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-16 15:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 19:12 [media] i2c: ov2659: signedness bug inov2659_set_fmt() Dan Carpenter
2015-04-15 19:12 ` Dan Carpenter
2015-04-16 10:03 ` Lad, Prabhakar
2015-04-16 10:03 ` Lad, Prabhakar
2015-04-16 15:40 ` Benoit Parrot
2015-04-16 15:40 ` Benoit Parrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.