* [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro
@ 2020-04-14 18:42 Lars Engebretsen
2020-04-15 5:43 ` Ardelean, Alexandru
0 siblings, 1 reply; 4+ messages in thread
From: Lars Engebretsen @ 2020-04-14 18:42 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23, Lars Engebretsen
Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
---
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index d63884a54939..76ba7c9fd3e0 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
* 0 on success, negative error number on failure.
*/
#define devm_iio_device_register(dev, indio_dev) \
- __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
+ __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
struct module *this_mod);
int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro
2020-04-14 18:42 [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
@ 2020-04-15 5:43 ` Ardelean, Alexandru
2020-04-15 10:10 ` Lars Engebretsen
0 siblings, 1 reply; 4+ messages in thread
From: Ardelean, Alexandru @ 2020-04-15 5:43 UTC (permalink / raw)
To: lars, linux-kernel, linux-iio; +Cc: jic23
On Tue, 2020-04-14 at 20:42 +0200, Lars Engebretsen wrote:
A description of the change is required to describe the change.
I think I mentioned this in my email, but I was lazy to provide an example.
Description of changes are required even for the smallest of changes; I think
it's mostly so that people always keep their brains trained to describe all
changes.
So here, you could say something like:
---------------------------------------------------------------------------
This change removes the semi-colon from the devm_iio_device_register() macro
which seems to have been added by accident via commit 63b19547cc3d9 ("iio: Use
macro magic to avoid manual assign of driver_module").
---------------------------------------------------------------------------
Make sure commit comments stay within a 75 column width limit.
And make sure you add a version tag for the next patch/re-send.
i.e. do git format-patch -v2 [or v3 for 3rd version,]
And it's a good idea to add a changelog after the line with '---' in the patch
file. Text after that line gets ignored for the commit description.
Something like:
Changelog v1 -> v2:
* added commit change description
> Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> ---
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index d63884a54939..76ba7c9fd3e0 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> * 0 on success, negative error number on failure.
> */
> #define devm_iio_device_register(dev, indio_dev) \
> - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> struct module *this_mod);
> int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro
2020-04-15 5:43 ` Ardelean, Alexandru
@ 2020-04-15 10:10 ` Lars Engebretsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Engebretsen @ 2020-04-15 10:10 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-kernel, linux-iio, jic23
Thanks Alexandru! I'm sending the second version of the patch now.
Den ons 15 apr. 2020 kl 07:43 skrev Ardelean, Alexandru
<alexandru.Ardelean@analog.com>:
>
> On Tue, 2020-04-14 at 20:42 +0200, Lars Engebretsen wrote:
>
> A description of the change is required to describe the change.
> I think I mentioned this in my email, but I was lazy to provide an example.
>
> Description of changes are required even for the smallest of changes; I think
> it's mostly so that people always keep their brains trained to describe all
> changes.
>
> So here, you could say something like:
> ---------------------------------------------------------------------------
> This change removes the semi-colon from the devm_iio_device_register() macro
> which seems to have been added by accident via commit 63b19547cc3d9 ("iio: Use
> macro magic to avoid manual assign of driver_module").
> ---------------------------------------------------------------------------
>
> Make sure commit comments stay within a 75 column width limit.
> And make sure you add a version tag for the next patch/re-send.
> i.e. do git format-patch -v2 [or v3 for 3rd version,]
>
> And it's a good idea to add a changelog after the line with '---' in the patch
> file. Text after that line gets ignored for the commit description.
> Something like:
>
> Changelog v1 -> v2:
> * added commit change description
>
>
> > Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> > ---
> > include/linux/iio/iio.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index d63884a54939..76ba7c9fd3e0 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> > * 0 on success, negative error number on failure.
> > */
> > #define devm_iio_device_register(dev, indio_dev) \
> > - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> > + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> > int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> > struct module *this_mod);
> > int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro
@ 2020-04-14 18:41 Lars Engebretsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Engebretsen @ 2020-04-14 18:41 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic, Lars Engebretsen
Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
---
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index d63884a54939..76ba7c9fd3e0 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
* 0 on success, negative error number on failure.
*/
#define devm_iio_device_register(dev, indio_dev) \
- __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
+ __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
struct module *this_mod);
int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-15 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 18:42 [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
2020-04-15 5:43 ` Ardelean, Alexandru
2020-04-15 10:10 ` Lars Engebretsen
-- strict thread matches above, loose matches on Subject: below --
2020-04-14 18:41 Lars Engebretsen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.