[PATCH] gcc10: Don't default back to -fcommon

[PATCH] gcc10: Don't default back to -fcommon

[Jacob Kroon]

It has been almost 3 months since the upgrade to gcc 10. Switch back to
relying on gcc default configuration (-fno-common).

This reverts OE-Core commit 951e859b1e8297970278c539e989b8a6d06a9cb3.

Signed-off-by: Jacob Kroon <jacob.kroon@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-configure-common.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
index 6cb40fcb74..a64c4caf00 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
@@ -34,7 +34,6 @@ EXTRA_OECONF = "\
     --program-prefix=${TARGET_PREFIX} \
     --without-local-prefix \
     --disable-install-libiberty \
-    --with-specs=%{!fno-common:%{!fcommon:-fcommon}} \
     ${EXTRA_OECONF_BASE} \
     ${EXTRA_OECONF_GCC_FLOAT} \
     ${EXTRA_OECONF_PATHS} \

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Tue, Aug 4, 2020 at 1:20 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>
> It has been almost 3 months since the upgrade to gcc 10. Switch back to
> relying on gcc default configuration (-fno-common).
>

have you done a world build with this? In core+meta-oe I still see 70+
recipes failing
what will be good is if people start sending fixes before switching
the defaults.

> This reverts OE-Core commit 951e859b1e8297970278c539e989b8a6d06a9cb3.
>
> Signed-off-by: Jacob Kroon <jacob.kroon@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-configure-common.inc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> index 6cb40fcb74..a64c4caf00 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> @@ -34,7 +34,6 @@ EXTRA_OECONF = "\
>      --program-prefix=${TARGET_PREFIX} \
>      --without-local-prefix \
>      --disable-install-libiberty \
> -    --with-specs=%{!fno-common:%{!fcommon:-fcommon}} \
>      ${EXTRA_OECONF_BASE} \
>      ${EXTRA_OECONF_GCC_FLOAT} \
>      ${EXTRA_OECONF_PATHS} \
> 

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Jacob Kroon]

On 8/5/20 2:14 AM, Khem Raj wrote:
> On Tue, Aug 4, 2020 at 1:20 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>>
>> It has been almost 3 months since the upgrade to gcc 10. Switch back to
>> relying on gcc default configuration (-fno-common).
>>
> 
> have you done a world build with this? In core+meta-oe I still see 70+
> recipes failing
> what will be good is if people start sending fixes before switching
> the defaults.
> 

Ah, that I haven't, only the images I use. Is there a list of failing 
recipes available somewhere ?

Jacob

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

On Tue, Aug 4, 2020 at 10:05 PM Jacob Kroon <jacob.kroon@gmail.com> wrote:

> On 8/5/20 2:14 AM, Khem Raj wrote:
> > On Tue, Aug 4, 2020 at 1:20 AM Jacob Kroon <jacob.kroon@gmail.com>
> wrote:
> >>
> >> It has been almost 3 months since the upgrade to gcc 10. Switch back to
> >> relying on gcc default configuration (-fno-common).
> >>
> >
> > have you done a world build with this? In core+meta-oe I still see 70+
> > recipes failing
> > what will be good is if people start sending fixes before switching
> > the defaults.
> >
>
> Ah, that I haven't, only the images I use. Is there a list of failing
> recipes available somewhere ?


I think I posted the list when I submitted the gcc10 upgrade but this patch
is already in master-next so Richard will soon share the Oe-core list
atleast

>
>
> Jacob
>

[-- Attachment #2: Type: text/html, Size: 1523 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

here is a recent build with clang11 which also switched to using
-fno-common and errors are pretty much same you will see with gcc10
with this patch to revert the -fcommon defaults.

https://errors.yoctoproject.org/Errors/Build/107234/?limit=100

I was waiting for upstream packages to get fixed before switching the
defaults back to -fno-common.

On Tue, Aug 4, 2020 at 11:00 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> On Tue, Aug 4, 2020 at 10:05 PM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>>
>> On 8/5/20 2:14 AM, Khem Raj wrote:
>> > On Tue, Aug 4, 2020 at 1:20 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>> >>
>> >> It has been almost 3 months since the upgrade to gcc 10. Switch back to
>> >> relying on gcc default configuration (-fno-common).
>> >>
>> >
>> > have you done a world build with this? In core+meta-oe I still see 70+
>> > recipes failing
>> > what will be good is if people start sending fixes before switching
>> > the defaults.
>> >
>>
>> Ah, that I haven't, only the images I use. Is there a list of failing
>> recipes available somewhere ?
>
>
> I think I posted the list when I submitted the gcc10 upgrade but this patch is already in master-next so Richard will soon share the Oe-core list atleast
>>
>>
>>
>> Jacob

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Jacob Kroon]

On 8/5/20 8:17 AM, Khem Raj wrote:
> here is a recent build with clang11 which also switched to using
> -fno-common and errors are pretty much same you will see with gcc10
> with this patch to revert the -fcommon defaults.
> 
> https://errors.yoctoproject.org/Errors/Build/107234/?limit=100
> 
> I was waiting for upstream packages to get fixed before switching the
> defaults back to -fno-common.
> 

Yes I understand, maybe its better to hold this for now.

Having a list of recipes that needs fixing would probably speed things 
up. I can have a look at some of them.

Jacob

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Richard Purdie]

On Wed, 2020-08-05 at 15:15 +0200, Jacob Kroon wrote:
> On 8/5/20 8:17 AM, Khem Raj wrote:
> > here is a recent build with clang11 which also switched to using
> > -fno-common and errors are pretty much same you will see with gcc10
> > with this patch to revert the -fcommon defaults.
> > 
> > https://errors.yoctoproject.org/Errors/Build/107234/?limit=100
> > 
> > I was waiting for upstream packages to get fixed before switching
> > the
> > defaults back to -fno-common.
> > 
> 
> Yes I understand, maybe its better to hold this for now.
> 
> Having a list of recipes that needs fixing would probably speed
> things up. I can have a look at some of them.

I ran this through with just OE-Core and the list of failures is:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/2237

I'm a little frustrated that patches like this get sent and them people
like Khem and I have to spot and avoid the problems as there isn't
testing :/.

I'll drop the patch for now until more of these issues are resolved.

Cheers,

Richard

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Richard Purdie]

On Tue, 2020-08-04 at 23:17 -0700, Khem Raj wrote:
> here is a recent build with clang11 which also switched to using
> -fno-common and errors are pretty much same you will see with gcc10
> with this patch to revert the -fcommon defaults.
> 
> https://errors.yoctoproject.org/Errors/Build/107234/?limit=100
> 
> I was waiting for upstream packages to get fixed before switching the
> defaults back to -fno-common.

Khem requested I revisit this. I see at least:

a) perf failures pretty much everywhere
b) kexec-tools in no-x11 build
c) cpio build failures in testimage

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1264

the world builds haven't completed yet.

So looks much better but still a few things need fixes.

Cheers,

Richard

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Sat, Aug 15, 2020 at 3:10 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2020-08-04 at 23:17 -0700, Khem Raj wrote:
> > here is a recent build with clang11 which also switched to using
> > -fno-common and errors are pretty much same you will see with gcc10
> > with this patch to revert the -fcommon defaults.
> >
> > https://errors.yoctoproject.org/Errors/Build/107234/?limit=100
> >
> > I was waiting for upstream packages to get fixed before switching the
> > defaults back to -fno-common.
>
> Khem requested I revisit this. I see at least:
>
> a) perf failures pretty much everywhere

This is interesting

| x86_64-poky-linux-gcc: error: unrecognized command-line option
'-m64/include/uapi/asm-generic/errno.h'

I wonder if its some kernel update which is causing this, it seems to
be missing a space in commandline somewhere

> b) kexec-tools in no-x11 build

I think I dealt with this in meta-oe perhaps we need to use -fcommon in cflags.

> c) cpio build failures in testimage
>
cpio needs a patch to build see
https://git.openembedded.org/openembedded-core/commit/?id=ca6e5511b59b585de793ff6424c7c6ccfcd8e61e
I guess we need to either patch cpio with this patch on target before
building or pass -fcommon to the test so this patch is not needed

Thanks for the run, I will try to look into it, I think for cpio build
failure perhaps we need to pass

> https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1264
>
> the world builds haven't completed yet.
>
> So looks much better but still a few things need fixes.
>
> Cheers,
>
> Richard
>
>

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

Bruce,

We need https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
backported to 5.4 kernels for perf to build with -fno-common can you
queue this in your kernel updates as soon as you can ?

Thanks
-Khem

On Sat, Aug 15, 2020 at 6:56 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sat, Aug 15, 2020 at 3:10 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Tue, 2020-08-04 at 23:17 -0700, Khem Raj wrote:
> > > here is a recent build with clang11 which also switched to using
> > > -fno-common and errors are pretty much same you will see with gcc10
> > > with this patch to revert the -fcommon defaults.
> > >
> > > https://errors.yoctoproject.org/Errors/Build/107234/?limit=100
> > >
> > > I was waiting for upstream packages to get fixed before switching the
> > > defaults back to -fno-common.
> >
> > Khem requested I revisit this. I see at least:
> >
> > a) perf failures pretty much everywhere
>
> This is interesting
>
> | x86_64-poky-linux-gcc: error: unrecognized command-line option
> '-m64/include/uapi/asm-generic/errno.h'
>
> I wonder if its some kernel update which is causing this, it seems to
> be missing a space in commandline somewhere
>
> > b) kexec-tools in no-x11 build
>
> I think I dealt with this in meta-oe perhaps we need to use -fcommon in cflags.
>
> > c) cpio build failures in testimage
> >
> cpio needs a patch to build see
> https://git.openembedded.org/openembedded-core/commit/?id=ca6e5511b59b585de793ff6424c7c6ccfcd8e61e
> I guess we need to either patch cpio with this patch on target before
> building or pass -fcommon to the test so this patch is not needed
>
> Thanks for the run, I will try to look into it, I think for cpio build
> failure perhaps we need to pass
>
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1264
> >
> > the world builds haven't completed yet.
> >
> > So looks much better but still a few things need fixes.
> >
> > Cheers,
> >
> > Richard
> >
> >

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Richard Purdie]

On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> Bruce,
> 
> We need 
> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> backported to 5.4 kernels for perf to build with -fno-common can you
> queue this in your kernel updates as soon as you can ?

I think we have other active kernels which will also need it as even
with Khem's patch we still see failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1267

Cheers,

Richard

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > Bruce,
> >
> > We need
> >
> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > backported to 5.4 kernels for perf to build with -fno-common can you
> > queue this in your kernel updates as soon as you can ?
>
> I think we have other active kernels which will also need it as even
> with Khem's patch we still see failures:
>
>
I've taken care of linux-yocto now, I don't think there are any active use
cases for those kernels that won't be covered.

Cheers,

Bruce



> https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1267
>
> Cheers,
>
> Richard
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 2164 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

Awesome, thanks!

On Sun, Aug 16, 2020 at 3:55 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
>
>
> On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>>
>> On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
>> > Bruce,
>> >
>> > We need
>> > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
>> > backported to 5.4 kernels for perf to build with -fno-common can you
>> > queue this in your kernel updates as soon as you can ?
>>
>> I think we have other active kernels which will also need it as even
>> with Khem's patch we still see failures:
>>
>
> I've taken care of linux-yocto now, I don't think there are any active use cases for those kernels that won't be covered.
>
> Cheers,
>
> Bruce
>
>
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1267
>>
>> Cheers,
>>
>> Richard
>>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Sun, Aug 16, 2020 at 6:47 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > Bruce,
> >
> > We need
> > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > backported to 5.4 kernels for perf to build with -fno-common can you
> > queue this in your kernel updates as soon as you can ?
>
> I think we have other active kernels which will also need it as even
> with Khem's patch we still see failures:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1267
>

I see

meta_ide.MetaIDE.test_meta_ide_can_build_cpio_project: FAILED (64.00s)

It seems the sdk fix for cpio is not working properly

> Cheers,
>
> Richard
>

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Richard Purdie]

On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> 
> 
> On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > Bruce,
> > > 
> > > We need 
> > > 
> > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > backported to 5.4 kernels for perf to build with -fno-common can
> > you
> > > queue this in your kernel updates as soon as you can ?
> > 
> > I think we have other active kernels which will also need it as
> > even
> > with Khem's patch we still see failures:
> > 
> 
> I've taken care of linux-yocto now, I don't think there are any
> active use cases for those kernels that won't be covered.

I bumped the meta-yocto BSPs with a quickly hacked up patch but we
still see:

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339

so I think there may be another patch we need somewhere...

(which matches what we saw with Khem's _append which also failed).

There is still some piece of this we're missing, maybe on non-IA.

Cheers,

Richard

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Mon, Aug 17, 2020 at 8:27 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> >
> >
> > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > Bruce,
> > > >
> > > > We need
> > > >
> > >
> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > backported to 5.4 kernels for perf to build with -fno-common can
> > > you
> > > > queue this in your kernel updates as soon as you can ?
> > >
> > > I think we have other active kernels which will also need it as
> > > even
> > > with Khem's patch we still see failures:
> > >
> >
> > I've taken care of linux-yocto now, I don't think there are any
> > active use cases for those kernels that won't be covered.
>
> I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> still see:
>
>
I have local bumps for the yocto-bsps as well, let me try a perf build
against beaglebone to see if I can see anything.

If I build master-next, will I get all the required gcc patches to trigger
the issue ?

Bruce



> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>
> so I think there may be another patch we need somewhere...
>
> (which matches what we saw with Khem's _append which also failed).
>
> There is still some piece of this we're missing, maybe on non-IA.
>
> Cheers,
>
> Richard
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 3157 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Richard Purdie]

On Mon, 2020-08-17 at 10:15 -0400, Bruce Ashfield wrote:
> 
> 
> On Mon, Aug 17, 2020 at 8:27 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> > > 
> > > 
> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > > richard.purdie@linuxfoundation.org> wrote:
> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > > Bruce,
> > > > > 
> > > > > We need 
> > > > > 
> > > > 
> > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > > backported to 5.4 kernels for perf to build with -fno-common
> > can
> > > > you
> > > > > queue this in your kernel updates as soon as you can ?
> > > > 
> > > > I think we have other active kernels which will also need it as
> > > > even
> > > > with Khem's patch we still see failures:
> > > > 
> > > 
> > > I've taken care of linux-yocto now, I don't think there are any
> > > active use cases for those kernels that won't be covered.
> > 
> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> > still see:
> > 
> 
> I have local bumps for the yocto-bsps as well, let me try a perf
> build against beaglebone to see if I can see anything.
> 
> If I build master-next, will I get all the required gcc patches to
> trigger the issue ?

You need:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?h=master-next&id=c79101ffff8a9cc70daefe737e16b773190bb6ca

without its revert (which is also in -next atm).

Cheers,

Richard

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> >
> >
> > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > Bruce,
> > > >
> > > > We need
> > > >
> > > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > backported to 5.4 kernels for perf to build with -fno-common can
> > > you
> > > > queue this in your kernel updates as soon as you can ?
> > >
> > > I think we have other active kernels which will also need it as
> > > even
> > > with Khem's patch we still see failures:
> > >
> >
> > I've taken care of linux-yocto now, I don't think there are any
> > active use cases for those kernels that won't be covered.
>
> I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> still see:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>
> so I think there may be another patch we need somewhere...
>
> (which matches what we saw with Khem's _append which also failed).
>

there seems to be concaternation of compiler options without space

| arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
'-mfpu=neon/include/uapi/asm-generic/errno.h'
| arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
vfpv4-d16
| arm-poky-linux-gnueabi-gcc: fatal error: no input files

but it also showed up on x86_64 in one of your prior builds, so I
wonder if its something in kernel build system or is it processing
TUNE_CCARGS in special ways.

> There is still some piece of this we're missing, maybe on non-IA.
>
> Cheers,
>
> Richard
>

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Mon, Aug 17, 2020 at 12:47 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> > >
> > >
> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > > richard.purdie@linuxfoundation.org> wrote:
> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > > Bruce,
> > > > >
> > > > > We need
> > > > >
> > > > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > > backported to 5.4 kernels for perf to build with -fno-common can
> > > > you
> > > > > queue this in your kernel updates as soon as you can ?
> > > >
> > > > I think we have other active kernels which will also need it as
> > > > even
> > > > with Khem's patch we still see failures:
> > > >
> > >
> > > I've taken care of linux-yocto now, I don't think there are any
> > > active use cases for those kernels that won't be covered.
> >
> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> > still see:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
> >
> > so I think there may be another patch we need somewhere...
> >
> > (which matches what we saw with Khem's _append which also failed).
> >
>
> there seems to be concaternation of compiler options without space
>
> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
> '-mfpu=neon/include/uapi/asm-generic/errno.h'
> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
> vfpv4-d16
> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>
> but it also showed up on x86_64 in one of your prior builds, so I
> wonder if its something in kernel build system or is it processing
> TUNE_CCARGS in special ways.
>
> > There is still some piece of this we're missing, maybe on non-IA.
> >

Perhaps these kernel backports might help

https://github.com/torvalds/linux/commit/7597ce89b3ed239f7a3408b930d2a6c7a4c938a1
https://github.com/torvalds/linux/commit/6d1f916265aa615218d341ba5d3fd39dfe931cde

> > Cheers,
> >
> > Richard
> >

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2983 bytes --]

On Mon, Aug 17, 2020 at 3:55 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Mon, Aug 17, 2020 at 12:47 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> > > >
> > > >
> > > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > > > richard.purdie@linuxfoundation.org> wrote:
> > > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > > > Bruce,
> > > > > >
> > > > > > We need
> > > > > >
> > > > >
> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > > > backported to 5.4 kernels for perf to build with -fno-common can
> > > > > you
> > > > > > queue this in your kernel updates as soon as you can ?
> > > > >
> > > > > I think we have other active kernels which will also need it as
> > > > > even
> > > > > with Khem's patch we still see failures:
> > > > >
> > > >
> > > > I've taken care of linux-yocto now, I don't think there are any
> > > > active use cases for those kernels that won't be covered.
> > >
> > > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> > > still see:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
> > >
> > > so I think there may be another patch we need somewhere...
> > >
> > > (which matches what we saw with Khem's _append which also failed).
> > >
> >
> > there seems to be concaternation of compiler options without space
> >
> > | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
> > '-mfpu=neon/include/uapi/asm-generic/errno.h'
> > | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
> > auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
> > neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
> > vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
> > vfpv4-d16
> > | arm-poky-linux-gnueabi-gcc: fatal error: no input files
> >
> > but it also showed up on x86_64 in one of your prior builds, so I
> > wonder if its something in kernel build system or is it processing
> > TUNE_CCARGS in special ways.
> >
> > > There is still some piece of this we're missing, maybe on non-IA.
> > >
>
> Perhaps these kernel backports might help
>
>
> https://github.com/torvalds/linux/commit/7597ce89b3ed239f7a3408b930d2a6c7a4c938a1
>
> https://github.com/torvalds/linux/commit/6d1f916265aa615218d341ba5d3fd39dfe931cde


I unfortunately had to clean and rebuild my development machine, so only
now started a reference h/w build to see what's up with perf.

I'll follow up tomorrow when I have some input.

Cheers,

Bruce



>
>
> > > Cheers,
> > >
> > > Richard
> > >
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 5300 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2758 bytes --]

Yes, I'm seeing this weird concatenation with raspberrypi builds as well:

find: unknown predicate `-mthumb/arch'
arm-webos-linux-gnueabi-gcc: error: unrecognized command-line option
'-mthumb/include/uapi/asm-generic/errno.h'
arm-webos-linux-gnueabi-gcc: fatal error: no input files
compilation terminated.

But in this case it isn't fatal for the perf build, I've noticed it only
because it was failing with 5.4.51 currently in meta-raspberrypi and after
upgrade to 5.4.58 perf built OK, but this error message is still there in
log.do_compile.

On Mon, Aug 17, 2020 at 9:47 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
> > >
> > >
> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
> > > richard.purdie@linuxfoundation.org> wrote:
> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
> > > > > Bruce,
> > > > >
> > > > > We need
> > > > >
> > > >
> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
> > > > > backported to 5.4 kernels for perf to build with -fno-common can
> > > > you
> > > > > queue this in your kernel updates as soon as you can ?
> > > >
> > > > I think we have other active kernels which will also need it as
> > > > even
> > > > with Khem's patch we still see failures:
> > > >
> > >
> > > I've taken care of linux-yocto now, I don't think there are any
> > > active use cases for those kernels that won't be covered.
> >
> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
> > still see:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
> >
> > so I think there may be another patch we need somewhere...
> >
> > (which matches what we saw with Khem's _append which also failed).
> >
>
> there seems to be concaternation of compiler options without space
>
> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
> '-mfpu=neon/include/uapi/asm-generic/errno.h'
> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
> vfpv4-d16
> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>
> but it also showed up on x86_64 in one of your prior builds, so I
> wonder if its something in kernel build system or is it processing
> TUNE_CCARGS in special ways.
>
> > There is still some piece of this we're missing, maybe on non-IA.
> >
> > Cheers,
> >
> > Richard
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 3907 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3322 bytes --]

On Tue, Aug 18, 2020 at 7:57 AM Martin Jansa <martin.jansa@gmail.com> wrote:

> Yes, I'm seeing this weird concatenation with raspberrypi builds as well:
>
> find: unknown predicate `-mthumb/arch'
> arm-webos-linux-gnueabi-gcc: error: unrecognized command-line option
> '-mthumb/include/uapi/asm-generic/errno.h'
> arm-webos-linux-gnueabi-gcc: fatal error: no input files
> compilation terminated.
>

confirmed as the same with my beaglebone build that ran overnight.

I'll have a closer look and send a fix (hopefully) .. but if anyone else is
already doing this, please let me know and I'll work on something else!

Cheers,

Bruce



>
> But in this case it isn't fatal for the perf build, I've noticed it only
> because it was failing with 5.4.51 currently in meta-raspberrypi and after
> upgrade to 5.4.58 perf built OK, but this error message is still there in
> log.do_compile.
>
> On Mon, Aug 17, 2020 at 9:47 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> >
>> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
>> > >
>> > >
>> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
>> > > richard.purdie@linuxfoundation.org> wrote:
>> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
>> > > > > Bruce,
>> > > > >
>> > > > > We need
>> > > > >
>> > > >
>> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
>> > > > > backported to 5.4 kernels for perf to build with -fno-common can
>> > > > you
>> > > > > queue this in your kernel updates as soon as you can ?
>> > > >
>> > > > I think we have other active kernels which will also need it as
>> > > > even
>> > > > with Khem's patch we still see failures:
>> > > >
>> > >
>> > > I've taken care of linux-yocto now, I don't think there are any
>> > > active use cases for those kernels that won't be covered.
>> >
>> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
>> > still see:
>> >
>> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>> >
>> > so I think there may be another patch we need somewhere...
>> >
>> > (which matches what we saw with Khem's _append which also failed).
>> >
>>
>> there seems to be concaternation of compiler options without space
>>
>> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
>> '-mfpu=neon/include/uapi/asm-generic/errno.h'
>> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
>> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
>> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
>> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
>> vfpv4-d16
>> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>>
>> but it also showed up on x86_64 in one of your prior builds, so I
>> wonder if its something in kernel build system or is it processing
>> TUNE_CCARGS in special ways.
>>
>> > There is still some piece of this we're missing, maybe on non-IA.
>> >
>> > Cheers,
>> >
>> > Richard
>> >
>> 
>>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 5457 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]

The perf issue with find and cflags concatenation is fixed in upstream by:
https://github.com/torvalds/linux/commit/e4ffd066ff440a57097e9140fa9e16ceef905de8

Adding V=1 to perf's EXTRA_OEMAKE makes it easier to see, sending a patch
now.

On Tue, Aug 18, 2020 at 2:21 PM Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:

>
>
> On Tue, Aug 18, 2020 at 7:57 AM Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> Yes, I'm seeing this weird concatenation with raspberrypi builds as well:
>>
>> find: unknown predicate `-mthumb/arch'
>> arm-webos-linux-gnueabi-gcc: error: unrecognized command-line option
>> '-mthumb/include/uapi/asm-generic/errno.h'
>> arm-webos-linux-gnueabi-gcc: fatal error: no input files
>> compilation terminated.
>>
>
> confirmed as the same with my beaglebone build that ran overnight.
>
> I'll have a closer look and send a fix (hopefully) .. but if anyone else
> is already doing this, please let me know and I'll work on something else!
>
> Cheers,
>
> Bruce
>
>
>
>>
>> But in this case it isn't fatal for the perf build, I've noticed it only
>> because it was failing with 5.4.51 currently in meta-raspberrypi and after
>> upgrade to 5.4.58 perf built OK, but this error message is still there in
>> log.do_compile.
>>
>> On Mon, Aug 17, 2020 at 9:47 PM Khem Raj <raj.khem@gmail.com> wrote:
>>
>>> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
>>> <richard.purdie@linuxfoundation.org> wrote:
>>> >
>>> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
>>> > >
>>> > >
>>> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
>>> > > richard.purdie@linuxfoundation.org> wrote:
>>> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
>>> > > > > Bruce,
>>> > > > >
>>> > > > > We need
>>> > > > >
>>> > > >
>>> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
>>> > > > > backported to 5.4 kernels for perf to build with -fno-common can
>>> > > > you
>>> > > > > queue this in your kernel updates as soon as you can ?
>>> > > >
>>> > > > I think we have other active kernels which will also need it as
>>> > > > even
>>> > > > with Khem's patch we still see failures:
>>> > > >
>>> > >
>>> > > I've taken care of linux-yocto now, I don't think there are any
>>> > > active use cases for those kernels that won't be covered.
>>> >
>>> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
>>> > still see:
>>> >
>>> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>>> >
>>> > so I think there may be another patch we need somewhere...
>>> >
>>> > (which matches what we saw with Khem's _append which also failed).
>>> >
>>>
>>> there seems to be concaternation of compiler options without space
>>>
>>> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
>>> '-mfpu=neon/include/uapi/asm-generic/errno.h'
>>> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
>>> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
>>> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
>>> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
>>> vfpv4-d16
>>> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>>>
>>> but it also showed up on x86_64 in one of your prior builds, so I
>>> wonder if its something in kernel build system or is it processing
>>> TUNE_CCARGS in special ways.
>>>
>>> > There is still some piece of this we're missing, maybe on non-IA.
>>> >
>>> > Cheers,
>>> >
>>> > Richard
>>> >
>>> 
>>>
>>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>

[-- Attachment #2: Type: text/html, Size: 6191 bytes --]

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Khem Raj]

On Tue, Aug 18, 2020 at 9:04 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> The perf issue with find and cflags concatenation is fixed in upstream by:
> https://github.com/torvalds/linux/commit/e4ffd066ff440a57097e9140fa9e16ceef905de8
>

this should fix it. thanks for nailing it,  I guess older kernels will
have tough time with gcc10

> Adding V=1 to perf's EXTRA_OEMAKE makes it easier to see, sending a patch now.
>
> On Tue, Aug 18, 2020 at 2:21 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>>
>>
>>
>> On Tue, Aug 18, 2020 at 7:57 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>>>
>>> Yes, I'm seeing this weird concatenation with raspberrypi builds as well:
>>>
>>> find: unknown predicate `-mthumb/arch'
>>> arm-webos-linux-gnueabi-gcc: error: unrecognized command-line option '-mthumb/include/uapi/asm-generic/errno.h'
>>> arm-webos-linux-gnueabi-gcc: fatal error: no input files
>>> compilation terminated.
>>
>>
>> confirmed as the same with my beaglebone build that ran overnight.
>>
>> I'll have a closer look and send a fix (hopefully) .. but if anyone else is already doing this, please let me know and I'll work on something else!
>>
>> Cheers,
>>
>> Bruce
>>
>>
>>>
>>>
>>> But in this case it isn't fatal for the perf build, I've noticed it only because it was failing with 5.4.51 currently in meta-raspberrypi and after upgrade to 5.4.58 perf built OK, but this error message is still there in log.do_compile.
>>>
>>> On Mon, Aug 17, 2020 at 9:47 PM Khem Raj <raj.khem@gmail.com> wrote:
>>>>
>>>> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
>>>> <richard.purdie@linuxfoundation.org> wrote:
>>>> >
>>>> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
>>>> > >
>>>> > >
>>>> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
>>>> > > richard.purdie@linuxfoundation.org> wrote:
>>>> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
>>>> > > > > Bruce,
>>>> > > > >
>>>> > > > > We need
>>>> > > > >
>>>> > > > https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
>>>> > > > > backported to 5.4 kernels for perf to build with -fno-common can
>>>> > > > you
>>>> > > > > queue this in your kernel updates as soon as you can ?
>>>> > > >
>>>> > > > I think we have other active kernels which will also need it as
>>>> > > > even
>>>> > > > with Khem's patch we still see failures:
>>>> > > >
>>>> > >
>>>> > > I've taken care of linux-yocto now, I don't think there are any
>>>> > > active use cases for those kernels that won't be covered.
>>>> >
>>>> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
>>>> > still see:
>>>> >
>>>> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>>>> >
>>>> > so I think there may be another patch we need somewhere...
>>>> >
>>>> > (which matches what we saw with Khem's _append which also failed).
>>>> >
>>>>
>>>> there seems to be concaternation of compiler options without space
>>>>
>>>> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
>>>> '-mfpu=neon/include/uapi/asm-generic/errno.h'
>>>> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
>>>> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
>>>> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
>>>> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
>>>> vfpv4-d16
>>>> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>>>>
>>>> but it also showed up on x86_64 in one of your prior builds, so I
>>>> wonder if its something in kernel build system or is it processing
>>>> TUNE_CCARGS in special ways.
>>>>
>>>> > There is still some piece of this we're missing, maybe on non-IA.
>>>> >
>>>> > Cheers,
>>>> >
>>>> > Richard
>>>> >
>>>> 
>>
>>
>>
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>>

Re: [OE-core] [PATCH] gcc10: Don't default back to -fcommon

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 4316 bytes --]

On Tue, Aug 18, 2020 at 12:04 PM Martin Jansa <martin.jansa@gmail.com>
wrote:

> The perf issue with find and cflags concatenation is fixed in upstream by:
>
> https://github.com/torvalds/linux/commit/e4ffd066ff440a57097e9140fa9e16ceef905de8
>
> Adding V=1 to perf's EXTRA_OEMAKE makes it easier to see, sending a patch
> now.
>
>
Yah. I did the same thing here, was chasing the issue through the generated
files, but hadn't tracked down the root cause yet.

Looks good to me. I'll chuck away my debug.

Bruce



> On Tue, Aug 18, 2020 at 2:21 PM Bruce Ashfield <bruce.ashfield@gmail.com>
> wrote:
>
>>
>>
>> On Tue, Aug 18, 2020 at 7:57 AM Martin Jansa <martin.jansa@gmail.com>
>> wrote:
>>
>>> Yes, I'm seeing this weird concatenation with raspberrypi builds as well:
>>>
>>> find: unknown predicate `-mthumb/arch'
>>> arm-webos-linux-gnueabi-gcc: error: unrecognized command-line option
>>> '-mthumb/include/uapi/asm-generic/errno.h'
>>> arm-webos-linux-gnueabi-gcc: fatal error: no input files
>>> compilation terminated.
>>>
>>
>> confirmed as the same with my beaglebone build that ran overnight.
>>
>> I'll have a closer look and send a fix (hopefully) .. but if anyone else
>> is already doing this, please let me know and I'll work on something else!
>>
>> Cheers,
>>
>> Bruce
>>
>>
>>
>>>
>>> But in this case it isn't fatal for the perf build, I've noticed it only
>>> because it was failing with 5.4.51 currently in meta-raspberrypi and after
>>> upgrade to 5.4.58 perf built OK, but this error message is still there in
>>> log.do_compile.
>>>
>>> On Mon, Aug 17, 2020 at 9:47 PM Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>>> On Mon, Aug 17, 2020 at 5:27 AM Richard Purdie
>>>> <richard.purdie@linuxfoundation.org> wrote:
>>>> >
>>>> > On Sun, 2020-08-16 at 18:55 -0400, Bruce Ashfield wrote:
>>>> > >
>>>> > >
>>>> > > On Sun, Aug 16, 2020 at 9:47 AM Richard Purdie <
>>>> > > richard.purdie@linuxfoundation.org> wrote:
>>>> > > > On Sat, 2020-08-15 at 19:41 -0700, Khem Raj wrote:
>>>> > > > > Bruce,
>>>> > > > >
>>>> > > > > We need
>>>> > > > >
>>>> > > >
>>>> https://github.com/torvalds/linux/commit/168200b6d6ea0cb5765943ec5da5b8149701f36a
>>>> > > > > backported to 5.4 kernels for perf to build with -fno-common can
>>>> > > > you
>>>> > > > > queue this in your kernel updates as soon as you can ?
>>>> > > >
>>>> > > > I think we have other active kernels which will also need it as
>>>> > > > even
>>>> > > > with Khem's patch we still see failures:
>>>> > > >
>>>> > >
>>>> > > I've taken care of linux-yocto now, I don't think there are any
>>>> > > active use cases for those kernels that won't be covered.
>>>> >
>>>> > I bumped the meta-yocto BSPs with a quickly hacked up patch but we
>>>> > still see:
>>>> >
>>>> >
>>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/2339
>>>> >
>>>> > so I think there may be another patch we need somewhere...
>>>> >
>>>> > (which matches what we saw with Khem's _append which also failed).
>>>> >
>>>>
>>>> there seems to be concaternation of compiler options without space
>>>>
>>>> | arm-poky-linux-gnueabi-gcc: error: unrecognized argument in option
>>>> '-mfpu=neon/include/uapi/asm-generic/errno.h'
>>>> | arm-poky-linux-gnueabi-gcc: note: valid arguments to '-mfpu=' are:
>>>> auto crypto-neon-fp-armv8 fp-armv8 fpv4-sp-d16 fpv5-d16 fpv5-sp-d16
>>>> neon neon-fp-armv8 neon-fp16 neon-vfpv3 neon-vfpv4 vfp vfp3 vfpv2
>>>> vfpv3 vfpv3-d16 vfpv3-d16-fp16 vfpv3-fp16 vfpv3xd vfpv3xd-fp16 vfpv4
>>>> vfpv4-d16
>>>> | arm-poky-linux-gnueabi-gcc: fatal error: no input files
>>>>
>>>> but it also showed up on x86_64 in one of your prior builds, so I
>>>> wonder if its something in kernel build system or is it processing
>>>> TUNE_CCARGS in special ways.
>>>>
>>>> > There is still some piece of this we're missing, maybe on non-IA.
>>>> >
>>>> > Cheers,
>>>> >
>>>> > Richard
>>>> >
>>>> 
>>>>
>>>
>>
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>>
>>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 7381 bytes --]