[PATCH] libsolv: add new recipe

[PATCH] libsolv: add new recipe

[Alejandro del Castillo]

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
---
 meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 26 +++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb

diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
new file mode 100644
index 0000000..14955da
--- /dev/null
+++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
@@ -0,0 +1,26 @@
+SUMMARY = "Library for solving packages and reading repositories"
+HOMEPAGE = "https://github.com/openSUSE/libsolv"
+BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
+SECTION = "devel"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
+
+SRC_URI = "https://github.com/openSUSE/libsolv/archive/0.6.14.zip"
+
+SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
+SRC_URI[sha256sum] = "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45"
+
+PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
+
+S = "${WORKDIR}/libsolv-0.6.14"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DLIB=${baselib}"
+
+DEPENDS = "expat zlib"
+
+FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
+FILES_${PN}-tools = "${bindir}/*"
+FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
+FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
-- 
1.9.1

Re: [PATCH] libsolv: add new recipe

[Paul Eggleton]

Hi Alejandro,

On Wed, 09 Dec 2015 14:50:03 Alejandro del Castillo wrote:
> Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

So perhaps it was discussed elsewhere, but in any case if you want this to be 
added to OE-Core there needs to be something mentioned in the commit message 
about why - what needs this? If nothing, is OE-Core the best place for it?

> ---
>  meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 26
> +++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>  create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> 
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb new file mode 100644
> index 0000000..14955da
> --- /dev/null
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "Library for solving packages and reading repositories"
> +HOMEPAGE = "https://github.com/openSUSE/libsolv"
> +BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
> +SECTION = "devel"
> +LICENSE = "BSD"

LICENSE should be more specific - BSD-2-Clause, BSD-3-Clause, etc.

> +LIC_FILES_CHKSUM =
> "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8" +
>
> +SRC_URI = "https://github.com/openSUSE/libsolv/archive/0.6.14.zip"

Please use ${PV} instead of 0.6.14 here to make future upgrades easier.

> +SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
> +SRC_URI[sha256sum] =
> "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45" 
> +
> +PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"

The PACKAGES line should move down before the FILES lines since this has to do 
with packaging.

> +
> +S = "${WORKDIR}/libsolv-0.6.14"

As per SRC_URI, please use ${PV} instead of 0.6.14 here.

> +
> +inherit cmake
> +
> +EXTRA_OECMAKE = "-DLIB=${baselib}"
> +
> +DEPENDS = "expat zlib"
> +
> +FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> +FILES_${PN}-tools = "${bindir}/*"
> +FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
> +FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

[PATCH v2] libsolv: add new recipe

[Alejandro del Castillo]

Required by the optional opkg 0.3.1 libsolv backend.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
---
 meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 26 +++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb

diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
new file mode 100644
index 0000000..de374f8
--- /dev/null
+++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
@@ -0,0 +1,26 @@
+SUMMARY = "Library for solving packages and reading repositories"
+HOMEPAGE = "https://github.com/openSUSE/libsolv"
+BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
+SECTION = "devel"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
+
+SRC_URI = "https://github.com/openSUSE/libsolv/archive/${PV}.zip"
+
+SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
+SRC_URI[sha256sum] = "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45"
+
+S = "${WORKDIR}/libsolv-${PV}"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DLIB=${baselib}"
+
+DEPENDS = "expat zlib"
+
+PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
+
+FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
+FILES_${PN}-tools = "${bindir}/*"
+FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
+FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
-- 
1.9.1

[PATCH v3] libsolv: add new recipe

[Alejandro del Castillo]

Required by the optional opkg 0.3.1 libsolv backend.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
---
 meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 28 +++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb

diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
new file mode 100644
index 0000000..fba6b2d
--- /dev/null
+++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
@@ -0,0 +1,28 @@
+SUMMARY = "Library for solving packages and reading repositories"
+HOMEPAGE = "https://github.com/openSUSE/libsolv"
+BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
+SECTION = "devel"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
+
+SRC_URI = "https://github.com/openSUSE/libsolv/archive/${PV}.zip"
+
+SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
+SRC_URI[sha256sum] = "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45"
+
+S = "${WORKDIR}/libsolv-${PV}"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DLIB=${baselib}"
+
+DEPENDS = "expat zlib"
+
+PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
+
+FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
+FILES_${PN}-tools = "${bindir}/*"
+FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
+FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
+
+BBCLASSEXTEND =+ "native nativesdk"
-- 
1.9.1

Re: [PATCH v3] libsolv: add new recipe

[Andre McCurdy]

On Thu, Dec 10, 2015 at 1:22 PM, Alejandro del Castillo
<alejandro.delcastillo@ni.com> wrote:
> Required by the optional opkg 0.3.1 libsolv backend.
>
> Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
> ---
>  meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 28 +++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb
>
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> new file mode 100644
> index 0000000..fba6b2d
> --- /dev/null
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> @@ -0,0 +1,28 @@
> +SUMMARY = "Library for solving packages and reading repositories"
> +HOMEPAGE = "https://github.com/openSUSE/libsolv"
> +BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
> +SECTION = "devel"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
> +
> +SRC_URI = "https://github.com/openSUSE/libsolv/archive/${PV}.zip"

GitHub tar file archives sometimes get regenerated and the hashes
change. I'm not sure if the same can happen for zip files, but it's
probably safer to checkout a git release tag rather than trust the zip
file.

> +SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
> +SRC_URI[sha256sum] = "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45"
> +
> +S = "${WORKDIR}/libsolv-${PV}"

This is effectively the default value, so this line can be removed (if
you switch to a git checkout then S does need to be specified though).

> +inherit cmake
> +
> +EXTRA_OECMAKE = "-DLIB=${baselib}"
> +
> +DEPENDS = "expat zlib"

DEPENDS should be above SRC_URI. See the OE style guide:

  http://www.openembedded.org/wiki/Styleguide

> +PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
> +
> +FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> +FILES_${PN}-tools = "${bindir}/*"
> +FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
> +FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
> +
> +BBCLASSEXTEND =+ "native nativesdk"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v3] libsolv: add new recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

On 10 December 2015 at 23:16, Andre McCurdy <armccurdy@gmail.com> wrote:

> > +SRC_URI = "https://github.com/openSUSE/libsolv/archive/${PV}.zip"
>
> GitHub tar file archives sometimes get regenerated and the hashes
> change. I'm not sure if the same can happen for zip files, but it's
> probably safer to checkout a git release tag rather than trust the zip
> file.


For what it's worth this was true in the past but I'm now reliably informed
that the archive tarballs are generated with literally git archive, which
goes to great pains to be reproducible.  I would pick the tarball over the
zip though.

Ross

[-- Attachment #2: Type: text/html, Size: 1134 bytes --]

Re: [PATCH v3] libsolv: add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

I was hit by this regeneration again last month so it's still happening.

On Fri, Dec 11, 2015 at 12:55 AM, Burton, Ross <ross.burton@intel.com>
wrote:

>
> On 10 December 2015 at 23:16, Andre McCurdy <armccurdy@gmail.com> wrote:
>
>> > +SRC_URI = "https://github.com/openSUSE/libsolv/archive/${PV}.zip"
>>
>> GitHub tar file archives sometimes get regenerated and the hashes
>> change. I'm not sure if the same can happen for zip files, but it's
>> probably safer to checkout a git release tag rather than trust the zip
>> file.
>
>
> For what it's worth this was true in the past but I'm now reliably
> informed that the archive tarballs are generated with literally git
> archive, which goes to great pains to be reproducible.  I would pick the
> tarball over the zip though.
>
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 2056 bytes --]

Re: [PATCH v3] libsolv: add new recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

On 11 December 2015 at 00:15, Martin Jansa <martin.jansa@gmail.com> wrote:

> I was hit by this regeneration again last month so it's still happening.
>

That's very interesting, as I was assured by GitHub engineering that it
wouldn't. :)  Can you recall what the archive was, and the before/after
md5sums?

Ross

[-- Attachment #2: Type: text/html, Size: 687 bytes --]

[PATCH v4] libsolv: add new recipe

[Alejandro del Castillo]

Required by the optional opkg 0.3.1 libsolv backend.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
---
 meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 28 +++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb

diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
new file mode 100644
index 0000000..11d6c70
--- /dev/null
+++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
@@ -0,0 +1,28 @@
+SUMMARY = "Library for solving packages and reading repositories"
+HOMEPAGE = "https://github.com/openSUSE/libsolv"
+BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
+SECTION = "devel"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
+
+DEPENDS = "expat zlib"
+
+PV = "0.6.14+git${SRCPV}"
+
+SRC_URI = "git://github.com/openSUSE/libsolv.git;branch=master"
+SRCREV = "b1ea39233f86cd62fbab1964d7497244f6be0087"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DLIB=${baselib}"
+
+PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
+
+FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
+FILES_${PN}-tools = "${bindir}/*"
+FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
+FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
+
+BBCLASSEXTEND =+ "native nativesdk"
-- 
1.9.1

Re: [PATCH v4] libsolv: add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

branch=master is the default, you can drop it

As you set the PV inside it would be nicer to rename it to _git.bb so it's
clear that it's from git.

On Fri, Dec 11, 2015 at 10:29 PM, Alejandro del Castillo <
alejandro.delcastillo@ni.com> wrote:

> Required by the optional opkg 0.3.1 libsolv backend.
>
> Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
> ---
>  meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 28
> +++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb
>
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> new file mode 100644
> index 0000000..11d6c70
> --- /dev/null
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> @@ -0,0 +1,28 @@
> +SUMMARY = "Library for solving packages and reading repositories"
> +HOMEPAGE = "https://github.com/openSUSE/libsolv"
> +BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
> +SECTION = "devel"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM =
> "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
> +
> +DEPENDS = "expat zlib"
> +
> +PV = "0.6.14+git${SRCPV}"
> +
> +SRC_URI = "git://github.com/openSUSE/libsolv.git;branch=master"
> +SRCREV = "b1ea39233f86cd62fbab1964d7497244f6be0087"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit cmake
> +
> +EXTRA_OECMAKE = "-DLIB=${baselib}"
> +
> +PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
> +
> +FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> +FILES_${PN}-tools = "${bindir}/*"
> +FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
> +FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
> +
> +BBCLASSEXTEND =+ "native nativesdk"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3641 bytes --]

[PATCH v5] libsolv: add new recipe

[Alejandro del Castillo]

Required by the optional opkg 0.3.1 libsolv backend.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
---
 meta/recipes-extended/libsolv/libsolv_git.bb | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 meta/recipes-extended/libsolv/libsolv_git.bb

diff --git a/meta/recipes-extended/libsolv/libsolv_git.bb b/meta/recipes-extended/libsolv/libsolv_git.bb
new file mode 100644
index 0000000..2011487
--- /dev/null
+++ b/meta/recipes-extended/libsolv/libsolv_git.bb
@@ -0,0 +1,28 @@
+SUMMARY = "Library for solving packages and reading repositories"
+HOMEPAGE = "https://github.com/openSUSE/libsolv"
+BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
+SECTION = "devel"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8"
+
+DEPENDS = "expat zlib"
+
+PV = "0.6.14+git${SRCPV}"
+
+SRC_URI = "git://github.com/openSUSE/libsolv.git"
+SRCREV = "b1ea39233f86cd62fbab1964d7497244f6be0087"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DLIB=${baselib}"
+
+PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"
+
+FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
+FILES_${PN}-tools = "${bindir}/*"
+FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
+FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"
+
+BBCLASSEXTEND =+ "native nativesdk"
-- 
1.9.1

Re: [PATCH] libsolv: add new recipe

[Alejandro del Castillo]

On 12/09/2015 04:04 PM, Paul Eggleton wrote:
> So perhaps it was discussed elsewhere, but in any case if you want this to be
> added to OE-Core there needs to be something mentioned in the commit message
> about why - what needs this? If nothing, is OE-Core the best place for it?

To add a bit more color: opkg 0.3.1 has a new backend to use libsolv as the
dependency solver instead of using the recursive internal algorithm. 
Moving forward
(jethro + 2 probably) I envision OE using the libsolv backend by default 
since the libsolv solver is vastly superior to the internal one.

-- 
Cheers,

Alejandro