From: Russell Harmon <eatnumber1@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: mpatocka@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/4] Document dm-integrity default values.
Date: Sun, 4 Jun 2023 22:05:10 -0700 [thread overview]
Message-ID: <CA+zrezSnteG0k5nAsTj9_Hpqq6pfMxGE3X47pQx4M_MOqTvOvg@mail.gmail.com> (raw)
In-Reply-To: <ZH1TmkyVJbIlNUEE@debian.me>
On Sun, Jun 4, 2023 at 8:16 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Sun, Jun 04, 2023 at 12:06:03PM -0700, Russell Harmon wrote:
> > Specifically:
> > interleave_sectors = 32768
> > buffer_sectors = 128
> > block_size = 512
> > journal_watermark = 50
> > commit_time = 10000
>
> Your patch description duplicates the diff content below. Please write
> in a mood that evocates curiosity to read the diff (and make sure it is
> also imperative).
I'm not sure what to say in the commit message that isn't already
captured in the diff content and the summary line of the commit. v2
was such a patch, but you asked to add some content to the message. Do
you have a suggestion for what to say?
v4 that I'm about to send says "Documentation: dm-integrity: Document
default values" in the summary line and has no other content in the
commit message.
WARNING: multiple messages have this Message-ID (diff)
From: Russell Harmon <eatnumber1@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com, snitzer@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v3 3/4] Document dm-integrity default values.
Date: Sun, 4 Jun 2023 22:05:10 -0700 [thread overview]
Message-ID: <CA+zrezSnteG0k5nAsTj9_Hpqq6pfMxGE3X47pQx4M_MOqTvOvg@mail.gmail.com> (raw)
In-Reply-To: <ZH1TmkyVJbIlNUEE@debian.me>
On Sun, Jun 4, 2023 at 8:16 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Sun, Jun 04, 2023 at 12:06:03PM -0700, Russell Harmon wrote:
> > Specifically:
> > interleave_sectors = 32768
> > buffer_sectors = 128
> > block_size = 512
> > journal_watermark = 50
> > commit_time = 10000
>
> Your patch description duplicates the diff content below. Please write
> in a mood that evocates curiosity to read the diff (and make sure it is
> also imperative).
I'm not sure what to say in the commit message that isn't already
captured in the diff content and the summary line of the commit. v2
was such a patch, but you asked to add some content to the message. Do
you have a suggestion for what to say?
v4 that I'm about to send says "Documentation: dm-integrity: Document
default values" in the summary line and has no other content in the
commit message.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-06-05 5:05 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 0:20 [dm-devel] [PATCH] Improve the dm-integrity documentation Russell Harmon
2023-06-03 10:02 ` Russell Harmon
2023-06-03 12:50 ` Bagas Sanjaya
2023-06-03 12:50 ` Bagas Sanjaya
2023-06-03 12:45 ` Bagas Sanjaya
2023-06-03 12:45 ` Bagas Sanjaya
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` [dm-devel] " Russell Harmon
2023-06-03 20:15 ` [PATCH 1/4] Fix minor grammatical error in dm-integrity.rst Russell Harmon
2023-06-03 20:15 ` [dm-devel] " Russell Harmon
2023-06-03 20:15 ` [PATCH 2/4] Documents the meaning of "buffer" in dm-integrity Russell Harmon
2023-06-03 20:15 ` [dm-devel] " Russell Harmon
2023-06-03 20:15 ` [PATCH 3/4] Document dm-integrity default values Russell Harmon
2023-06-03 20:15 ` [dm-devel] " Russell Harmon
2023-06-03 20:15 ` [PATCH 4/4] Document an example of how the tunables relate in dm-integrity Russell Harmon
2023-06-03 20:15 ` [dm-devel] " Russell Harmon
2023-06-04 14:07 ` [PATCH] Improve the dm-integrity documentation Bagas Sanjaya
2023-06-04 14:07 ` [dm-devel] " Bagas Sanjaya
2023-06-04 18:25 ` Russell Harmon
2023-06-04 18:25 ` [dm-devel] " Russell Harmon
2023-06-04 19:06 ` [PATCH v3 0/4] " Russell Harmon
2023-06-04 19:06 ` [dm-devel] " Russell Harmon
2023-06-04 19:06 ` [PATCH v3 1/4] Fix minor grammatical error in dm-integrity.rst Russell Harmon
2023-06-04 19:06 ` [dm-devel] " Russell Harmon
2023-06-05 3:03 ` Bagas Sanjaya
2023-06-05 3:03 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:00 ` Russell Harmon
2023-06-05 5:00 ` [dm-devel] " Russell Harmon
2023-06-04 19:06 ` [PATCH v3 2/4] Documents the meaning of "buffer" in dm-integrity Russell Harmon
2023-06-04 19:06 ` [dm-devel] " Russell Harmon
2023-06-05 3:05 ` Bagas Sanjaya
2023-06-05 3:05 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:07 ` Bagas Sanjaya
2023-06-05 3:07 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:01 ` Russell Harmon
2023-06-05 5:01 ` [dm-devel] " Russell Harmon
2023-06-04 19:06 ` [PATCH v3 3/4] Document dm-integrity default values Russell Harmon
2023-06-04 19:06 ` [dm-devel] " Russell Harmon
2023-06-05 3:16 ` Bagas Sanjaya
2023-06-05 3:16 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:05 ` Russell Harmon [this message]
2023-06-05 5:05 ` Russell Harmon
2023-06-05 13:23 ` Jonathan Corbet
2023-06-05 13:23 ` [dm-devel] " Jonathan Corbet
2023-06-06 2:16 ` Bagas Sanjaya
2023-06-06 2:16 ` [dm-devel] " Bagas Sanjaya
2023-06-04 19:06 ` [PATCH v3 4/4] Document an example of how the tunables relate in dm-integrity Russell Harmon
2023-06-04 19:06 ` [dm-devel] " Russell Harmon
2023-06-05 3:17 ` Bagas Sanjaya
2023-06-05 3:17 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:05 ` Russell Harmon
2023-06-05 5:05 ` [dm-devel] " Russell Harmon
2023-06-05 5:08 ` [PATCH v4 0/4] Improve the dm-integrity documentation Russell Harmon
2023-06-05 5:08 ` [dm-devel] " Russell Harmon
2023-06-05 5:08 ` [PATCH v4 1/4] Documentation: dm-integrity: Fix minor grammatical error Russell Harmon
2023-06-05 5:08 ` [dm-devel] " Russell Harmon
2023-06-06 2:17 ` Bagas Sanjaya
2023-06-06 2:17 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:08 ` [PATCH v4 2/4] Documentation: dm-integrity: Document the meaning of "buffer" Russell Harmon
2023-06-05 5:08 ` [dm-devel] " Russell Harmon
2023-06-06 2:18 ` Bagas Sanjaya
2023-06-06 2:18 ` [dm-devel] " Bagas Sanjaya
2023-06-05 5:08 ` [PATCH v4 3/4] Documentation: dm-integrity: Document default values Russell Harmon
2023-06-05 5:08 ` [dm-devel] " Russell Harmon
2023-06-05 5:08 ` [PATCH v4 4/4] Documentation: dm-integrity: Document an example of how the tunables relate Russell Harmon
2023-06-05 5:08 ` [dm-devel] " Russell Harmon
2023-06-17 19:37 ` Russell Harmon
2023-06-17 19:37 ` [dm-devel] " Russell Harmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+zrezSnteG0k5nAsTj9_Hpqq6pfMxGE3X47pQx4M_MOqTvOvg@mail.gmail.com \
--to=eatnumber1@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=dm-devel@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.