All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
	Ohad Ben Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
	<linux-remoteproc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver
Date: Fri, 8 Oct 2021 12:12:06 +0800	[thread overview]
Message-ID: <CAA+D8ANDP0ZPFKbRaYCwD+8zE3qvckKo9JjXwNBFUPrJ66=idw@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqK2KHfDisDXsuyWX0P99uY+nmEG72AsNUmqGRjJKHmg_Q@mail.gmail.com>

Hi Rob

On Sat, Oct 2, 2021 at 12:40 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Sep 29, 2021 at 9:34 PM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
> >
> > Hi Rob
> >
> > On Thu, Sep 30, 2021 at 6:40 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote:
> > > > As there are two drivers for DSP on i.MX, one is for sound open
> > > > firmware, another is for remote processor framework. In order to
> > > > distinguish two kinds of driver, defining different compatible strings.
> > > >
> > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl
> > > > are needed and the mailbox channel is different with SOF.
> > > >
> > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > > > Acked-by: Daniel Baluta <daniel.baluta@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/dsp/fsl,dsp.yaml      | 81 +++++++++++++++++--
> > > >  1 file changed, 75 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > index 7afc9f2be13a..51ea657f6d42 100644
> > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core
> > > >
> > > >  maintainers:
> > > >    - Daniel Baluta <daniel.baluta@nxp.com>
> > > > +  - Shengjiu Wang <shengjiu.wang@nxp.com>
> > > >
> > > >  description: |
> > > >    Some boards from i.MX8 family contain a DSP core used for
> > > > @@ -19,6 +20,10 @@ properties:
> > > >        - fsl,imx8qxp-dsp
> > > >        - fsl,imx8qm-dsp
> > > >        - fsl,imx8mp-dsp
> > > > +      - fsl,imx8qxp-hifi4
> > > > +      - fsl,imx8qm-hifi4
> > > > +      - fsl,imx8mp-hifi4
> > > > +      - fsl,imx8ulp-hifi4
> > > >
> > > >    reg:
> > > >      maxItems: 1
> > > > @@ -28,37 +33,63 @@ properties:
> > > >        - description: ipg clock
> > > >        - description: ocram clock
> > > >        - description: core clock
> > > > +      - description: debug interface clock
> > > > +      - description: message unit clock
> > > > +    minItems: 3
> > > > +    maxItems: 5
> > >
> > > Don't need maxItems.
> >
> > Ok, I will update it.
> >
> > >
> > > >
> > > >    clock-names:
> > > >      items:
> > > >        - const: ipg
> > > >        - const: ocram
> > > >        - const: core
> > > > +      - const: debug
> > > > +      - const: mu
> > > > +    minItems: 3
> > > > +    maxItems: 5
> > >
> > > ditto
> >
> > Ok, I will update it.
> >
> > >
> > > >
> > > >    power-domains:
> > > >      description:
> > > >        List of phandle and PM domain specifier as documented in
> > > >        Documentation/devicetree/bindings/power/power_domain.txt
> > > > +    minItems: 1
> > >
> > > This is curious. The h/w sometimes has fewer power domains?
> >
> > On i.MX8QM/8QXP,  there are independent power domains for DSP core,
> > DSP's RAM and DSP's MU.
> > But on i.MX8MP, all these DSP components are in same audio subsystem
> > There is only one power domain for whole audio subsystem,  when
> > power on audio subsystem, the DSP's components are powered on also.
> >
> > So the number of power domain depends on how the DSP component
> > integrated in SoC.
>
> Sounds like you can write an if/then schema for this difference.
>

I try this:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,imx8mp-hifi4
              - fsl,imx8mp-dsp

    then:
      properties:
        power-domains:
          maxItems: 1

    else:
      properties:
        power-domains:
          maxItems: 4


But the dt_binding_check report error:
  DTEX    Documentation/devicetree/bindings/dsp/fsl,dsp.example.dts
  DTC     Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml
/opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml:
dsp@3b6e8000: power-domains: [[4294967295]] is too short
        From schema:
/opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml

I don't know the reason, could you please help to have a look what
is wrong?

Best regards
Wang Shengjiu

WARNING: multiple messages have this Message-ID
From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
	Ohad Ben Cohen <ohad@wizery.com>,
	 Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	 Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	 NXP Linux Team <linux-imx@nxp.com>,
	 "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
	<linux-remoteproc@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver
Date: Fri, 8 Oct 2021 12:12:06 +0800	[thread overview]
Message-ID: <CAA+D8ANDP0ZPFKbRaYCwD+8zE3qvckKo9JjXwNBFUPrJ66=idw@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqK2KHfDisDXsuyWX0P99uY+nmEG72AsNUmqGRjJKHmg_Q@mail.gmail.com>

Hi Rob

On Sat, Oct 2, 2021 at 12:40 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Sep 29, 2021 at 9:34 PM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
> >
> > Hi Rob
> >
> > On Thu, Sep 30, 2021 at 6:40 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Sun, Sep 26, 2021 at 11:07:10AM +0800, Shengjiu Wang wrote:
> > > > As there are two drivers for DSP on i.MX, one is for sound open
> > > > firmware, another is for remote processor framework. In order to
> > > > distinguish two kinds of driver, defining different compatible strings.
> > > >
> > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl
> > > > are needed and the mailbox channel is different with SOF.
> > > >
> > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > > > Acked-by: Daniel Baluta <daniel.baluta@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/dsp/fsl,dsp.yaml      | 81 +++++++++++++++++--
> > > >  1 file changed, 75 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > index 7afc9f2be13a..51ea657f6d42 100644
> > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core
> > > >
> > > >  maintainers:
> > > >    - Daniel Baluta <daniel.baluta@nxp.com>
> > > > +  - Shengjiu Wang <shengjiu.wang@nxp.com>
> > > >
> > > >  description: |
> > > >    Some boards from i.MX8 family contain a DSP core used for
> > > > @@ -19,6 +20,10 @@ properties:
> > > >        - fsl,imx8qxp-dsp
> > > >        - fsl,imx8qm-dsp
> > > >        - fsl,imx8mp-dsp
> > > > +      - fsl,imx8qxp-hifi4
> > > > +      - fsl,imx8qm-hifi4
> > > > +      - fsl,imx8mp-hifi4
> > > > +      - fsl,imx8ulp-hifi4
> > > >
> > > >    reg:
> > > >      maxItems: 1
> > > > @@ -28,37 +33,63 @@ properties:
> > > >        - description: ipg clock
> > > >        - description: ocram clock
> > > >        - description: core clock
> > > > +      - description: debug interface clock
> > > > +      - description: message unit clock
> > > > +    minItems: 3
> > > > +    maxItems: 5
> > >
> > > Don't need maxItems.
> >
> > Ok, I will update it.
> >
> > >
> > > >
> > > >    clock-names:
> > > >      items:
> > > >        - const: ipg
> > > >        - const: ocram
> > > >        - const: core
> > > > +      - const: debug
> > > > +      - const: mu
> > > > +    minItems: 3
> > > > +    maxItems: 5
> > >
> > > ditto
> >
> > Ok, I will update it.
> >
> > >
> > > >
> > > >    power-domains:
> > > >      description:
> > > >        List of phandle and PM domain specifier as documented in
> > > >        Documentation/devicetree/bindings/power/power_domain.txt
> > > > +    minItems: 1
> > >
> > > This is curious. The h/w sometimes has fewer power domains?
> >
> > On i.MX8QM/8QXP,  there are independent power domains for DSP core,
> > DSP's RAM and DSP's MU.
> > But on i.MX8MP, all these DSP components are in same audio subsystem
> > There is only one power domain for whole audio subsystem,  when
> > power on audio subsystem, the DSP's components are powered on also.
> >
> > So the number of power domain depends on how the DSP component
> > integrated in SoC.
>
> Sounds like you can write an if/then schema for this difference.
>

I try this:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,imx8mp-hifi4
              - fsl,imx8mp-dsp

    then:
      properties:
        power-domains:
          maxItems: 1

    else:
      properties:
        power-domains:
          maxItems: 4


But the dt_binding_check report error:
  DTEX    Documentation/devicetree/bindings/dsp/fsl,dsp.example.dts
  DTC     Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml
/opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.example.dt.yaml:
dsp@3b6e8000: power-domains: [[4294967295]] is too short
        From schema:
/opt/alsa/sound/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml

I don't know the reason, could you please help to have a look what
is wrong?

Best regards
Wang Shengjiu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-08  4:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26  3:07 [PATCH v5 0/4] Add remoteproc driver for DSP on i.MX Shengjiu Wang
2021-09-26  3:07 ` Shengjiu Wang
2021-09-26  3:07 ` [PATCH v5 1/4] remoteproc: imx_rproc: Move common structure to header file Shengjiu Wang
2021-09-26  3:07   ` Shengjiu Wang
2021-09-26  3:07 ` [PATCH v5 2/4] remoteproc: imx_rproc: Add IMX_RPROC_SCU_API method Shengjiu Wang
2021-09-26  3:07   ` Shengjiu Wang
2021-09-26  3:07 ` [PATCH v5 3/4] remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX Shengjiu Wang
2021-09-26  3:07   ` Shengjiu Wang
2021-10-06 16:25   ` Mathieu Poirier
2021-10-06 16:25     ` Mathieu Poirier
2021-10-08  1:53     ` Shengjiu Wang
2021-10-08  1:53       ` Shengjiu Wang
2021-10-08 15:42       ` Mathieu Poirier
2021-10-08 15:42         ` Mathieu Poirier
2021-09-26  3:07 ` [PATCH v5 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver Shengjiu Wang
2021-09-26  3:07   ` Shengjiu Wang
2021-09-29 22:40   ` Rob Herring
2021-09-29 22:40     ` Rob Herring
2021-09-30  2:34     ` Shengjiu Wang
2021-09-30  2:34       ` Shengjiu Wang
2021-10-01 16:40       ` Rob Herring
2021-10-01 16:40         ` Rob Herring
2021-10-08  4:12         ` Shengjiu Wang [this message]
2021-10-08  4:12           ` Shengjiu Wang
2021-10-08  7:19           ` Shengjiu Wang
2021-10-08  7:19             ` Shengjiu Wang
2021-10-08 19:26             ` Rob Herring
2021-10-08 19:26               ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA+D8ANDP0ZPFKbRaYCwD+8zE3qvckKo9JjXwNBFUPrJ66=idw@mail.gmail.com' \
    --to=shengjiu.wang@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.