* [PATCH 0/2] Remove unnecessary FIFO configurations @ 2017-09-23 19:10 Lorenzo Bianconi 2017-09-23 19:10 ` [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration Lorenzo Bianconi 2017-09-23 19:10 ` [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration Lorenzo Bianconi 0 siblings, 2 replies; 6+ messages in thread From: Lorenzo Bianconi @ 2017-09-23 19:10 UTC (permalink / raw) To: jic23; +Cc: linux-iio, lorenzo.bianconi Lorenzo Bianconi (2): iio: imu: st_lsm6dsx: remove LIR configuration iio: imu: st_lsm6dsx: remove rounding configuration drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 --------------- 1 file changed, 15 deletions(-) -- 2.14.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration 2017-09-23 19:10 [PATCH 0/2] Remove unnecessary FIFO configurations Lorenzo Bianconi @ 2017-09-23 19:10 ` Lorenzo Bianconi 2017-09-24 15:50 ` Jonathan Cameron 2017-09-23 19:10 ` [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration Lorenzo Bianconi 1 sibling, 1 reply; 6+ messages in thread From: Lorenzo Bianconi @ 2017-09-23 19:10 UTC (permalink / raw) To: jic23; +Cc: linux-iio, lorenzo.bianconi Remove Latched Interrupt configuration since it is enabled by default for FIFO watermark interrupt Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index c68cc7c91928..37d6e324ae74 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -56,8 +56,6 @@ #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK BIT(5) #define ST_LSM6DSX_REG_ROUNDING_ADDR 0x16 #define ST_LSM6DSX_REG_ROUNDING_MASK BIT(2) -#define ST_LSM6DSX_REG_LIR_ADDR 0x58 -#define ST_LSM6DSX_REG_LIR_MASK BIT(0) #define ST_LSM6DSX_REG_ACC_ODR_ADDR 0x10 #define ST_LSM6DSX_REG_ACC_ODR_MASK GENMASK(7, 4) @@ -607,12 +605,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw) msleep(200); - /* latch interrupts */ - err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_LIR_ADDR, - ST_LSM6DSX_REG_LIR_MASK, 1); - if (err < 0) - return err; - /* enable Block Data Update */ err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_BDU_ADDR, ST_LSM6DSX_REG_BDU_MASK, 1); -- 2.14.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration 2017-09-23 19:10 ` [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration Lorenzo Bianconi @ 2017-09-24 15:50 ` Jonathan Cameron 2017-09-25 7:37 ` Lorenzo Bianconi 0 siblings, 1 reply; 6+ messages in thread From: Jonathan Cameron @ 2017-09-24 15:50 UTC (permalink / raw) To: Lorenzo Bianconi; +Cc: linux-iio, lorenzo.bianconi On Sat, 23 Sep 2017 21:10:51 +0200 Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote: > Remove Latched Interrupt configuration since it is enabled by default > for FIFO watermark interrupt > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> Not the most detailed explanation ever of a change, but I guess it suffices (just!) Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > index c68cc7c91928..37d6e324ae74 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > @@ -56,8 +56,6 @@ > #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK BIT(5) > #define ST_LSM6DSX_REG_ROUNDING_ADDR 0x16 > #define ST_LSM6DSX_REG_ROUNDING_MASK BIT(2) > -#define ST_LSM6DSX_REG_LIR_ADDR 0x58 > -#define ST_LSM6DSX_REG_LIR_MASK BIT(0) > > #define ST_LSM6DSX_REG_ACC_ODR_ADDR 0x10 > #define ST_LSM6DSX_REG_ACC_ODR_MASK GENMASK(7, 4) > @@ -607,12 +605,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw) > > msleep(200); > > - /* latch interrupts */ > - err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_LIR_ADDR, > - ST_LSM6DSX_REG_LIR_MASK, 1); > - if (err < 0) > - return err; > - > /* enable Block Data Update */ > err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_BDU_ADDR, > ST_LSM6DSX_REG_BDU_MASK, 1); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration 2017-09-24 15:50 ` Jonathan Cameron @ 2017-09-25 7:37 ` Lorenzo Bianconi 0 siblings, 0 replies; 6+ messages in thread From: Lorenzo Bianconi @ 2017-09-25 7:37 UTC (permalink / raw) To: Jonathan Cameron; +Cc: linux-iio, Lorenzo BIANCONI > On Sat, 23 Sep 2017 21:10:51 +0200 > Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote: > >> Remove Latched Interrupt configuration since it is enabled by default >> for FIFO watermark interrupt >> >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> > > Not the most detailed explanation ever of a change, but I guess it > suffices (just!) Ack, sorry :) Watermark interrupt rises when the number of bytes written in FIFO is equal or grater than the watermark level and it is reset when number of samples is lower than that threshold. Consequently the is no need to configure latched mode for that interrupt source. Regards, Lorenzo > > Applied to the togreg branch of iio.git and pushed out as testing for > the autobuilders to play with it. > > Thanks, > > Jonathan > >> --- >> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >> index c68cc7c91928..37d6e324ae74 100644 >> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >> @@ -56,8 +56,6 @@ >> #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK BIT(5) >> #define ST_LSM6DSX_REG_ROUNDING_ADDR 0x16 >> #define ST_LSM6DSX_REG_ROUNDING_MASK BIT(2) >> -#define ST_LSM6DSX_REG_LIR_ADDR 0x58 >> -#define ST_LSM6DSX_REG_LIR_MASK BIT(0) >> >> #define ST_LSM6DSX_REG_ACC_ODR_ADDR 0x10 >> #define ST_LSM6DSX_REG_ACC_ODR_MASK GENMASK(7, 4) >> @@ -607,12 +605,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw) >> >> msleep(200); >> >> - /* latch interrupts */ >> - err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_LIR_ADDR, >> - ST_LSM6DSX_REG_LIR_MASK, 1); >> - if (err < 0) >> - return err; >> - >> /* enable Block Data Update */ >> err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_BDU_ADDR, >> ST_LSM6DSX_REG_BDU_MASK, 1); > -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration 2017-09-23 19:10 [PATCH 0/2] Remove unnecessary FIFO configurations Lorenzo Bianconi 2017-09-23 19:10 ` [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration Lorenzo Bianconi @ 2017-09-23 19:10 ` Lorenzo Bianconi 2017-09-24 15:50 ` Jonathan Cameron 1 sibling, 1 reply; 6+ messages in thread From: Lorenzo Bianconi @ 2017-09-23 19:10 UTC (permalink / raw) To: jic23; +Cc: linux-iio, lorenzo.bianconi Remove rounding configuration since it is enabled by default for the FIFO output registers Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index 37d6e324ae74..debf4064f474 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -54,8 +54,6 @@ #define ST_LSM6DSX_REG_BDU_MASK BIT(6) #define ST_LSM6DSX_REG_INT2_ON_INT1_ADDR 0x13 #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK BIT(5) -#define ST_LSM6DSX_REG_ROUNDING_ADDR 0x16 -#define ST_LSM6DSX_REG_ROUNDING_MASK BIT(2) #define ST_LSM6DSX_REG_ACC_ODR_ADDR 0x10 #define ST_LSM6DSX_REG_ACC_ODR_MASK GENMASK(7, 4) @@ -611,11 +609,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw) if (err < 0) return err; - err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_ROUNDING_ADDR, - ST_LSM6DSX_REG_ROUNDING_MASK, 1); - if (err < 0) - return err; - /* enable FIFO watermak interrupt */ err = st_lsm6dsx_get_drdy_reg(hw, &drdy_int_reg); if (err < 0) -- 2.14.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration 2017-09-23 19:10 ` [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration Lorenzo Bianconi @ 2017-09-24 15:50 ` Jonathan Cameron 0 siblings, 0 replies; 6+ messages in thread From: Jonathan Cameron @ 2017-09-24 15:50 UTC (permalink / raw) To: Lorenzo Bianconi; +Cc: linux-iio, lorenzo.bianconi On Sat, 23 Sep 2017 21:10:52 +0200 Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote: > Remove rounding configuration since it is enabled by default for the > FIFO output registers > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > index 37d6e324ae74..debf4064f474 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > @@ -54,8 +54,6 @@ > #define ST_LSM6DSX_REG_BDU_MASK BIT(6) > #define ST_LSM6DSX_REG_INT2_ON_INT1_ADDR 0x13 > #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK BIT(5) > -#define ST_LSM6DSX_REG_ROUNDING_ADDR 0x16 > -#define ST_LSM6DSX_REG_ROUNDING_MASK BIT(2) > > #define ST_LSM6DSX_REG_ACC_ODR_ADDR 0x10 > #define ST_LSM6DSX_REG_ACC_ODR_MASK GENMASK(7, 4) > @@ -611,11 +609,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw) > if (err < 0) > return err; > > - err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_ROUNDING_ADDR, > - ST_LSM6DSX_REG_ROUNDING_MASK, 1); > - if (err < 0) > - return err; > - > /* enable FIFO watermak interrupt */ > err = st_lsm6dsx_get_drdy_reg(hw, &drdy_int_reg); > if (err < 0) ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-25 7:37 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-23 19:10 [PATCH 0/2] Remove unnecessary FIFO configurations Lorenzo Bianconi 2017-09-23 19:10 ` [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration Lorenzo Bianconi 2017-09-24 15:50 ` Jonathan Cameron 2017-09-25 7:37 ` Lorenzo Bianconi 2017-09-23 19:10 ` [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration Lorenzo Bianconi 2017-09-24 15:50 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.