All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	kvm@vger.kernel.org, Jerome Glisse <jglisse@redhat.com>,
	Pavel Emelyanov <xemul@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Martin Cracauer <cracauer@cons.org>,
	Denis Plotnikov <dplotnikov@virtuozzo.com>,
	linux-mm <linux-mm@kvack.org>,
	Marty McFadden <mcfadden8@llnl.gov>,
	Maya Gokhale <gokhale2@llnl.gov>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Kees Cook <keescook@chromium.org>, Mel Gorman <mgorman@suse.de>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH 0/3] userfaultfd: allow to forbid unprivileged users
Date: Thu, 14 Mar 2019 08:23:13 -0700	[thread overview]
Message-ID: <CAADnVQLakteNHnoUZpOTVNK-ysbmqCRbPDM2XMgM9pWB-mGjhQ@mail.gmail.com> (raw)
In-Reply-To: <298b9469-abd2-b02b-5c71-529b8976a46c@redhat.com>

On Thu, Mar 14, 2019 at 4:00 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 14/03/19 00:44, Andrea Arcangeli wrote:
> > Then I thought we can add a tristate so an open of /dev/kvm would also
> > allow the syscall to make things more user friendly because
> > unprivileged containers ideally should have writable mounts done with
> > nodev and no matter the privilege they shouldn't ever get an hold on
> > the KVM driver (and those who do, like kubevirt, will then just work).
>
> I wouldn't even bother with the KVM special case.  Containers can use
> seccomp if they want a fine-grained policy.
>
> (Actually I wouldn't bother with the knob at all; the attack surface of
> userfaultfd is infinitesimal compared to the BPF JIT...).

please name _one_ BPF JIT bug that affected unprivileged user space.

WARNING: multiple messages have this Message-ID (diff)
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	kvm@vger.kernel.org, Jerome Glisse <jglisse@redhat.com>,
	Pavel Emelyanov <xemul@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Martin Cracauer <cracauer@cons.org>,
	Denis Plotnikov <dplotnikov@virtuozzo.com>,
	linux-mm <linux-mm@kvack.org>,
	Marty McFadden <mcfadden8@llnl.gov>,
	Maya Gokhale <gokhale2@llnl.gov>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Kees Cook <keescook@chromium.org>, Mel Gorman <mgorman@suse.de>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Linux-Fsdev
Subject: Re: [PATCH 0/3] userfaultfd: allow to forbid unprivileged users
Date: Thu, 14 Mar 2019 08:23:13 -0700	[thread overview]
Message-ID: <CAADnVQLakteNHnoUZpOTVNK-ysbmqCRbPDM2XMgM9pWB-mGjhQ@mail.gmail.com> (raw)
In-Reply-To: <298b9469-abd2-b02b-5c71-529b8976a46c@redhat.com>

On Thu, Mar 14, 2019 at 4:00 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 14/03/19 00:44, Andrea Arcangeli wrote:
> > Then I thought we can add a tristate so an open of /dev/kvm would also
> > allow the syscall to make things more user friendly because
> > unprivileged containers ideally should have writable mounts done with
> > nodev and no matter the privilege they shouldn't ever get an hold on
> > the KVM driver (and those who do, like kubevirt, will then just work).
>
> I wouldn't even bother with the KVM special case.  Containers can use
> seccomp if they want a fine-grained policy.
>
> (Actually I wouldn't bother with the knob at all; the attack surface of
> userfaultfd is infinitesimal compared to the BPF JIT...).

please name _one_ BPF JIT bug that affected unprivileged user space.

  reply	other threads:[~2019-03-14 15:23 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11  9:36 [PATCH 0/3] userfaultfd: allow to forbid unprivileged users Peter Xu
2019-03-11  9:36 ` Peter Xu
2019-03-11  9:36 ` [PATCH 1/3] userfaultfd/sysctl: introduce unprivileged_userfaultfd Peter Xu
2019-03-11  9:36   ` Peter Xu
2019-03-12  6:58   ` Mike Rapoport
2019-03-12  6:58     ` Mike Rapoport
2019-03-12 12:26     ` Peter Xu
2019-03-12 12:26       ` Peter Xu
2019-03-12 13:53       ` Mike Rapoport
2019-03-12 13:53         ` Mike Rapoport
2019-03-11  9:37 ` [PATCH 2/3] kvm/mm: introduce MMF_USERFAULTFD_ALLOW flag Peter Xu
2019-03-11  9:37   ` Peter Xu
2019-03-11  9:37 ` [PATCH 3/3] userfaultfd: apply unprivileged_userfaultfd check Peter Xu
2019-03-11  9:37   ` Peter Xu
2019-03-11  9:58   ` Peter Xu
2019-03-11  9:58     ` Peter Xu
2019-03-12  7:01 ` [PATCH 0/3] userfaultfd: allow to forbid unprivileged users Mike Rapoport
2019-03-12  7:01   ` Mike Rapoport
2019-03-12 12:29   ` Peter Xu
2019-03-12 12:29     ` Peter Xu
2019-03-12  7:49 ` Kirill A. Shutemov
2019-03-12  7:49   ` Kirill A. Shutemov
2019-03-12  7:49   ` Kirill A. Shutemov
2019-03-12 12:43   ` Peter Xu
2019-03-12 12:43     ` Peter Xu
2019-03-12 12:43     ` Peter Xu
2019-03-12 19:59 ` Mike Kravetz
2019-03-12 19:59   ` Mike Kravetz
2019-03-13  6:00   ` Peter Xu
2019-03-13  6:00     ` Peter Xu
2019-03-13  8:22     ` Paolo Bonzini
2019-03-13  8:22       ` Paolo Bonzini
2019-03-13 18:52       ` Andrea Arcangeli
2019-03-13 18:52         ` Andrea Arcangeli
2019-03-13 19:12         ` Paolo Bonzini
2019-03-13 19:12           ` Paolo Bonzini
2019-03-13 19:12           ` Paolo Bonzini
2019-03-13 23:44           ` Andrea Arcangeli
2019-03-13 23:44             ` Andrea Arcangeli
2019-03-14 10:58             ` Paolo Bonzini
2019-03-14 10:58               ` Paolo Bonzini
2019-03-14 15:23               ` Alexei Starovoitov [this message]
2019-03-14 15:23                 ` Alexei Starovoitov
2019-03-14 15:23                 ` Alexei Starovoitov
2019-03-14 16:00                 ` Paolo Bonzini
2019-03-14 16:00                   ` Paolo Bonzini
2019-03-14 16:16               ` Andrea Arcangeli
2019-03-14 16:16                 ` Andrea Arcangeli
2019-03-15 16:09                 ` Kees Cook
2019-03-15 16:09                   ` Kees Cook
2019-03-15 16:09                   ` Kees Cook
2019-03-13 20:01         ` Mike Kravetz
2019-03-13 23:55           ` Andrea Arcangeli
2019-03-13 23:55             ` Andrea Arcangeli
2019-03-14  3:32             ` Mike Kravetz
2019-03-14  3:32               ` Mike Kravetz
2019-03-13 17:50     ` Mike Kravetz
2019-03-13 17:50       ` Mike Kravetz
2019-03-15  8:26       ` Peter Xu
2019-03-15  8:26         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQLakteNHnoUZpOTVNK-ysbmqCRbPDM2XMgM9pWB-mGjhQ@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cracauer@cons.org \
    --cc=daniel@iogearbox.net \
    --cc=dgilbert@redhat.com \
    --cc=dplotnikov@virtuozzo.com \
    --cc=gokhale2@llnl.gov \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jglisse@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kirill@shutemov.name \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mcfadden8@llnl.gov \
    --cc=mcgrof@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mike.kravetz@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.