All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: srv_heupstream <srv_heupstream@mediatek.com>,
	"David Airlie" <airlied@linux.ie>,
	stonea168@163.com, cawa.cheng@mediatek.com,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sj Huang (黃信璋)" <sj.huang@mediatek.com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"Daniel Vetter" <daniel@ffwll.ch>, "CK Hu" <ck.hu@mediatek.com>,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com
Subject: Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
Date: Tue, 29 Dec 2020 23:22:12 +0800	[thread overview]
Message-ID: <CAAOTY_8MFfGg_uZDZXDuhm+jO=bc8hiXx=09Nva5vyaUrVwmKQ@mail.gmail.com> (raw)
In-Reply-To: <20201225082441.10412-1-jitao.shi@mediatek.com>

Hi, Jitao:

Jitao Shi <jitao.shi@mediatek.com> 於 2020年12月25日 週五 下午4:30寫道：
>
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
>
> Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633

I remove change-id and apply this patch to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a942c38..1d6248930bdf 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>                 goto err_unregister_host;
>         }
>
> -       irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>         ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -                              IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +                              IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>         if (ret) {
>                 dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>                 goto err_unregister_host;
> --
> 2.12.5
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: srv_heupstream <srv_heupstream@mediatek.com>,
	"David Airlie" <airlied@linux.ie>,
	stonea168@163.com, cawa.cheng@mediatek.com,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sj Huang (黃信璋)" <sj.huang@mediatek.com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com
Subject: Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
Date: Tue, 29 Dec 2020 23:22:12 +0800	[thread overview]
Message-ID: <CAAOTY_8MFfGg_uZDZXDuhm+jO=bc8hiXx=09Nva5vyaUrVwmKQ@mail.gmail.com> (raw)
In-Reply-To: <20201225082441.10412-1-jitao.shi@mediatek.com>

Hi, Jitao:

Jitao Shi <jitao.shi@mediatek.com> 於 2020年12月25日 週五 下午4:30寫道：
>
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
>
> Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633

I remove change-id and apply this patch to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a942c38..1d6248930bdf 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>                 goto err_unregister_host;
>         }
>
> -       irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>         ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -                              IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +                              IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>         if (ret) {
>                 dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>                 goto err_unregister_host;
> --
> 2.12.5
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-29 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-25  8:24 [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type Jitao Shi
2020-12-25  8:24 ` Jitao Shi
2020-12-29 15:22 ` Chun-Kuang Hu [this message]
2020-12-29 15:22   ` Chun-Kuang Hu
     [not found] <1608803643-7351-1-git-send-email-huijuan.xie@mediatek.com>
2020-12-25  2:55 ` CK Hu
2020-12-25  2:55   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAOTY_8MFfGg_uZDZXDuhm+jO=bc8hiXx=09Nva5vyaUrVwmKQ@mail.gmail.com' \
    --to=chunkuang.hu@kernel.org \
    --cc=airlied@linux.ie \
    --cc=cawa.cheng@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eddie.huang@mediatek.com \
    --cc=jitao.shi@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=stonea168@163.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.