All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
@ 2020-12-25  8:24 ` Jitao Shi
  0 siblings, 0 replies; 6+ messages in thread
From: Jitao Shi @ 2020-12-25  8:24 UTC (permalink / raw)
  To: CK Hu, David Airlie, Daniel Vetter, dri-devel
  Cc: Jitao Shi, srv_heupstream, stonea168, cawa.cheng, sj.huang,
	linux-mediatek, bibby.hsieh, Matthias Brugger, yingjoe.chen,
	eddie.huang

The interrupt trigger is already set by OF. When do devm_request_irq()
in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
again.

Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 4a188a942c38..1d6248930bdf 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
 		goto err_unregister_host;
 	}
 
-	irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
 	ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
-			       IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
+			       IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
 		goto err_unregister_host;
-- 
2.12.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
@ 2020-12-25  8:24 ` Jitao Shi
  0 siblings, 0 replies; 6+ messages in thread
From: Jitao Shi @ 2020-12-25  8:24 UTC (permalink / raw)
  To: CK Hu, David Airlie, Daniel Vetter, dri-devel
  Cc: Jitao Shi, srv_heupstream, stonea168, cawa.cheng, sj.huang,
	linux-mediatek, Matthias Brugger, yingjoe.chen, eddie.huang

The interrupt trigger is already set by OF. When do devm_request_irq()
in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
again.

Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 4a188a942c38..1d6248930bdf 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
 		goto err_unregister_host;
 	}
 
-	irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
 	ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
-			       IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
+			       IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
 		goto err_unregister_host;
-- 
2.12.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
  2020-12-25  8:24 ` Jitao Shi
@ 2020-12-29 15:22   ` Chun-Kuang Hu
  -1 siblings, 0 replies; 6+ messages in thread
From: Chun-Kuang Hu @ 2020-12-29 15:22 UTC (permalink / raw)
  To: Jitao Shi
  Cc: srv_heupstream, David Airlie, stonea168, cawa.cheng,
	DRI Development, Matthias Brugger,
	Sj Huang (黃信璋),
	moderated list:ARM/Mediatek SoC support, Daniel Vetter, CK Hu,
	yingjoe.chen, eddie.huang

Hi, Jitao:

Jitao Shi <jitao.shi@mediatek.com> 於 2020年12月25日 週五 下午4:30寫道：
>
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
>
> Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633

I remove change-id and apply this patch to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a942c38..1d6248930bdf 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>                 goto err_unregister_host;
>         }
>
> -       irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>         ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -                              IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +                              IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>         if (ret) {
>                 dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>                 goto err_unregister_host;
> --
> 2.12.5
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
@ 2020-12-29 15:22   ` Chun-Kuang Hu
  0 siblings, 0 replies; 6+ messages in thread
From: Chun-Kuang Hu @ 2020-12-29 15:22 UTC (permalink / raw)
  To: Jitao Shi
  Cc: srv_heupstream, David Airlie, stonea168, cawa.cheng,
	DRI Development, Matthias Brugger,
	Sj Huang (黃信璋),
	moderated list:ARM/Mediatek SoC support, yingjoe.chen,
	eddie.huang

Hi, Jitao:

Jitao Shi <jitao.shi@mediatek.com> 於 2020年12月25日 週五 下午4:30寫道：
>
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
>
> Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633

I remove change-id and apply this patch to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a942c38..1d6248930bdf 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>                 goto err_unregister_host;
>         }
>
> -       irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>         ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -                              IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +                              IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>         if (ret) {
>                 dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>                 goto err_unregister_host;
> --
> 2.12.5
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
       [not found] <1608803643-7351-1-git-send-email-huijuan.xie@mediatek.com>
@ 2020-12-25  2:55   ` CK Hu
  0 siblings, 0 replies; 6+ messages in thread
From: CK Hu @ 2020-12-25  2:55 UTC (permalink / raw)
  To: Huijuan Xie, Chun-Kuang Hu, Philipp Zabel
  Cc: bibby.hsieh, srv_heupstream, David Airlie, stonea168, cawa.cheng,
	dri-devel, sj.huang, linux-mediatek, Daniel Vetter,
	Matthias Brugger, yingjoe.chen, eddie.huang

+ Chun-Kuang, Philipp:


This mail has been sent to dri devel and linux mediatek, but why it does
not exist in mail lists?

Regards,
CK


On Thu, 2020-12-24 at 17:54 +0800, Huijuan Xie wrote:
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
> 
> Signed-off-by: Huijuan Xie <huijuan.xie@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a9..1d62489 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>  		goto err_unregister_host;
>  	}
>  
> -	irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>  	ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -			       IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +			       IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>  		goto err_unregister_host;

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type
@ 2020-12-25  2:55   ` CK Hu
  0 siblings, 0 replies; 6+ messages in thread
From: CK Hu @ 2020-12-25  2:55 UTC (permalink / raw)
  To: Huijuan Xie, Chun-Kuang Hu, Philipp Zabel
  Cc: srv_heupstream, David Airlie, stonea168, cawa.cheng, dri-devel,
	sj.huang, linux-mediatek, Matthias Brugger, yingjoe.chen,
	eddie.huang

+ Chun-Kuang, Philipp:


This mail has been sent to dri devel and linux mediatek, but why it does
not exist in mail lists?

Regards,
CK


On Thu, 2020-12-24 at 17:54 +0800, Huijuan Xie wrote:
> The interrupt trigger is already set by OF. When do devm_request_irq()
> in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type
> again.
> 
> Signed-off-by: Huijuan Xie <huijuan.xie@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a188a9..1d62489 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>  		goto err_unregister_host;
>  	}
>  
> -	irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW);
>  	ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> -			       IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
> +			       IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
>  		goto err_unregister_host;

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-29 15:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25  8:24 [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type Jitao Shi
2020-12-25  8:24 ` Jitao Shi
2020-12-29 15:22 ` Chun-Kuang Hu
2020-12-29 15:22   ` Chun-Kuang Hu
     [not found] <1608803643-7351-1-git-send-email-huijuan.xie@mediatek.com>
2020-12-25  2:55 ` CK Hu
2020-12-25  2:55   ` CK Hu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.