Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD

From: Inki Dae <inki.dae@samsung.com>
To: Vikas Sajjan <sajjan.linux@gmail.com>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	sunil joshi <joshi@samsung.com>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD
Date: Tue, 2 Apr 2013 17:57:14 +0900	[thread overview]
Message-ID: <CAAQKjZPuQeoS_2+daDqTM1auSRcO5ZpeWBdBhTob7pu8cu+jiw@mail.gmail.com> (raw)
In-Reply-To: <CAGm_ybjbui9YEPpjg8qFz0pGxYiHAdubAC7nbgH_Fr8JnUmoNw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2228 bytes --]

Applied. :)

Thanks,
Inki Dae


2013/4/2 Vikas Sajjan <sajjan.linux@gmail.com>

> Hi Mr. Inki Dae,
>
> Can you please review this patch.?
>
> On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan <vikas.sajjan@linaro.org>
> wrote:
> > Replaces the "platform_get_resource() for IORESOURCE_IRQ" with
> > platform_get_resource_byname().
> > Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order:
> "fifo",
> > "vsync", and "lcd_sys".
> > But The FIMD driver expects the "vsync" interrupt to be mentioned as the
> > 1st parameter in the FIMD DT node. So to meet this expectation of the
> > driver, the FIMD DT node was forced to be made by keeping "vsync" as the
> > 1st paramter.
> > For example in exynos4, the FIMD DT node has interrupt numbers
> > mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter.
> >
> > This patch fixes the above mentioned "hack" of re-ordering of the
> > FIMD interrupt numbers by getting interrupt resource of FIMD by using
> > platform_get_resource_byname().
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_fimd.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > index 1ea173a..cd79d38 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev)
> >                 return -ENXIO;
> >         }
> >
> > -       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > +       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
> "vsync");
> >         if (!res) {
> >                 dev_err(dev, "irq request failed.\n");
> >                 return -ENXIO;
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

[-- Attachment #1.2: Type: text/html, Size: 3488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel